All of lore.kernel.org
 help / color / mirror / Atom feed
From: Lee Jones <lee@kernel.org>
To: Alex Elder <elder@riscstar.com>
Cc: lgirdwood@gmail.com, broonie@kernel.org, robh@kernel.org,
	krzk+dt@kernel.org, conor+dt@kernel.org, dlan@gentoo.org,
	paul.walmsley@sifive.com, palmer@dabbelt.com,
	aou@eecs.berkeley.edu, alex@ghiti.fr, troymitchell988@gmail.com,
	guodong@riscstar.com, devicetree@vger.kernel.org,
	linux-riscv@lists.infradead.org, spacemit@lists.linux.dev,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/6] mfd: spacemit: add support for SpacemiT PMICs
Date: Thu, 19 Jun 2025 15:41:47 +0100	[thread overview]
Message-ID: <20250619144147.GH795775@google.com> (raw)
In-Reply-To: <20250619144023.GG795775@google.com>

On Thu, 19 Jun 2025, Lee Jones wrote:

> On Fri, 13 Jun 2025, Alex Elder wrote:
> 
> > Add support for SpacemiT PMICs. Initially only the P1 PMIC is supported
> > but the driver is structured to allow support for others to be added.
> > 
> > The P1 PMIC is controlled by I2C, and is normally implemented with the
> > SpacemiT K1 SoC.  This PMIC provides six buck converters and 12 LDO
> 
> six or 12.  Please pick a format and remain consistent.
> 
> > regulators.  It also implements a switch, watchdog timer, real-time clock,
> > and more, but initially we will only support its regulators.
> 
> You have to provide support for more than one device for this to be
> accepted into MFD.
> 
> > Signed-off-by: Alex Elder <elder@riscstar.com>
> > ---
> >  drivers/mfd/Kconfig         | 11 +++++
> >  drivers/mfd/Makefile        |  1 +
> >  drivers/mfd/spacemit-pmic.c | 91 +++++++++++++++++++++++++++++++++++++
> >  3 files changed, 103 insertions(+)
> >  create mode 100644 drivers/mfd/spacemit-pmic.c

Right now, it looks like all you need is:

drivers/mfd/simple-mfd-i2c.c

-- 
Lee Jones [李琼斯]

_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv

WARNING: multiple messages have this Message-ID (diff)
From: Lee Jones <lee@kernel.org>
To: Alex Elder <elder@riscstar.com>
Cc: lgirdwood@gmail.com, broonie@kernel.org, robh@kernel.org,
	krzk+dt@kernel.org, conor+dt@kernel.org, dlan@gentoo.org,
	paul.walmsley@sifive.com, palmer@dabbelt.com,
	aou@eecs.berkeley.edu, alex@ghiti.fr, troymitchell988@gmail.com,
	guodong@riscstar.com, devicetree@vger.kernel.org,
	linux-riscv@lists.infradead.org, spacemit@lists.linux.dev,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/6] mfd: spacemit: add support for SpacemiT PMICs
Date: Thu, 19 Jun 2025 15:41:47 +0100	[thread overview]
Message-ID: <20250619144147.GH795775@google.com> (raw)
In-Reply-To: <20250619144023.GG795775@google.com>

On Thu, 19 Jun 2025, Lee Jones wrote:

> On Fri, 13 Jun 2025, Alex Elder wrote:
> 
> > Add support for SpacemiT PMICs. Initially only the P1 PMIC is supported
> > but the driver is structured to allow support for others to be added.
> > 
> > The P1 PMIC is controlled by I2C, and is normally implemented with the
> > SpacemiT K1 SoC.  This PMIC provides six buck converters and 12 LDO
> 
> six or 12.  Please pick a format and remain consistent.
> 
> > regulators.  It also implements a switch, watchdog timer, real-time clock,
> > and more, but initially we will only support its regulators.
> 
> You have to provide support for more than one device for this to be
> accepted into MFD.
> 
> > Signed-off-by: Alex Elder <elder@riscstar.com>
> > ---
> >  drivers/mfd/Kconfig         | 11 +++++
> >  drivers/mfd/Makefile        |  1 +
> >  drivers/mfd/spacemit-pmic.c | 91 +++++++++++++++++++++++++++++++++++++
> >  3 files changed, 103 insertions(+)
> >  create mode 100644 drivers/mfd/spacemit-pmic.c

Right now, it looks like all you need is:

drivers/mfd/simple-mfd-i2c.c

-- 
Lee Jones [李琼斯]

  reply	other threads:[~2025-06-19 18:36 UTC|newest]

Thread overview: 44+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-06-13 21:01 [PATCH 0/6] spacemit: introduce P1 PMIC and regulator support Alex Elder
2025-06-13 21:01 ` Alex Elder
2025-06-13 21:01 ` [PATCH 1/6] dt-bindings: mfd: add support the SpacmiT P1 PMIC Alex Elder
2025-06-13 21:01   ` Alex Elder
2025-06-19  6:03   ` Vivian Wang
2025-06-19  6:03     ` Vivian Wang
2025-06-19 13:23     ` Alex Elder
2025-06-19 13:23       ` Alex Elder
2025-06-13 21:01 ` [PATCH 2/6] mfd: spacemit: add support for SpacemiT PMICs Alex Elder
2025-06-13 21:01   ` Alex Elder
2025-06-19  5:46   ` Vivian Wang
2025-06-19  5:46     ` Vivian Wang
2025-06-19 13:23     ` Alex Elder
2025-06-19 13:23       ` Alex Elder
2025-06-19 14:40   ` Lee Jones
2025-06-19 14:40     ` Lee Jones
2025-06-19 14:41     ` Lee Jones [this message]
2025-06-19 14:41       ` Lee Jones
2025-06-20 14:10       ` Alex Elder
2025-06-20 14:10         ` Alex Elder
2025-06-20 14:10     ` Alex Elder
2025-06-20 14:10       ` Alex Elder
2025-06-25  8:21       ` Lee Jones
2025-06-25  8:21         ` Lee Jones
2025-06-25 11:48         ` Alex Elder
2025-06-25 11:48           ` Alex Elder
2025-06-25 13:33           ` Lee Jones
2025-06-25 13:33             ` Lee Jones
2025-06-13 21:01 ` [PATCH 3/6] regulator: spacemit: support SpacemiT P1 regulators Alex Elder
2025-06-13 21:01   ` Alex Elder
2025-06-14 11:03   ` Mark Brown
2025-06-14 11:03     ` Mark Brown
2025-06-19  6:15   ` Vivian Wang
2025-06-19  6:15     ` Vivian Wang
2025-06-19 13:23     ` Alex Elder
2025-06-19 13:23       ` Alex Elder
2025-06-19 14:13       ` Vivian Wang
2025-06-19 14:13         ` Vivian Wang
2025-06-13 21:01 ` [PATCH 4/6] riscv: dts: spacemit: enable the i2c8 adapter Alex Elder
2025-06-13 21:01   ` Alex Elder
2025-06-13 21:01 ` [PATCH 5/6] riscv: dts: spacemit: define fixed regulators Alex Elder
2025-06-13 21:01   ` Alex Elder
2025-06-13 21:01 ` [PATCH 6/6] riscv: dts: spacemit: define regulator constraints Alex Elder
2025-06-13 21:01   ` Alex Elder

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250619144147.GH795775@google.com \
    --to=lee@kernel.org \
    --cc=alex@ghiti.fr \
    --cc=aou@eecs.berkeley.edu \
    --cc=broonie@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dlan@gentoo.org \
    --cc=elder@riscstar.com \
    --cc=guodong@riscstar.com \
    --cc=krzk+dt@kernel.org \
    --cc=lgirdwood@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-riscv@lists.infradead.org \
    --cc=palmer@dabbelt.com \
    --cc=paul.walmsley@sifive.com \
    --cc=robh@kernel.org \
    --cc=spacemit@lists.linux.dev \
    --cc=troymitchell988@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.