From: kernel test robot <lkp@intel.com>
To: Sakari Ailus <sakari.ailus@linux.intel.com>, linux-media@vger.kernel.org
Cc: llvm@lists.linux.dev, oe-kbuild-all@lists.linux.dev,
bingbu.cao@linux.intel.com, stanislaw.gruszka@linux.intel.com,
tian.shu.qiu@intel.com, tomi.valkeinen@ideasonboard.com,
laurent.pinchart@ideasonboard.com
Subject: Re: [PATCH 03/13] media: ipu6: Enable and disable each stream at CSI-2 subdev source pad
Date: Thu, 19 Jun 2025 20:23:36 +0800 [thread overview]
Message-ID: <202506192043.sWSo3Ycl-lkp@intel.com> (raw)
In-Reply-To: <20250619081546.1582969-4-sakari.ailus@linux.intel.com>
Hi Sakari,
kernel test robot noticed the following build warnings:
[auto build test WARNING on linuxtv-media-pending/master]
[also build test WARNING on linus/master v6.16-rc2 next-20250618]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Sakari-Ailus/media-ipu6-Use-correct-pads-for-xlate_streams/20250619-161847
base: https://git.linuxtv.org/media-ci/media-pending.git master
patch link: https://lore.kernel.org/r/20250619081546.1582969-4-sakari.ailus%40linux.intel.com
patch subject: [PATCH 03/13] media: ipu6: Enable and disable each stream at CSI-2 subdev source pad
config: i386-buildonly-randconfig-005-20250619 (https://download.01.org/0day-ci/archive/20250619/202506192043.sWSo3Ycl-lkp@intel.com/config)
compiler: clang version 20.1.2 (https://github.com/llvm/llvm-project 58df0ef89dd64126512e4ee27b4ac3fd8ddf6247)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250619/202506192043.sWSo3Ycl-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202506192043.sWSo3Ycl-lkp@intel.com/
All warnings (new ones prefixed by >>):
>> drivers/media/pci/intel/ipu6/ipu6-isys-video.c:996:6: warning: variable 'stream_mask' set but not used [-Wunused-but-set-variable]
996 | u64 stream_mask = 0;
| ^
1 warning generated.
vim +/stream_mask +996 drivers/media/pci/intel/ipu6/ipu6-isys-video.c
3c1dfb5a69cf83 Bingbu Cao 2024-01-31 983
3c1dfb5a69cf83 Bingbu Cao 2024-01-31 984 int ipu6_isys_video_set_streaming(struct ipu6_isys_video *av, int state,
3c1dfb5a69cf83 Bingbu Cao 2024-01-31 985 struct ipu6_isys_buffer_list *bl)
3c1dfb5a69cf83 Bingbu Cao 2024-01-31 986 {
3c1dfb5a69cf83 Bingbu Cao 2024-01-31 987 struct v4l2_subdev_krouting *routing;
3c1dfb5a69cf83 Bingbu Cao 2024-01-31 988 struct ipu6_isys_stream *stream = av->stream;
3c1dfb5a69cf83 Bingbu Cao 2024-01-31 989 struct v4l2_subdev_state *subdev_state;
3c1dfb5a69cf83 Bingbu Cao 2024-01-31 990 struct device *dev = &av->isys->adev->auxdev.dev;
3c1dfb5a69cf83 Bingbu Cao 2024-01-31 991 struct v4l2_subdev *sd;
3c1dfb5a69cf83 Bingbu Cao 2024-01-31 992 struct media_pad *r_pad;
e232e72fbaa788 Sakari Ailus 2025-06-19 993 unsigned int i;
3c1dfb5a69cf83 Bingbu Cao 2024-01-31 994 u32 sink_pad, sink_stream;
3c1dfb5a69cf83 Bingbu Cao 2024-01-31 995 u64 r_stream;
3c1dfb5a69cf83 Bingbu Cao 2024-01-31 @996 u64 stream_mask = 0;
3c1dfb5a69cf83 Bingbu Cao 2024-01-31 997 int ret = 0;
3c1dfb5a69cf83 Bingbu Cao 2024-01-31 998
3c1dfb5a69cf83 Bingbu Cao 2024-01-31 999 dev_dbg(dev, "set stream: %d\n", state);
3c1dfb5a69cf83 Bingbu Cao 2024-01-31 1000
3c1dfb5a69cf83 Bingbu Cao 2024-01-31 1001 if (WARN(!stream->source_entity, "No source entity for stream\n"))
3c1dfb5a69cf83 Bingbu Cao 2024-01-31 1002 return -ENODEV;
3c1dfb5a69cf83 Bingbu Cao 2024-01-31 1003
3c1dfb5a69cf83 Bingbu Cao 2024-01-31 1004 sd = &stream->asd->sd;
3c1dfb5a69cf83 Bingbu Cao 2024-01-31 1005 r_pad = media_pad_remote_pad_first(&av->pad);
3c1dfb5a69cf83 Bingbu Cao 2024-01-31 1006 r_stream = ipu6_isys_get_src_stream_by_src_pad(sd, r_pad->index);
3c1dfb5a69cf83 Bingbu Cao 2024-01-31 1007
3c1dfb5a69cf83 Bingbu Cao 2024-01-31 1008 subdev_state = v4l2_subdev_lock_and_get_active_state(sd);
3c1dfb5a69cf83 Bingbu Cao 2024-01-31 1009 routing = &subdev_state->routing;
3c1dfb5a69cf83 Bingbu Cao 2024-01-31 1010 ret = v4l2_subdev_routing_find_opposite_end(routing, r_pad->index,
3c1dfb5a69cf83 Bingbu Cao 2024-01-31 1011 r_stream, &sink_pad,
3c1dfb5a69cf83 Bingbu Cao 2024-01-31 1012 &sink_stream);
3c1dfb5a69cf83 Bingbu Cao 2024-01-31 1013 v4l2_subdev_unlock_state(subdev_state);
3c1dfb5a69cf83 Bingbu Cao 2024-01-31 1014 if (ret)
3c1dfb5a69cf83 Bingbu Cao 2024-01-31 1015 return ret;
3c1dfb5a69cf83 Bingbu Cao 2024-01-31 1016
3c1dfb5a69cf83 Bingbu Cao 2024-01-31 1017 stream_mask = get_stream_mask_by_pipeline(av);
3c1dfb5a69cf83 Bingbu Cao 2024-01-31 1018 if (!state) {
3c1dfb5a69cf83 Bingbu Cao 2024-01-31 1019 stop_streaming_firmware(av);
3c1dfb5a69cf83 Bingbu Cao 2024-01-31 1020
3c1dfb5a69cf83 Bingbu Cao 2024-01-31 1021 /* stop sub-device which connects with video */
e232e72fbaa788 Sakari Ailus 2025-06-19 1022 for (i = CSI2_PAD_SRC; i < NR_OF_CSI2_SRC_PADS; i++) {
e232e72fbaa788 Sakari Ailus 2025-06-19 1023 if (!media_pad_pipeline(&sd->entity.pads[i]))
e232e72fbaa788 Sakari Ailus 2025-06-19 1024 continue;
e232e72fbaa788 Sakari Ailus 2025-06-19 1025 ret = v4l2_subdev_disable_streams(sd, i, 1U);
3c1dfb5a69cf83 Bingbu Cao 2024-01-31 1026 if (ret) {
e232e72fbaa788 Sakari Ailus 2025-06-19 1027 dev_err(dev, "stream off %s failed with %d\n",
e232e72fbaa788 Sakari Ailus 2025-06-19 1028 sd->name, ret);
3c1dfb5a69cf83 Bingbu Cao 2024-01-31 1029 return ret;
3c1dfb5a69cf83 Bingbu Cao 2024-01-31 1030 }
e232e72fbaa788 Sakari Ailus 2025-06-19 1031 }
3c1dfb5a69cf83 Bingbu Cao 2024-01-31 1032 close_streaming_firmware(av);
3c1dfb5a69cf83 Bingbu Cao 2024-01-31 1033 } else {
3c1dfb5a69cf83 Bingbu Cao 2024-01-31 1034 ret = start_stream_firmware(av, bl);
3c1dfb5a69cf83 Bingbu Cao 2024-01-31 1035 if (ret) {
3c1dfb5a69cf83 Bingbu Cao 2024-01-31 1036 dev_err(dev, "start stream of firmware failed\n");
3c1dfb5a69cf83 Bingbu Cao 2024-01-31 1037 return ret;
3c1dfb5a69cf83 Bingbu Cao 2024-01-31 1038 }
3c1dfb5a69cf83 Bingbu Cao 2024-01-31 1039
3c1dfb5a69cf83 Bingbu Cao 2024-01-31 1040 /* start sub-device which connects with video */
e232e72fbaa788 Sakari Ailus 2025-06-19 1041 for (i = CSI2_PAD_SRC; i < NR_OF_CSI2_SRC_PADS; i++) {
e232e72fbaa788 Sakari Ailus 2025-06-19 1042 if (!media_pad_pipeline(&sd->entity.pads[i]))
e232e72fbaa788 Sakari Ailus 2025-06-19 1043 continue;
e232e72fbaa788 Sakari Ailus 2025-06-19 1044 ret = v4l2_subdev_enable_streams(sd, i, 1U);
3c1dfb5a69cf83 Bingbu Cao 2024-01-31 1045 if (ret) {
e232e72fbaa788 Sakari Ailus 2025-06-19 1046 dev_err(dev, "stream on %s failed with %d\n",
e232e72fbaa788 Sakari Ailus 2025-06-19 1047 sd->name, ret);
3c1dfb5a69cf83 Bingbu Cao 2024-01-31 1048 goto out_media_entity_stop_streaming_firmware;
3c1dfb5a69cf83 Bingbu Cao 2024-01-31 1049 }
3c1dfb5a69cf83 Bingbu Cao 2024-01-31 1050 }
e232e72fbaa788 Sakari Ailus 2025-06-19 1051 }
3c1dfb5a69cf83 Bingbu Cao 2024-01-31 1052
3c1dfb5a69cf83 Bingbu Cao 2024-01-31 1053 av->streaming = state;
3c1dfb5a69cf83 Bingbu Cao 2024-01-31 1054
3c1dfb5a69cf83 Bingbu Cao 2024-01-31 1055 return 0;
3c1dfb5a69cf83 Bingbu Cao 2024-01-31 1056
3c1dfb5a69cf83 Bingbu Cao 2024-01-31 1057 out_media_entity_stop_streaming_firmware:
e232e72fbaa788 Sakari Ailus 2025-06-19 1058 while (i-- > CSI2_PAD_SRC) {
e232e72fbaa788 Sakari Ailus 2025-06-19 1059 int ret2;
e232e72fbaa788 Sakari Ailus 2025-06-19 1060
e232e72fbaa788 Sakari Ailus 2025-06-19 1061 if (!media_pad_pipeline(&sd->entity.pads[i]))
e232e72fbaa788 Sakari Ailus 2025-06-19 1062 continue;
e232e72fbaa788 Sakari Ailus 2025-06-19 1063 ret2 = v4l2_subdev_disable_streams(sd, i, 1U);
e232e72fbaa788 Sakari Ailus 2025-06-19 1064 dev_err(dev, "stream off %s failed with %d\n", sd->name, ret2);
e232e72fbaa788 Sakari Ailus 2025-06-19 1065 }
e232e72fbaa788 Sakari Ailus 2025-06-19 1066
3c1dfb5a69cf83 Bingbu Cao 2024-01-31 1067 stop_streaming_firmware(av);
3c1dfb5a69cf83 Bingbu Cao 2024-01-31 1068
3c1dfb5a69cf83 Bingbu Cao 2024-01-31 1069 return ret;
3c1dfb5a69cf83 Bingbu Cao 2024-01-31 1070 }
3c1dfb5a69cf83 Bingbu Cao 2024-01-31 1071
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
next prev parent reply other threads:[~2025-06-19 12:23 UTC|newest]
Thread overview: 67+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-19 8:15 [PATCH 00/13] Streaming control for MC with metadata or streams otherwise Sakari Ailus
2025-06-19 8:15 ` [PATCH 01/13] media: ipu6: Use correct pads for xlate_streams() Sakari Ailus
2025-06-19 13:27 ` Laurent Pinchart
2025-06-19 13:55 ` Sakari Ailus
2025-06-19 14:15 ` Laurent Pinchart
2025-06-19 14:28 ` Sakari Ailus
2025-06-19 15:08 ` Laurent Pinchart
2025-06-19 8:15 ` [PATCH 02/13] media: ipu6: Set minimum height to 1 Sakari Ailus
2025-06-19 13:27 ` Laurent Pinchart
2025-06-19 8:15 ` [PATCH 03/13] media: ipu6: Enable and disable each stream at CSI-2 subdev source pad Sakari Ailus
2025-06-19 12:23 ` kernel test robot [this message]
2025-06-19 12:48 ` Laurent Pinchart
2025-06-19 13:10 ` Sakari Ailus
2025-06-19 13:19 ` Laurent Pinchart
2025-06-19 13:52 ` Sakari Ailus
2025-06-19 8:15 ` [PATCH 04/13] media: v4l2-subdev: Add a helper to figure out the pad streaming state Sakari Ailus
2025-06-19 13:37 ` Laurent Pinchart
2025-06-19 8:15 ` [PATCH 05/13] media: v4l: Make media_entity_to_video_device() NULL-safe Sakari Ailus
2025-06-19 15:20 ` Laurent Pinchart
2025-06-19 16:14 ` Sakari Ailus
2025-07-08 11:56 ` Laurent Pinchart
2025-07-08 12:02 ` Sakari Ailus
2025-07-08 16:17 ` Laurent Pinchart
2025-07-09 20:03 ` Sakari Ailus
2025-07-09 20:54 ` Laurent Pinchart
2025-07-10 6:57 ` Sakari Ailus
2025-06-19 8:15 ` [PATCH 06/13] media: v4l2-subdev: Mark both streams of a route enabled Sakari Ailus
2025-06-19 16:56 ` Laurent Pinchart
2025-06-19 18:34 ` Sakari Ailus
2025-06-19 22:18 ` Laurent Pinchart
2025-06-25 16:10 ` Sakari Ailus
2025-06-26 15:22 ` Tomi Valkeinen
2025-06-26 19:13 ` Laurent Pinchart
2025-06-26 15:17 ` Tomi Valkeinen
2025-06-27 6:09 ` Sakari Ailus
2025-06-30 0:47 ` Laurent Pinchart
2025-06-19 8:15 ` [PATCH 07/13] media: ipu6: Set up CSI-2 receiver at correct moment Sakari Ailus
2025-06-19 17:00 ` Laurent Pinchart
2025-06-19 17:20 ` Sakari Ailus
2025-06-19 8:15 ` [PATCH 08/13] media: v4l2-subdev: Print early in v4l2_subdev_{enable,disable}_streams() Sakari Ailus
2025-06-19 17:03 ` Laurent Pinchart
2025-06-25 16:12 ` Sakari Ailus
2025-06-19 8:15 ` [PATCH 09/13] media: v4l2-subdev: Collect streams on source pads only Sakari Ailus
2025-06-19 17:07 ` Laurent Pinchart
2025-06-25 16:14 ` Sakari Ailus
2025-06-19 8:15 ` [PATCH 10/13] media: v4l2-subdev: Add debug prints to v4l2_subdev_collect_streams() Sakari Ailus
2025-06-19 22:23 ` Laurent Pinchart
2025-06-25 16:28 ` Sakari Ailus
2025-06-19 8:15 ` [PATCH 11/13] media: v4l2-subdev: Introduce v4l2_subdev_find_route() Sakari Ailus
2025-06-20 8:14 ` Jacopo Mondi
2025-06-25 16:53 ` Sakari Ailus
2025-06-26 22:20 ` Laurent Pinchart
2025-07-15 14:09 ` Sakari Ailus
2025-06-19 8:15 ` [PATCH 12/13] media: v4l2-mc: Introduce v4l2_mc_pipeline_enabled() Sakari Ailus
2025-06-19 11:42 ` kernel test robot
2025-06-20 3:58 ` Dan Carpenter
2025-06-20 8:53 ` Jacopo Mondi
2025-06-21 8:10 ` Sakari Ailus
2025-07-15 10:49 ` Sakari Ailus
2025-07-15 11:25 ` Laurent Pinchart
2025-07-15 11:32 ` Sakari Ailus
2025-07-15 18:18 ` Laurent Pinchart
2025-06-23 9:48 ` kernel test robot
2025-06-26 23:07 ` Laurent Pinchart
2025-08-04 11:32 ` Sakari Ailus
2025-08-04 11:46 ` Laurent Pinchart
2025-06-19 8:15 ` [PATCH 13/13] media: ipu6: isys: Rework stream starting and stopping Sakari Ailus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202506192043.sWSo3Ycl-lkp@intel.com \
--to=lkp@intel.com \
--cc=bingbu.cao@linux.intel.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-media@vger.kernel.org \
--cc=llvm@lists.linux.dev \
--cc=oe-kbuild-all@lists.linux.dev \
--cc=sakari.ailus@linux.intel.com \
--cc=stanislaw.gruszka@linux.intel.com \
--cc=tian.shu.qiu@intel.com \
--cc=tomi.valkeinen@ideasonboard.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.