* [PATCH] drm/bridge: ti-sn65dsi86: remove unnecessary GPIO line direction check
@ 2025-06-20 7:49 Bartosz Golaszewski
2025-06-25 18:25 ` Doug Anderson
0 siblings, 1 reply; 3+ messages in thread
From: Bartosz Golaszewski @ 2025-06-20 7:49 UTC (permalink / raw)
To: Douglas Anderson, Andrzej Hajda, Neil Armstrong, Robert Foss,
Laurent Pinchart, Jonas Karlman, Jernej Skrabec,
Maarten Lankhorst, Maxime Ripard, Thomas Zimmermann, David Airlie,
Simona Vetter
Cc: dri-devel, linux-kernel, Bartosz Golaszewski
From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
As of commit 92ac7de3175e3 ("gpiolib: don't allow setting values on input
lines"), the GPIO core makes sure values cannot be set on input lines.
Remove the unnecessary check.
Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
---
drivers/gpu/drm/bridge/ti-sn65dsi86.c | 5 -----
1 file changed, 5 deletions(-)
diff --git a/drivers/gpu/drm/bridge/ti-sn65dsi86.c b/drivers/gpu/drm/bridge/ti-sn65dsi86.c
index 78a50b947a08..3d0b4bc5129d 100644
--- a/drivers/gpu/drm/bridge/ti-sn65dsi86.c
+++ b/drivers/gpu/drm/bridge/ti-sn65dsi86.c
@@ -1677,11 +1677,6 @@ static int ti_sn_bridge_gpio_set(struct gpio_chip *chip, unsigned int offset,
{
struct ti_sn65dsi86 *pdata = gpiochip_get_data(chip);
- if (!test_bit(offset, pdata->gchip_output)) {
- dev_err(pdata->dev, "Ignoring GPIO set while input\n");
- return -EPERM;
- }
-
val &= 1;
return regmap_update_bits(pdata->regmap, SN_GPIO_IO_REG,
BIT(SN_GPIO_OUTPUT_SHIFT + offset),
--
2.48.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] drm/bridge: ti-sn65dsi86: remove unnecessary GPIO line direction check
2025-06-20 7:49 [PATCH] drm/bridge: ti-sn65dsi86: remove unnecessary GPIO line direction check Bartosz Golaszewski
@ 2025-06-25 18:25 ` Doug Anderson
2025-06-26 14:40 ` Doug Anderson
0 siblings, 1 reply; 3+ messages in thread
From: Doug Anderson @ 2025-06-25 18:25 UTC (permalink / raw)
To: Bartosz Golaszewski
Cc: Andrzej Hajda, Neil Armstrong, Robert Foss, Laurent Pinchart,
Jonas Karlman, Jernej Skrabec, Maarten Lankhorst, Maxime Ripard,
Thomas Zimmermann, David Airlie, Simona Vetter, dri-devel,
linux-kernel, Bartosz Golaszewski
Hi,
On Fri, Jun 20, 2025 at 12:50 AM Bartosz Golaszewski <brgl@bgdev.pl> wrote:
>
> From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
>
> As of commit 92ac7de3175e3 ("gpiolib: don't allow setting values on input
> lines"), the GPIO core makes sure values cannot be set on input lines.
> Remove the unnecessary check.
>
> Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
> ---
> drivers/gpu/drm/bridge/ti-sn65dsi86.c | 5 -----
> 1 file changed, 5 deletions(-)
Reviewed-by: Douglas Anderson <dianders@chromium.org>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] drm/bridge: ti-sn65dsi86: remove unnecessary GPIO line direction check
2025-06-25 18:25 ` Doug Anderson
@ 2025-06-26 14:40 ` Doug Anderson
0 siblings, 0 replies; 3+ messages in thread
From: Doug Anderson @ 2025-06-26 14:40 UTC (permalink / raw)
To: Bartosz Golaszewski
Cc: Andrzej Hajda, Neil Armstrong, Robert Foss, Laurent Pinchart,
Jonas Karlman, Jernej Skrabec, Maarten Lankhorst, Maxime Ripard,
Thomas Zimmermann, David Airlie, Simona Vetter, dri-devel,
linux-kernel, Bartosz Golaszewski
Hi,
On Wed, Jun 25, 2025 at 11:25 AM Doug Anderson <dianders@chromium.org> wrote:
>
> Hi,
>
> On Fri, Jun 20, 2025 at 12:50 AM Bartosz Golaszewski <brgl@bgdev.pl> wrote:
> >
> > From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
> >
> > As of commit 92ac7de3175e3 ("gpiolib: don't allow setting values on input
> > lines"), the GPIO core makes sure values cannot be set on input lines.
> > Remove the unnecessary check.
> >
> > Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
> > ---
> > drivers/gpu/drm/bridge/ti-sn65dsi86.c | 5 -----
> > 1 file changed, 5 deletions(-)
>
> Reviewed-by: Douglas Anderson <dianders@chromium.org>
Pushed to drm-misc-next:
[1/1] drm/bridge: ti-sn65dsi86: remove unnecessary GPIO line direction check
commit: bffc0692359f8d06d989657c00b274802a791692
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2025-06-26 14:40 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-06-20 7:49 [PATCH] drm/bridge: ti-sn65dsi86: remove unnecessary GPIO line direction check Bartosz Golaszewski
2025-06-25 18:25 ` Doug Anderson
2025-06-26 14:40 ` Doug Anderson
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.