From: Jason Gunthorpe <jgg@ziepe.ca>
To: Benjamin Gaignard <benjamin.gaignard@collabora.com>
Cc: joro@8bytes.org, will@kernel.org, robin.murphy@arm.com,
robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org,
heiko@sntech.de, nicolas.dufresne@collabora.com,
iommu@lists.linux.dev, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org, kernel@collabora.com
Subject: Re: [PATCH v3 3/5] iommu: Add verisilicon IOMMU driver
Date: Fri, 20 Jun 2025 13:36:15 -0300 [thread overview]
Message-ID: <20250620163615.GC39770@ziepe.ca> (raw)
In-Reply-To: <d9a1b9ab-b6ab-4364-a1b7-df4debc21bc1@collabora.com>
On Fri, Jun 20, 2025 at 03:52:46PM +0200, Benjamin Gaignard wrote:
> > > vsi_iommu_suspend() and vsi_iommu_resume() will also have to take the lock
> > > before calling vsi_iommu_disable() and vsi_iommu_enable().
> > Yes, if they use iommu->domain that seems good
> >
> > If the above locking is a problem then I'd use the group mutex instead
> > during resume/suspend. The attach functions are already called with
> > the group mutex held.
>
> Does group mutex is also called when using vsi_iommu_map or vsi_iommu_unmap ?
No
Jason
WARNING: multiple messages have this Message-ID (diff)
From: Jason Gunthorpe <jgg@ziepe.ca>
To: Benjamin Gaignard <benjamin.gaignard@collabora.com>
Cc: joro@8bytes.org, will@kernel.org, robin.murphy@arm.com,
robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org,
heiko@sntech.de, nicolas.dufresne@collabora.com,
iommu@lists.linux.dev, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org, kernel@collabora.com
Subject: Re: [PATCH v3 3/5] iommu: Add verisilicon IOMMU driver
Date: Fri, 20 Jun 2025 13:36:15 -0300 [thread overview]
Message-ID: <20250620163615.GC39770@ziepe.ca> (raw)
In-Reply-To: <d9a1b9ab-b6ab-4364-a1b7-df4debc21bc1@collabora.com>
On Fri, Jun 20, 2025 at 03:52:46PM +0200, Benjamin Gaignard wrote:
> > > vsi_iommu_suspend() and vsi_iommu_resume() will also have to take the lock
> > > before calling vsi_iommu_disable() and vsi_iommu_enable().
> > Yes, if they use iommu->domain that seems good
> >
> > If the above locking is a problem then I'd use the group mutex instead
> > during resume/suspend. The attach functions are already called with
> > the group mutex held.
>
> Does group mutex is also called when using vsi_iommu_map or vsi_iommu_unmap ?
No
Jason
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
next prev parent reply other threads:[~2025-06-20 17:10 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-19 13:12 [PATCH v3 0/5] Add support for Verisilicon IOMMU used by media codec blocks Benjamin Gaignard
2025-06-19 13:12 ` Benjamin Gaignard
2025-06-19 13:12 ` [PATCH v3 1/5] dt-bindings: vendor-prefixes: Add Verisilicon Benjamin Gaignard
2025-06-19 13:12 ` Benjamin Gaignard
2025-06-19 13:12 ` [PATCH v3 2/5] dt-bindings: iommu: verisilicon: Add binding for VSI IOMMU Benjamin Gaignard
2025-06-19 13:12 ` Benjamin Gaignard
2025-06-19 14:19 ` Sebastian Reichel
2025-06-19 14:19 ` Sebastian Reichel
2025-06-19 15:02 ` Conor Dooley
2025-06-19 15:02 ` Conor Dooley
2025-06-20 9:54 ` Benjamin Gaignard
2025-06-20 9:54 ` Benjamin Gaignard
2025-06-19 13:12 ` [PATCH v3 3/5] iommu: Add verisilicon IOMMU driver Benjamin Gaignard
2025-06-19 13:12 ` Benjamin Gaignard
2025-06-19 13:47 ` Jason Gunthorpe
2025-06-19 13:47 ` Jason Gunthorpe
2025-06-19 16:27 ` Benjamin Gaignard
2025-06-19 16:27 ` Benjamin Gaignard
2025-06-19 16:59 ` Jason Gunthorpe
2025-06-19 16:59 ` Jason Gunthorpe
2025-06-20 8:57 ` Benjamin Gaignard
2025-06-20 8:57 ` Benjamin Gaignard
2025-06-20 12:05 ` Jason Gunthorpe
2025-06-20 12:05 ` Jason Gunthorpe
2025-06-20 13:52 ` Benjamin Gaignard
2025-06-20 13:52 ` Benjamin Gaignard
2025-06-20 14:42 ` Benjamin Gaignard
2025-06-20 14:42 ` Benjamin Gaignard
2025-06-20 16:35 ` Jason Gunthorpe
2025-06-20 16:35 ` Jason Gunthorpe
2025-06-20 16:36 ` Jason Gunthorpe [this message]
2025-06-20 16:36 ` Jason Gunthorpe
2025-06-20 19:37 ` Robin Murphy
2025-06-20 19:37 ` Robin Murphy
2025-06-20 20:45 ` Lucas Stach
2025-06-20 20:45 ` Lucas Stach
2025-06-23 12:05 ` Robin Murphy
2025-06-23 12:05 ` Robin Murphy
2025-06-23 14:03 ` Benjamin Gaignard
2025-06-23 14:03 ` Benjamin Gaignard
2025-06-19 13:12 ` [PATCH v3 4/5] arm64: dts: rockchip: Add verisilicon IOMMU node on RK3588 Benjamin Gaignard
2025-06-19 13:12 ` Benjamin Gaignard
2025-06-19 13:12 ` [PATCH v3 5/5] arm64: defconfig: enable Verisilicon IOMMU Benjamin Gaignard
2025-06-19 13:12 ` Benjamin Gaignard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250620163615.GC39770@ziepe.ca \
--to=jgg@ziepe.ca \
--cc=benjamin.gaignard@collabora.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=heiko@sntech.de \
--cc=iommu@lists.linux.dev \
--cc=joro@8bytes.org \
--cc=kernel@collabora.com \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=nicolas.dufresne@collabora.com \
--cc=robh@kernel.org \
--cc=robin.murphy@arm.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.