* [frank-w-bpi-r2-4.14:6.16-rsslro 36/72] drivers/net/ethernet/mediatek/mtk_eth_path.c:225:2-3: Unneeded semicolon
@ 2025-06-22 16:41 kernel test robot
0 siblings, 0 replies; only message in thread
From: kernel test robot @ 2025-06-22 16:41 UTC (permalink / raw)
To: Frank Wunderlich; +Cc: oe-kbuild-all
tree: https://github.com/frank-w/BPI-R2-4.14 6.16-rsslro
head: 14bf550b65cbf5b2fc136cfa4f48a3475b597d25
commit: 2bc47ff7ea2ace3310b449c338064e7700ffd323 [36/72] net: ethernet: mtk_eth_soc: add paths and SerDes modes for MT7988
config: arm64-randconfig-r051-20250622 (https://download.01.org/0day-ci/archive/20250623/202506230008.c63UGFL9-lkp@intel.com/config)
compiler: aarch64-linux-gcc (GCC) 10.5.0
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202506230008.c63UGFL9-lkp@intel.com/
cocci warnings: (new ones prefixed by >>)
>> drivers/net/ethernet/mediatek/mtk_eth_path.c:225:2-3: Unneeded semicolon
vim +225 drivers/net/ethernet/mediatek/mtk_eth_path.c
200
201 static int set_mux_gmac123_to_usxgmii(struct mtk_eth *eth, u64 path)
202 {
203 unsigned int val = 0;
204 bool updated = true;
205 int mac_id = 0;
206
207 /* Disable SYSCFG1 SGMII */
208 regmap_read(eth->ethsys, ETHSYS_SYSCFG0, &val);
209
210 switch (path) {
211 case MTK_ETH_PATH_GMAC1_USXGMII:
212 val &= ~(u32)SYSCFG0_SGMII_GMAC1_V2;
213 mac_id = MTK_GMAC1_ID;
214 break;
215 case MTK_ETH_PATH_GMAC2_USXGMII:
216 val &= ~(u32)SYSCFG0_SGMII_GMAC2_V2;
217 mac_id = MTK_GMAC2_ID;
218 break;
219 case MTK_ETH_PATH_GMAC3_USXGMII:
220 val &= ~(u32)SYSCFG0_SGMII_GMAC3_V2;
221 mac_id = MTK_GMAC3_ID;
222 break;
223 default:
224 updated = false;
> 225 };
226
227 if (updated) {
228 regmap_update_bits(eth->ethsys, ETHSYS_SYSCFG0,
229 SYSCFG0_SGMII_MASK, val);
230
231 if (mac_id == MTK_GMAC2_ID)
232 regmap_set_bits(eth->infra, TOP_MISC_NETSYS_PCS_MUX,
233 MUX_G2_USXGMII_SEL);
234 }
235
236 dev_dbg(eth->dev, "path %s in %s updated = %d\n",
237 mtk_eth_path_name(path), __func__, updated);
238
239 return 0;
240 }
241
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2025-06-22 16:42 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-06-22 16:41 [frank-w-bpi-r2-4.14:6.16-rsslro 36/72] drivers/net/ethernet/mediatek/mtk_eth_path.c:225:2-3: Unneeded semicolon kernel test robot
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.