FW: [PATCH] ASoC: soc-compress: Fix race condition in soc_compr_open_fe

FW: [PATCH] ASoC: soc-compress: Fix race condition in soc_compr_open_fe

[이승빈]

Add recipient addition and modification patch to the body of the
transmission.

 

From: 이승빈 <seungbin.lee@samsung.com <mailto:seungbin.lee@samsung.com> > 
Sent: Thursday, June 19, 2025 10:25 AM
To: 'tiwai@suse.de' <tiwai@suse.de <mailto:tiwai@suse.de> >
Subject: [PATCH] ASoC: soc-compress: Fix race condition in soc_compr_open_fe

 

Hi

 

I am sending this email to report an issue found in sound/soc/soc-
compress.c.

 

Scenario: Playing a mix of MP3 and WAV files repeatedly from YouTube Music
by pressing "next".

 

Issue occurs when snd_soc_dpcm_runtime_update is called and
soc_compr_trigger_fe is invoked, causing the value of “fe-
>dpcm[stream].runtime_update” to change mid-process. This results in a
problem where, during the closing of the BE connected to the FE in
snd_soc_dpcm_runtime_update, only the entry is removed from the list
without actually being closed.

 

The attached patch resolves this issue as confirmed through testing.

 

Additionally, while performing DPCM related operations in soc-compress.c,
snd_soc_dpcm_mutex_lock is used; however, soc_compr_trigger_fe does not
have this lock. Please review the attached patch regarding this matter.

 

Thank you.

 

From 72a0340bf7dccc6f53dc2d02e04bb3f894d796e3 Mon Sep 17 00:00:00 2001

From: Seungbin Lee <seungbin.lee@samsung.com
<mailto:seungbin.lee@samsung.com> >

Date: Wed, 18 Jun 2025 13:33:02 +0900

Subject: [PATCH] ASoC: soc-compress: Fix race condition in soc_compr_open_fe

 

If the soc_compr_trigger_fe function is called during
snd_soc_dpcm_runtime_update execution,

the FE's DPCM runtime update variable may be changed.

Then the BE list connected to the FE flies away, and the BE cannot be
closed.

 

This needs to be protected by the snd_soc_dpcm_mutex_lock.

 

Change-Id: Ibfd1712e6baf41a30afa357a91ada83d205f968b

Signed-off-by: Seungbin Lee <seungbin.lee@samsung.com
<mailto:seungbin.lee@samsung.com> >

---

sound/soc/soc-compress.c | 4 ++++

1 file changed, 4 insertions(+)

 

diff --git a/sound/soc/soc-compress.c b/sound/soc/soc-compress.c

index fc8db54352541..1a2a3fe6a2340 100644

--- a/sound/soc/soc-compress.c

+++ b/sound/soc/soc-compress.c

@@ -286,6 +286,8 @@ static int soc_compr_trigger_fe(struct snd_compr_stream
*cstream, int cmd)

 

           snd_soc_card_mutex_lock(fe->card);

 

+         snd_soc_dpcm_mutex_lock(fe);

+

          ret = snd_soc_dai_compr_trigger(cpu_dai, cstream, cmd);

          if (ret < 0)

                    goto out;

@@ -315,6 +317,8 @@ static int soc_compr_trigger_fe(struct snd_compr_stream
*cstream, int cmd)

 

 out:

          fe->dpcm[stream].runtime_update = SND_SOC_DPCM_UPDATE_NO;

+         snd_soc_dpcm_mutex_unlock(fe);

+

          snd_soc_card_mutex_unlock(fe->card);

          return ret;

}

-- 

2.34.1

 

Re: FW: [PATCH] ASoC: soc-compress: Fix race condition in soc_compr_open_fe

[Greg KH]

On Mon, Jun 23, 2025 at 10:30:55AM +0900, �̽º� wrote:
> Add recipient addition and modification patch to the body of the
> transmission.
> 
>  
> 

Hi,

This is the friendly patch-bot of Greg Kroah-Hartman.  You have sent him
a patch that has triggered this response.  He used to manually respond
to these common problems, but in order to save his sanity (he kept
writing the same thing over and over, yet to different people), I was
created.  Hopefully you will not take offence and will fix the problem
in your patch and resubmit it so that it can be accepted into the Linux
kernel tree.

You are receiving this message because of the following common error(s)
as indicated below:

- Your patch is malformed (tabs converted to spaces, linewrapped, etc.)
  and can not be applied.  Please read the file,
  Documentation/process/email-clients.rst in order to fix this.

If you wish to discuss this problem further, or you have questions about
how to resolve this issue, please feel free to respond to this email and
Greg will reply once he has dug out from the pending patches received
from other developers.

thanks,

greg k-h's patch email bot