All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andrew Donnellan <ajd@linux.ibm.com>
To: linuxppc-dev@lists.ozlabs.org, pasha.tatashin@soleen.com,
	akpm@linux-foundation.org
Cc: linux-kernel@vger.kernel.org, x86@kernel.org,
	linux-riscv@lists.infradead.org,
	linux-arm-kernel@lists.infradead.org, linux-mm@kvack.org,
	sweettea-kernel@dorminy.me, christophe.leroy@csgroup.eu,
	mingo@kernel.org
Subject: [PATCH v15 10/13] powerpc: mm: Add pud_pfn() stub
Date: Wed, 25 Jun 2025 16:37:50 +1000	[thread overview]
Message-ID: <20250625063753.77511-11-ajd@linux.ibm.com> (raw)
In-Reply-To: <20250625063753.77511-1-ajd@linux.ibm.com>

From: Rohan McLure <rmclure@linux.ibm.com>

The page table check feature requires that pud_pfn() be defined
on each consuming architecture.

On powerpc, only book3s64 platforms allow for hugepages at this upper
level, and thus only book3s64 currently defines pud_pfn().

The page table check code that calls pud_pfn() is gated by a call to
pud_user_accessible_page(), which will always return false on any platform
other than book3s64.

Add a stub implementation of pud_pfn() for all platforms other than
book3s64. As it will never actually be used and should always be compiled
out, raise a BUILD_BUG() error.

[ajd@linux.ibm.com: clarify commit message]
Signed-off-by: Rohan McLure <rmclure@linux.ibm.com>
Reviewed-by: Pasha Tatashin <pasha.tatashin@soleen.com>
Signed-off-by: Andrew Donnellan <ajd@linux.ibm.com>
---
v15: clarify commit message
---
 arch/powerpc/include/asm/pgtable.h | 9 +++++++++
 1 file changed, 9 insertions(+)

diff --git a/arch/powerpc/include/asm/pgtable.h b/arch/powerpc/include/asm/pgtable.h
index 93d77ad5a92f..0f73a9ade0ed 100644
--- a/arch/powerpc/include/asm/pgtable.h
+++ b/arch/powerpc/include/asm/pgtable.h
@@ -214,6 +214,15 @@ static inline bool arch_supports_memmap_on_memory(unsigned long vmemmap_size)
 
 #endif /* CONFIG_PPC64 */
 
+#ifndef pud_pfn
+#define pud_pfn pud_pfn
+static inline int pud_pfn(pud_t pud)
+{
+	BUILD_BUG();
+	return 0;
+}
+#endif
+
 #endif /* __ASSEMBLY__ */
 
 #endif /* _ASM_POWERPC_PGTABLE_H */
-- 
2.49.0



WARNING: multiple messages have this Message-ID (diff)
From: Andrew Donnellan <ajd@linux.ibm.com>
To: linuxppc-dev@lists.ozlabs.org, pasha.tatashin@soleen.com,
	akpm@linux-foundation.org
Cc: linux-kernel@vger.kernel.org, x86@kernel.org,
	linux-riscv@lists.infradead.org,
	linux-arm-kernel@lists.infradead.org, linux-mm@kvack.org,
	sweettea-kernel@dorminy.me, christophe.leroy@csgroup.eu,
	mingo@kernel.org
Subject: [PATCH v15 10/13] powerpc: mm: Add pud_pfn() stub
Date: Wed, 25 Jun 2025 16:37:50 +1000	[thread overview]
Message-ID: <20250625063753.77511-11-ajd@linux.ibm.com> (raw)
In-Reply-To: <20250625063753.77511-1-ajd@linux.ibm.com>

From: Rohan McLure <rmclure@linux.ibm.com>

The page table check feature requires that pud_pfn() be defined
on each consuming architecture.

On powerpc, only book3s64 platforms allow for hugepages at this upper
level, and thus only book3s64 currently defines pud_pfn().

The page table check code that calls pud_pfn() is gated by a call to
pud_user_accessible_page(), which will always return false on any platform
other than book3s64.

Add a stub implementation of pud_pfn() for all platforms other than
book3s64. As it will never actually be used and should always be compiled
out, raise a BUILD_BUG() error.

[ajd@linux.ibm.com: clarify commit message]
Signed-off-by: Rohan McLure <rmclure@linux.ibm.com>
Reviewed-by: Pasha Tatashin <pasha.tatashin@soleen.com>
Signed-off-by: Andrew Donnellan <ajd@linux.ibm.com>
---
v15: clarify commit message
---
 arch/powerpc/include/asm/pgtable.h | 9 +++++++++
 1 file changed, 9 insertions(+)

diff --git a/arch/powerpc/include/asm/pgtable.h b/arch/powerpc/include/asm/pgtable.h
index 93d77ad5a92f..0f73a9ade0ed 100644
--- a/arch/powerpc/include/asm/pgtable.h
+++ b/arch/powerpc/include/asm/pgtable.h
@@ -214,6 +214,15 @@ static inline bool arch_supports_memmap_on_memory(unsigned long vmemmap_size)
 
 #endif /* CONFIG_PPC64 */
 
+#ifndef pud_pfn
+#define pud_pfn pud_pfn
+static inline int pud_pfn(pud_t pud)
+{
+	BUILD_BUG();
+	return 0;
+}
+#endif
+
 #endif /* __ASSEMBLY__ */
 
 #endif /* _ASM_POWERPC_PGTABLE_H */
-- 
2.49.0


_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv

  parent reply	other threads:[~2025-06-25  8:02 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-06-25  6:37 [PATCH v15 00/13] Support page table check on PowerPC Andrew Donnellan
2025-06-25  6:37 ` Andrew Donnellan
2025-06-25  6:37 ` [PATCH v15 01/13] arm64/mm: Add addr parameter to __set_{ptes_anysz,ptes,pmds,puds}() Andrew Donnellan
2025-06-25  6:37   ` Andrew Donnellan
2025-06-25  6:37 ` [PATCH v15 02/13] arm64/mm: Add addr parameter to __ptep_get_and_clear_anysz() Andrew Donnellan
2025-06-25  6:37   ` Andrew Donnellan
2025-06-25  6:37 ` [PATCH v15 03/13] mm/page_table_check: Reinstate address parameter in [__]page_table_check_pud[s]_set() Andrew Donnellan
2025-06-25  6:37   ` Andrew Donnellan
2025-06-25  6:37 ` [PATCH v15 04/13] mm/page_table_check: Reinstate address parameter in [__]page_table_check_pmd[s]_set() Andrew Donnellan
2025-06-25  6:37   ` Andrew Donnellan
2025-06-25  6:37 ` [PATCH v15 05/13] mm/page_table_check: Provide addr parameter to [__]page_table_check_ptes_set() Andrew Donnellan
2025-06-25  6:37   ` Andrew Donnellan
2025-06-25  6:37 ` [PATCH v15 06/13] mm/page_table_check: Reinstate address parameter in [__]page_table_check_pud_clear() Andrew Donnellan
2025-06-25  6:37   ` Andrew Donnellan
2025-06-25  6:37 ` [PATCH v15 07/13] mm/page_table_check: Reinstate address parameter in [__]page_table_check_pmd_clear() Andrew Donnellan
2025-06-25  6:37   ` Andrew Donnellan
2025-06-25  6:37 ` [PATCH v15 08/13] mm/page_table_check: Reinstate address parameter in [__]page_table_check_pte_clear() Andrew Donnellan
2025-06-25  6:37   ` Andrew Donnellan
2025-06-25  6:37 ` [PATCH v15 09/13] mm: Provide address parameter to p{te,md,ud}_user_accessible_page() Andrew Donnellan
2025-06-25  6:37   ` Andrew Donnellan
2025-06-25  6:37 ` Andrew Donnellan [this message]
2025-06-25  6:37   ` [PATCH v15 10/13] powerpc: mm: Add pud_pfn() stub Andrew Donnellan
2025-06-25  6:37 ` [PATCH v15 11/13] powerpc: mm: Implement *_user_accessible_page() for ptes Andrew Donnellan
2025-06-25  6:37   ` Andrew Donnellan
2025-06-25  6:37 ` [PATCH v15 12/13] powerpc: mm: Use set_pte_at_unchecked() for internal usages Andrew Donnellan
2025-06-25  6:37   ` Andrew Donnellan
2025-06-25  6:37 ` [PATCH v15 13/13] powerpc: mm: Support page table check Andrew Donnellan
2025-06-25  6:37   ` Andrew Donnellan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250625063753.77511-11-ajd@linux.ibm.com \
    --to=ajd@linux.ibm.com \
    --cc=akpm@linux-foundation.org \
    --cc=christophe.leroy@csgroup.eu \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=linux-riscv@lists.infradead.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=mingo@kernel.org \
    --cc=pasha.tatashin@soleen.com \
    --cc=sweettea-kernel@dorminy.me \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.