[chrome-os:chromeos-6.6 178/178] drivers/media/platform/mediatek/vcodec/decoder/vdec/vdec_vp9_req_lat_if.c:1151:52: warning: right shift count >= width of type

[chrome-os:chromeos-6.6 178/178] drivers/media/platform/mediatek/vcodec/decoder/vdec/vdec_vp9_req_lat_if.c:1151:52: warning: right shift count >= width of type

[kernel test robot]

tree:   https://chromium.googlesource.com/chromiumos/third_party/kernel chromeos-6.6
head:   a96f44b4c60a235515d3e5c66770402531dc3d97
commit: a96f44b4c60a235515d3e5c66770402531dc3d97 [178/178] CHROMIUM: media: mediatek: vcodec: fix vp9 p2 4096x2176 fail
config: i386-buildonly-randconfig-004-20250625 (https://download.01.org/0day-ci/archive/20250625/202506251110.HInI5dtA-lkp@intel.com/config)
compiler: gcc-12 (Debian 12.2.0-14) 12.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250625/202506251110.HInI5dtA-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202506251110.HInI5dtA-lkp@intel.com/

All warnings (new ones prefixed by >>):

   drivers/media/platform/mediatek/vcodec/decoder/vdec/vdec_vp9_req_lat_if.c: In function 'vdec_vp9_slice_setup_tile_buffer':
>> drivers/media/platform/mediatek/vcodec/decoder/vdec/vdec_vp9_req_lat_if.c:1151:52: warning: right shift count >= width of type [-Wshift-count-overflow]
    1151 |                                         *tb |= (pa >> 32) & 0xf;
         |                                                    ^~


vim +1151 drivers/media/platform/mediatek/vcodec/decoder/vdec/vdec_vp9_req_lat_if.c

  1071	
  1072	/*
  1073	 * parse tiles according to `6.4 Decode tiles syntax`
  1074	 * in "vp9-bitstream-specification"
  1075	 *
  1076	 * frame contains uncompress header, compressed header and several tiles.
  1077	 * this function parses tiles' position and size, stores them to tile buffer
  1078	 * for decoding.
  1079	 */
  1080	static int vdec_vp9_slice_setup_tile_buffer(struct vdec_vp9_slice_instance *instance,
  1081						    struct vdec_vp9_slice_vsi *vsi,
  1082						    struct mtk_vcodec_mem *bs)
  1083	{
  1084		struct vdec_vp9_slice_uncompressed_header *uh;
  1085		unsigned int rows_log2;
  1086		unsigned int cols_log2;
  1087		unsigned int rows;
  1088		unsigned int cols;
  1089		unsigned int mi_row;
  1090		unsigned int mi_col;
  1091		unsigned int offset;
  1092		dma_addr_t pa;
  1093		unsigned int size;
  1094		struct vdec_vp9_slice_tiles *tiles;
  1095		unsigned char *pos;
  1096		unsigned char *end;
  1097		unsigned char *va;
  1098		unsigned int *tb;
  1099		int i;
  1100		int j;
  1101	
  1102		uh = &vsi->frame.uh;
  1103		rows_log2 = uh->tile_rows_log2;
  1104		cols_log2 = uh->tile_cols_log2;
  1105		rows = 1 << rows_log2;
  1106		cols = 1 << cols_log2;
  1107	
  1108		if (rows > 4 || cols > 64) {
  1109			mtk_vdec_err(instance->ctx, "tile_rows %u tile_cols %u\n", rows, cols);
  1110			return -EINVAL;
  1111		}
  1112	
  1113		offset = uh->uncompressed_header_size +
  1114			uh->header_size_in_bytes;
  1115		if (bs->size <= offset) {
  1116			mtk_vdec_err(instance->ctx, "bs size %zu tile offset %u\n", bs->size, offset);
  1117			return -EINVAL;
  1118		}
  1119	
  1120		tiles = &vsi->frame.tiles;
  1121		/* setup tile buffer */
  1122	
  1123		va = (unsigned char *)bs->va;
  1124		pos = va + offset;
  1125		end = va + bs->size;
  1126		/* truncated */
  1127		pa = bs->dma_addr + offset;
  1128		tb = instance->tile.va;
  1129		for (i = 0; i < rows; i++) {
  1130			for (j = 0; j < cols; j++) {
  1131				if (i == rows - 1 &&
  1132				    j == cols - 1) {
  1133					size = (unsigned int)(end - pos);
  1134				} else {
  1135					if (end - pos < 4)
  1136						return -EINVAL;
  1137	
  1138					size = (pos[0] << 24) | (pos[1] << 16) |
  1139						(pos[2] << 8) | pos[3];
  1140					pos += 4;
  1141					pa += 4;
  1142					offset += 4;
  1143					if (end - pos < size)
  1144						return -EINVAL;
  1145				}
  1146				tiles->size[i][j] = size;
  1147				if (tiles->mi_rows[i]) {
  1148					*tb++ = (size << 3) + ((offset << 3) & 0x7f);
  1149					*tb = pa & ~0xf;
  1150					if (IS_ENABLED(CONFIG_ARCH_DMA_ADDR_T_64BIT))
> 1151						*tb |= (pa >> 32) & 0xf;
  1152					tb++;
  1153					*tb++ = (pa << 3) & 0x7f;
  1154					mi_row = (tiles->mi_rows[i] - 1) & 0x1ff;
  1155					mi_col = (tiles->mi_cols[j] - 1) & 0x3f;
  1156					*tb++ = (mi_row << 6) + mi_col;
  1157				}
  1158				pos += size;
  1159				pa += size;
  1160				offset += size;
  1161			}
  1162		}
  1163	
  1164		return 0;
  1165	}
  1166	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki