All of lore.kernel.org
 help / color / mirror / Atom feed
From: Rob Herring <robh@kernel.org>
To: Frank Li <Frank.Li@nxp.com>
Cc: Miquel Raynal <miquel.raynal@bootlin.com>,
	Richard Weinberger <richard@nod.at>,
	Vignesh Raghavendra <vigneshr@ti.com>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Vladimir Zapolskiy <vz@mleia.com>,
	Piotr Wojtaszczyk <piotr.wojtaszczyk@timesys.com>,
	"open list:MEMORY TECHNOLOGY DEVICES (MTD)"
	<linux-mtd@lists.infradead.org>,
	"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
	<devicetree@vger.kernel.org>,
	"moderated list:ARM/LPC32XX SOC SUPPORT"
	<linux-arm-kernel@lists.infradead.org>,
	open list <linux-kernel@vger.kernel.org>,
	imx@lists.linux.dev
Subject: Re: [PATCH 1/1] dt-bindings: mtd: convert lpc32xx-mlc.txt to yaml format
Date: Thu, 26 Jun 2025 21:52:56 -0500	[thread overview]
Message-ID: <20250627025256.GA1663635-robh@kernel.org> (raw)
In-Reply-To: <20250623202643.2468759-1-Frank.Li@nxp.com>

On Mon, Jun 23, 2025 at 04:26:42PM -0400, Frank Li wrote:
> Convert lpc32xx-mlc.txt to yaml format.
> 
> Additional changes:
> - add ref to nand-controller.yaml.
> - replace _ with - in property names.
> 
> Signed-off-by: Frank Li <Frank.Li@nxp.com>
> ---
>  .../devicetree/bindings/mtd/lpc32xx-mlc.txt   | 50 ------------
>  .../bindings/mtd/nxp,lpc3220-mlc.yaml         | 81 +++++++++++++++++++
>  2 files changed, 81 insertions(+), 50 deletions(-)
>  delete mode 100644 Documentation/devicetree/bindings/mtd/lpc32xx-mlc.txt
>  create mode 100644 Documentation/devicetree/bindings/mtd/nxp,lpc3220-mlc.yaml
> 
> diff --git a/Documentation/devicetree/bindings/mtd/lpc32xx-mlc.txt b/Documentation/devicetree/bindings/mtd/lpc32xx-mlc.txt
> deleted file mode 100644
> index 64c06aa05ac71..0000000000000
> --- a/Documentation/devicetree/bindings/mtd/lpc32xx-mlc.txt
> +++ /dev/null
> @@ -1,50 +0,0 @@
> -NXP LPC32xx SoC NAND MLC controller
> -
> -Required properties:
> -- compatible: "nxp,lpc3220-mlc"
> -- reg: Address and size of the controller
> -- interrupts: The NAND interrupt specification
> -- gpios: GPIO specification for NAND write protect
> -
> -The following required properties are very controller specific. See the LPC32xx
> -User Manual 7.5.14 MLC NAND Timing Register (the values here are specified in
> -Hz, to make them independent of actual clock speed and to provide for good
> -accuracy:)
> -- nxp,tcea_delay: TCEA_DELAY
> -- nxp,busy_delay: BUSY_DELAY
> -- nxp,nand_ta: NAND_TA
> -- nxp,rd_high: RD_HIGH
> -- nxp,rd_low: RD_LOW
> -- nxp,wr_high: WR_HIGH
> -- nxp,wr_low: WR_LOW
> -
> -Optional subnodes:
> -- Partitions, see Documentation/devicetree/bindings/mtd/mtd.yaml
> -
> -Example:
> -
> -	mlc: flash@200a8000 {
> -		compatible = "nxp,lpc3220-mlc";
> -		reg = <0x200A8000 0x11000>;
> -		interrupts = <11 0>;
> -		#address-cells = <1>;
> -		#size-cells = <1>;
> -
> -		nxp,tcea-delay = <333333333>;
> -		nxp,busy-delay = <10000000>;
> -		nxp,nand-ta = <18181818>;
> -		nxp,rd-high = <31250000>;
> -		nxp,rd-low = <45454545>;
> -		nxp,wr-high = <40000000>;
> -		nxp,wr-low = <83333333>;
> -		gpios = <&gpio 5 19 1>; /* GPO_P3 19, active low */
> -
> -		mtd0@00000000 {
> -			label = "boot";
> -			reg = <0x00000000 0x00064000>;
> -			read-only;
> -		};
> -
> -		...
> -
> -	};
> diff --git a/Documentation/devicetree/bindings/mtd/nxp,lpc3220-mlc.yaml b/Documentation/devicetree/bindings/mtd/nxp,lpc3220-mlc.yaml
> new file mode 100644
> index 0000000000000..acc430db5244e
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/mtd/nxp,lpc3220-mlc.yaml
> @@ -0,0 +1,81 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/mtd/nxp,lpc3220-mlc.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: NXP LPC32xx SoC NAND MLC controller
> +
> +maintainers:
> +  - Frank Li <Frank.Li@nxp.com>
> +
> +properties:
> +  compatible:
> +    const: nxp,lpc3220-mlc
> +
> +  reg:
> +    maxItems: 1
> +
> +  interrupts:
> +    maxItems: 1
> +
> +  gpios:
> +    maxItems: 1
> +    description: GPIO specification for NAND write protect
> +
> +  nxp,tcea-delay:
> +    $ref: /schemas/types.yaml#/definitions/uint32
> +    description: TCEA_DELAY in Hz
> +
> +  nxp,busy-delay:
> +    $ref: /schemas/types.yaml#/definitions/uint32
> +    description: BUSY_DELAY in Hz
> +
> +  nxp,nand-ta:
> +    $ref: /schemas/types.yaml#/definitions/uint32
> +    description: NAND_TA in Hz
> +
> +  nxp,rd-high:
> +    $ref: /schemas/types.yaml#/definitions/uint32
> +    description: RD_HIGH in Hz
> +
> +  nxp,rd-low:
> +    $ref: /schemas/types.yaml#/definitions/uint32
> +    description: RD_LOW in Hz
> +
> +  nxp,wr-high:
> +    $ref: /schemas/types.yaml#/definitions/uint32
> +    description: WR_HIGH in Hz
> +
> +  nxp,wr-low:
> +    $ref: /schemas/types.yaml#/definitions/uint32
> +    description: WR_LOW in Hz
> +
> +required:
> +  - compatible
> +  - reg
> +  - interrupts
> +  - gpios
> +
> +allOf:
> +  - $ref: nand-controller.yaml

Do either of these use this? They don't define 'nand' chip nodes, do 
they?

No partitions on this one?

Rob


WARNING: multiple messages have this Message-ID (diff)
From: Rob Herring <robh@kernel.org>
To: Frank Li <Frank.Li@nxp.com>
Cc: Miquel Raynal <miquel.raynal@bootlin.com>,
	Richard Weinberger <richard@nod.at>,
	Vignesh Raghavendra <vigneshr@ti.com>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Vladimir Zapolskiy <vz@mleia.com>,
	Piotr Wojtaszczyk <piotr.wojtaszczyk@timesys.com>,
	"open list:MEMORY TECHNOLOGY DEVICES (MTD)"
	<linux-mtd@lists.infradead.org>,
	"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
	<devicetree@vger.kernel.org>,
	"moderated list:ARM/LPC32XX SOC SUPPORT"
	<linux-arm-kernel@lists.infradead.org>,
	open list <linux-kernel@vger.kernel.org>,
	imx@lists.linux.dev
Subject: Re: [PATCH 1/1] dt-bindings: mtd: convert lpc32xx-mlc.txt to yaml format
Date: Thu, 26 Jun 2025 21:52:56 -0500	[thread overview]
Message-ID: <20250627025256.GA1663635-robh@kernel.org> (raw)
In-Reply-To: <20250623202643.2468759-1-Frank.Li@nxp.com>

On Mon, Jun 23, 2025 at 04:26:42PM -0400, Frank Li wrote:
> Convert lpc32xx-mlc.txt to yaml format.
> 
> Additional changes:
> - add ref to nand-controller.yaml.
> - replace _ with - in property names.
> 
> Signed-off-by: Frank Li <Frank.Li@nxp.com>
> ---
>  .../devicetree/bindings/mtd/lpc32xx-mlc.txt   | 50 ------------
>  .../bindings/mtd/nxp,lpc3220-mlc.yaml         | 81 +++++++++++++++++++
>  2 files changed, 81 insertions(+), 50 deletions(-)
>  delete mode 100644 Documentation/devicetree/bindings/mtd/lpc32xx-mlc.txt
>  create mode 100644 Documentation/devicetree/bindings/mtd/nxp,lpc3220-mlc.yaml
> 
> diff --git a/Documentation/devicetree/bindings/mtd/lpc32xx-mlc.txt b/Documentation/devicetree/bindings/mtd/lpc32xx-mlc.txt
> deleted file mode 100644
> index 64c06aa05ac71..0000000000000
> --- a/Documentation/devicetree/bindings/mtd/lpc32xx-mlc.txt
> +++ /dev/null
> @@ -1,50 +0,0 @@
> -NXP LPC32xx SoC NAND MLC controller
> -
> -Required properties:
> -- compatible: "nxp,lpc3220-mlc"
> -- reg: Address and size of the controller
> -- interrupts: The NAND interrupt specification
> -- gpios: GPIO specification for NAND write protect
> -
> -The following required properties are very controller specific. See the LPC32xx
> -User Manual 7.5.14 MLC NAND Timing Register (the values here are specified in
> -Hz, to make them independent of actual clock speed and to provide for good
> -accuracy:)
> -- nxp,tcea_delay: TCEA_DELAY
> -- nxp,busy_delay: BUSY_DELAY
> -- nxp,nand_ta: NAND_TA
> -- nxp,rd_high: RD_HIGH
> -- nxp,rd_low: RD_LOW
> -- nxp,wr_high: WR_HIGH
> -- nxp,wr_low: WR_LOW
> -
> -Optional subnodes:
> -- Partitions, see Documentation/devicetree/bindings/mtd/mtd.yaml
> -
> -Example:
> -
> -	mlc: flash@200a8000 {
> -		compatible = "nxp,lpc3220-mlc";
> -		reg = <0x200A8000 0x11000>;
> -		interrupts = <11 0>;
> -		#address-cells = <1>;
> -		#size-cells = <1>;
> -
> -		nxp,tcea-delay = <333333333>;
> -		nxp,busy-delay = <10000000>;
> -		nxp,nand-ta = <18181818>;
> -		nxp,rd-high = <31250000>;
> -		nxp,rd-low = <45454545>;
> -		nxp,wr-high = <40000000>;
> -		nxp,wr-low = <83333333>;
> -		gpios = <&gpio 5 19 1>; /* GPO_P3 19, active low */
> -
> -		mtd0@00000000 {
> -			label = "boot";
> -			reg = <0x00000000 0x00064000>;
> -			read-only;
> -		};
> -
> -		...
> -
> -	};
> diff --git a/Documentation/devicetree/bindings/mtd/nxp,lpc3220-mlc.yaml b/Documentation/devicetree/bindings/mtd/nxp,lpc3220-mlc.yaml
> new file mode 100644
> index 0000000000000..acc430db5244e
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/mtd/nxp,lpc3220-mlc.yaml
> @@ -0,0 +1,81 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/mtd/nxp,lpc3220-mlc.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: NXP LPC32xx SoC NAND MLC controller
> +
> +maintainers:
> +  - Frank Li <Frank.Li@nxp.com>
> +
> +properties:
> +  compatible:
> +    const: nxp,lpc3220-mlc
> +
> +  reg:
> +    maxItems: 1
> +
> +  interrupts:
> +    maxItems: 1
> +
> +  gpios:
> +    maxItems: 1
> +    description: GPIO specification for NAND write protect
> +
> +  nxp,tcea-delay:
> +    $ref: /schemas/types.yaml#/definitions/uint32
> +    description: TCEA_DELAY in Hz
> +
> +  nxp,busy-delay:
> +    $ref: /schemas/types.yaml#/definitions/uint32
> +    description: BUSY_DELAY in Hz
> +
> +  nxp,nand-ta:
> +    $ref: /schemas/types.yaml#/definitions/uint32
> +    description: NAND_TA in Hz
> +
> +  nxp,rd-high:
> +    $ref: /schemas/types.yaml#/definitions/uint32
> +    description: RD_HIGH in Hz
> +
> +  nxp,rd-low:
> +    $ref: /schemas/types.yaml#/definitions/uint32
> +    description: RD_LOW in Hz
> +
> +  nxp,wr-high:
> +    $ref: /schemas/types.yaml#/definitions/uint32
> +    description: WR_HIGH in Hz
> +
> +  nxp,wr-low:
> +    $ref: /schemas/types.yaml#/definitions/uint32
> +    description: WR_LOW in Hz
> +
> +required:
> +  - compatible
> +  - reg
> +  - interrupts
> +  - gpios
> +
> +allOf:
> +  - $ref: nand-controller.yaml

Do either of these use this? They don't define 'nand' chip nodes, do 
they?

No partitions on this one?

Rob


______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/

  reply	other threads:[~2025-06-27  2:52 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-06-23 20:26 [PATCH 1/1] dt-bindings: mtd: convert lpc32xx-mlc.txt to yaml format Frank Li
2025-06-23 20:26 ` Frank Li
2025-06-27  2:52 ` Rob Herring [this message]
2025-06-27  2:52   ` Rob Herring

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250627025256.GA1663635-robh@kernel.org \
    --to=robh@kernel.org \
    --cc=Frank.Li@nxp.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=imx@lists.linux.dev \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=miquel.raynal@bootlin.com \
    --cc=piotr.wojtaszczyk@timesys.com \
    --cc=richard@nod.at \
    --cc=vigneshr@ti.com \
    --cc=vz@mleia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.