* [PATCH] xfs: add FALLOC_FL_ALLOCATE_RANGE to supported flags mask @ 2025-06-27 5:33 ` Youling Tang 2025-06-27 7:08 ` Carlos Maiolino 0 siblings, 1 reply; 2+ messages in thread From: Youling Tang @ 2025-06-27 5:33 UTC (permalink / raw) To: Carlos Maiolino; +Cc: linux-xfs, linux-kernel, youling.tang, Youling Tang From: Youling Tang <tangyouling@kylinos.cn> Add FALLOC_FL_ALLOCATE_RANGE to the set of supported fallocate flags in XFS_FALLOC_FL_SUPPORTED. This change improves code clarity and maintains by explicitly showing this flag in the supported flags mask. Note that since FALLOC_FL_ALLOCATE_RANGE is defined as 0x00, this addition has no functional modifications. Signed-off-by: Youling Tang <tangyouling@kylinos.cn> --- fs/xfs/xfs_file.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/fs/xfs/xfs_file.c b/fs/xfs/xfs_file.c index 48254a72071b..d7f6b078d413 100644 --- a/fs/xfs/xfs_file.c +++ b/fs/xfs/xfs_file.c @@ -1335,7 +1335,8 @@ xfs_falloc_allocate_range( } #define XFS_FALLOC_FL_SUPPORTED \ - (FALLOC_FL_KEEP_SIZE | FALLOC_FL_PUNCH_HOLE | \ + (FALLOC_FL_KEEP_SIZE | \ + FALLOC_FL_ALLOCATE_RANGE | FALLOC_FL_PUNCH_HOLE | \ FALLOC_FL_COLLAPSE_RANGE | FALLOC_FL_ZERO_RANGE | \ FALLOC_FL_INSERT_RANGE | FALLOC_FL_UNSHARE_RANGE) -- 2.34.1 ^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] xfs: add FALLOC_FL_ALLOCATE_RANGE to supported flags mask 2025-06-27 5:33 ` [PATCH] xfs: add FALLOC_FL_ALLOCATE_RANGE to supported flags mask Youling Tang @ 2025-06-27 7:08 ` Carlos Maiolino 0 siblings, 0 replies; 2+ messages in thread From: Carlos Maiolino @ 2025-06-27 7:08 UTC (permalink / raw) To: Youling Tang; +Cc: linux-xfs, linux-kernel, Youling Tang On Fri, Jun 27, 2025 at 01:33:44PM +0800, Youling Tang wrote: > From: Youling Tang <tangyouling@kylinos.cn> > > Add FALLOC_FL_ALLOCATE_RANGE to the set of supported fallocate flags in > XFS_FALLOC_FL_SUPPORTED. This change improves code clarity and maintains > by explicitly showing this flag in the supported flags mask. > > Note that since FALLOC_FL_ALLOCATE_RANGE is defined as 0x00, this addition > has no functional modifications. > > Signed-off-by: Youling Tang <tangyouling@kylinos.cn> > --- > fs/xfs/xfs_file.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/fs/xfs/xfs_file.c b/fs/xfs/xfs_file.c > index 48254a72071b..d7f6b078d413 100644 > --- a/fs/xfs/xfs_file.c > +++ b/fs/xfs/xfs_file.c > @@ -1335,7 +1335,8 @@ xfs_falloc_allocate_range( > } > > #define XFS_FALLOC_FL_SUPPORTED \ > - (FALLOC_FL_KEEP_SIZE | FALLOC_FL_PUNCH_HOLE | \ > + (FALLOC_FL_KEEP_SIZE | \ > + FALLOC_FL_ALLOCATE_RANGE | FALLOC_FL_PUNCH_HOLE | \ > FALLOC_FL_COLLAPSE_RANGE | FALLOC_FL_ZERO_RANGE | \ > FALLOC_FL_INSERT_RANGE | FALLOC_FL_UNSHARE_RANGE) This sounds reasonable. Could you please add it as the first flag to keep "the right order"? Other than this nitpick, you can add: Reviewed-by: Carlos Maiolino <cmaiolino@redhat.com> > > -- > 2.34.1 > > ^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2025-06-27 7:08 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <RRIn7phtOPENw-VOR38lq9hw0cyJbioBOq7lxVO-pHAFmZ2BzH88tnc7V3pUxiT0xvHGo7SY4IJSk7FC31MNbw==@protonmail.internalid>
2025-06-27 5:33 ` [PATCH] xfs: add FALLOC_FL_ALLOCATE_RANGE to supported flags mask Youling Tang
2025-06-27 7:08 ` Carlos Maiolino
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.