Re: [meta-rockchip][PATCH v4] fitimage rework

[Trevor Woerner <twoerner@gmail.com>]

On Wed 2025-06-25 @ 11:18:10 PM, Trevor Woerner wrote:
> oe-core has completely re-written the fitImage support starting roughly at
> commit [1], update meta-rockchip to match.
> 
> Most of the MACHINEs in meta-rockchip use a fitImage for the kernel, but
> some don't. Create a boolean variable (RK_KERNEL_FITIMAGE), enabled by
> default, to keep track of which ones do and which ones don't. Use this
> variable to decide how to configure various image-related fields.
> 
> Build tested with all meta-rockchip MACHINEs both with and without RAUC.
> 
> Run tested on the following with RAUC configured:
> 	- nanopi-m4b
> 	- nanopi-r2s
> 	- radxa-zero-3e
> 	- rock-pi-4b
> 	- rock-pi-e
> 	- rock-pi-s
> 
> Run tested on the following without RAUC:
> 	- radxa-zero-3e
> 	- rock-pi-e
> 	- rock-pi-s
> 
> [1] oe-core: 3442d9297dca ("oe-selftest: fitimage: test external dtb")
> Signed-off-by: Trevor Woerner <twoerner@gmail.com>
> ---
> changes in v4:
> - rename the variable to RK_KERNEL_FITIMAGE
> - update the README, variable name, and comments to emphasize the fitImage
>   is kernel-related (and does not pertain to other fit-able components)
> - use ?= so the RK_KERNEL_FITIMAGE value can be changed by the user
> - the location of the RK_KERNEL_FITIMAGE variable is not arbitrary (as
>   it may be for other variables) add a comment to this effect
> - re-organize the fit and non-fit values to do away with adding two new
>   files (rockchip-fitimage.inc and rockchip-unfitimage.inc) so as to add
>   only one (rockchip-fitimage.inc); set all non-fit values as defaults
>   to be over-ridden in the rockchip-fitimage.inc file as required
> 
> changes in v3:
> - remove the 2nd MACHINE_ESSENTIAL_EXTRA_RDEPENDS from the
>   rockchip-extlinux.inc file and place the relevant portions into either
>   the rockchip-fitimage.inc or rockchip-unfitimage.inc files as
>   appropriate
> 
> changes in v2:
> - remove the ",False" from the bb.utils.to_boolean() calls
> - add information on new param (RK_FITIMAGE) to README
> - re-structure the fitimage require so it is less invasive in
>   MACHINE.conf files
> ---
>  README                                     | 10 ++++++++++
>  conf/machine/include/px30.inc              |  2 --
>  conf/machine/include/rk3066.inc            |  2 +-
>  conf/machine/include/rk3188.inc            |  2 +-
>  conf/machine/include/rk3288.inc            |  2 +-
>  conf/machine/include/rk3308.inc            |  2 --
>  conf/machine/include/rk3328.inc            |  2 --
>  conf/machine/include/rk3399.inc            |  2 --
>  conf/machine/include/rk3566.inc            |  2 --
>  conf/machine/include/rk3568.inc            |  2 --
>  conf/machine/include/rk3588s.inc           |  2 --
>  conf/machine/include/rockchip-defaults.inc |  7 +++++++
>  conf/machine/include/rockchip-extlinux.inc |  7 +++----
>  conf/machine/include/rockchip-fitimage.inc |  5 +++++
>  14 files changed, 28 insertions(+), 21 deletions(-)
>  create mode 100644 conf/machine/include/rockchip-fitimage.inc

Applied (with some tweaks discussed on IRC) to meta-rockchip, master branch.
Thanks for the review!