Re: [yocto-patches] [meta-rockchip][PATCH v4] fitimage rework

[Quentin Schulz <quentin.schulz@cherry.de>]

Hi Trevor,

On 6/26/25 5:18 AM, Trevor Woerner via lists.yoctoproject.org wrote:

[...]

> diff --git a/conf/machine/include/rockchip-defaults.inc b/conf/machine/include/rockchip-defaults.inc
> index 85ec7b944d1d..fc8930635fbe 100644
> --- a/conf/machine/include/rockchip-defaults.inc
> +++ b/conf/machine/include/rockchip-defaults.inc
> @@ -1,9 +1,16 @@
>   # meta-rockchip default settings
>   MACHINEOVERRIDES =. "${@bb.utils.contains('ROCKCHIP_CLOSED_TPL', '1', 'closed-tpl:', '', d)}"
>   MACHINEOVERRIDES =. "rockchip:"
> +
>   # kernel
> +# RK_KERNEL_FITIMAGE needs to be set before the next "require ..."
> +RK_KERNEL_FITIMAGE ?= "True"
>   PREFERRED_PROVIDER_virtual/kernel ?= "linux-yocto"
>   KCONFIG_MODE ?= "alldefconfig"
> +KERNEL_IMAGETYPE ??= "zImage"

Any reason for having ??= instead of ?= here? I would assume that ?= 
would be enough? Can leave as is though.

> +MACHINE_ESSENTIAL_EXTRA_RDEPENDS_KERNEL += "kernel-devicetree"

Any reason for the += here? I believe = should be fine? Can leave as is 
though.

Looks ok to me otherwise!

FYI, I'm on PTO for the next two weeks and won't have the time to test 
this today, do what you will with this info :)

Cheers,
Quentin