* [PATCH v1 1/1] mfd: syscon: atmel-smc: Don't use "proxy" headers
@ 2025-06-26 15:54 Andy Shevchenko
2025-06-26 20:56 ` kernel test robot
2025-06-27 11:30 ` kernel test robot
0 siblings, 2 replies; 3+ messages in thread
From: Andy Shevchenko @ 2025-06-26 15:54 UTC (permalink / raw)
To: Andy Shevchenko, linux-arm-kernel, linux-kernel
Cc: Lee Jones, Nicolas Ferre, Alexandre Belloni, Claudiu Beznea
Update header inclusions to follow IWYU (Include What You Use)
principle.
Note that kernel.h is discouraged to be included as it's written
at the top of that file.
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
include/linux/mfd/syscon/atmel-smc.h | 8 +++++---
1 file changed, 5 insertions(+), 3 deletions(-)
diff --git a/include/linux/mfd/syscon/atmel-smc.h b/include/linux/mfd/syscon/atmel-smc.h
index e9e24f4c4578..9b9119c742a2 100644
--- a/include/linux/mfd/syscon/atmel-smc.h
+++ b/include/linux/mfd/syscon/atmel-smc.h
@@ -11,9 +11,11 @@
#ifndef _LINUX_MFD_SYSCON_ATMEL_SMC_H_
#define _LINUX_MFD_SYSCON_ATMEL_SMC_H_
-#include <linux/kernel.h>
-#include <linux/of.h>
-#include <linux/regmap.h>
+#include <linux/bits.h>
+#include <linux/types.h>
+
+struct device_node;
+struct regmap;
#define ATMEL_SMC_SETUP(cs) (((cs) * 0x10))
#define ATMEL_HSMC_SETUP(layout, cs) \
--
2.47.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v1 1/1] mfd: syscon: atmel-smc: Don't use "proxy" headers
2025-06-26 15:54 [PATCH v1 1/1] mfd: syscon: atmel-smc: Don't use "proxy" headers Andy Shevchenko
@ 2025-06-26 20:56 ` kernel test robot
2025-06-27 11:30 ` kernel test robot
1 sibling, 0 replies; 3+ messages in thread
From: kernel test robot @ 2025-06-26 20:56 UTC (permalink / raw)
To: Andy Shevchenko, linux-arm-kernel, linux-kernel
Cc: oe-kbuild-all, Lee Jones, Nicolas Ferre, Alexandre Belloni,
Claudiu Beznea
Hi Andy,
kernel test robot noticed the following build errors:
[auto build test ERROR on lee-mfd/for-mfd-next]
[also build test ERROR on lee-mfd/for-mfd-fixes soc/for-next lee-leds/for-leds-next linus/master v6.16-rc3 next-20250626]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Andy-Shevchenko/mfd-syscon-atmel-smc-Don-t-use-proxy-headers/20250626-235519
base: https://git.kernel.org/pub/scm/linux/kernel/git/lee/mfd.git for-mfd-next
patch link: https://lore.kernel.org/r/20250626155435.325336-1-andriy.shevchenko%40linux.intel.com
patch subject: [PATCH v1 1/1] mfd: syscon: atmel-smc: Don't use "proxy" headers
config: i386-buildonly-randconfig-001-20250627 (https://download.01.org/0day-ci/archive/20250627/202506270640.lghOwS7H-lkp@intel.com/config)
compiler: gcc-12 (Debian 12.2.0-14) 12.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250627/202506270640.lghOwS7H-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202506270640.lghOwS7H-lkp@intel.com/
All error/warnings (new ones prefixed by >>):
drivers/mfd/atmel-smc.c: In function 'atmel_smc_cs_conf_apply':
>> drivers/mfd/atmel-smc.c:248:9: error: implicit declaration of function 'regmap_write' [-Werror=implicit-function-declaration]
248 | regmap_write(regmap, ATMEL_SMC_SETUP(cs), conf->setup);
| ^~~~~~~~~~~~
drivers/mfd/atmel-smc.c: In function 'atmel_smc_cs_conf_get':
>> drivers/mfd/atmel-smc.c:289:9: error: implicit declaration of function 'regmap_read' [-Werror=implicit-function-declaration]
289 | regmap_read(regmap, ATMEL_SMC_SETUP(cs), &conf->setup);
| ^~~~~~~~~~~
drivers/mfd/atmel-smc.c: At top level:
>> drivers/mfd/atmel-smc.c:326:34: error: array type has incomplete element type 'struct of_device_id'
326 | static const struct of_device_id atmel_smc_ids[] __maybe_unused = {
| ^~~~~~~~~~~~~
drivers/mfd/atmel-smc.c: In function 'atmel_hsmc_get_reg_layout':
>> drivers/mfd/atmel-smc.c:347:17: error: implicit declaration of function 'of_match_node' [-Werror=implicit-function-declaration]
347 | match = of_match_node(atmel_smc_ids, np);
| ^~~~~~~~~~~~~
>> drivers/mfd/atmel-smc.c:349:29: error: invalid use of undefined type 'const struct of_device_id'
349 | return match ? match->data : ERR_PTR(-EINVAL);
| ^~
>> drivers/mfd/atmel-smc.c:350:1: warning: control reaches end of non-void function [-Wreturn-type]
350 | }
| ^
drivers/mfd/atmel-smc.c: At top level:
drivers/mfd/atmel-smc.c:326:34: warning: 'atmel_smc_ids' defined but not used [-Wunused-variable]
326 | static const struct of_device_id atmel_smc_ids[] __maybe_unused = {
| ^~~~~~~~~~~~~
cc1: some warnings being treated as errors
vim +/regmap_write +248 drivers/mfd/atmel-smc.c
fe9d7cb22ef3a26 Boris Brezillon 2017-03-16 235
fe9d7cb22ef3a26 Boris Brezillon 2017-03-16 236 /**
fe9d7cb22ef3a26 Boris Brezillon 2017-03-16 237 * atmel_smc_cs_conf_apply - apply an SMC CS conf
fe9d7cb22ef3a26 Boris Brezillon 2017-03-16 238 * @regmap: the SMC regmap
fe9d7cb22ef3a26 Boris Brezillon 2017-03-16 239 * @cs: the CS id
1574360a98cef98 Lee Jones 2020-06-24 240 * @conf: the SMC CS conf to apply
fe9d7cb22ef3a26 Boris Brezillon 2017-03-16 241 *
fe9d7cb22ef3a26 Boris Brezillon 2017-03-16 242 * Applies an SMC CS configuration.
53291cb23c919c5 Hans-Christian Noren Egtvedt 2018-10-20 243 * Only valid on at91sam9 SoCs.
fe9d7cb22ef3a26 Boris Brezillon 2017-03-16 244 */
fe9d7cb22ef3a26 Boris Brezillon 2017-03-16 245 void atmel_smc_cs_conf_apply(struct regmap *regmap, int cs,
fe9d7cb22ef3a26 Boris Brezillon 2017-03-16 246 const struct atmel_smc_cs_conf *conf)
fe9d7cb22ef3a26 Boris Brezillon 2017-03-16 247 {
fe9d7cb22ef3a26 Boris Brezillon 2017-03-16 @248 regmap_write(regmap, ATMEL_SMC_SETUP(cs), conf->setup);
fe9d7cb22ef3a26 Boris Brezillon 2017-03-16 249 regmap_write(regmap, ATMEL_SMC_PULSE(cs), conf->pulse);
fe9d7cb22ef3a26 Boris Brezillon 2017-03-16 250 regmap_write(regmap, ATMEL_SMC_CYCLE(cs), conf->cycle);
fe9d7cb22ef3a26 Boris Brezillon 2017-03-16 251 regmap_write(regmap, ATMEL_SMC_MODE(cs), conf->mode);
fe9d7cb22ef3a26 Boris Brezillon 2017-03-16 252 }
fe9d7cb22ef3a26 Boris Brezillon 2017-03-16 253 EXPORT_SYMBOL_GPL(atmel_smc_cs_conf_apply);
fe9d7cb22ef3a26 Boris Brezillon 2017-03-16 254
fe9d7cb22ef3a26 Boris Brezillon 2017-03-16 255 /**
fe9d7cb22ef3a26 Boris Brezillon 2017-03-16 256 * atmel_hsmc_cs_conf_apply - apply an SMC CS conf
fe9d7cb22ef3a26 Boris Brezillon 2017-03-16 257 * @regmap: the HSMC regmap
b0f3ab20e76499d Ludovic Desroches 2017-07-18 258 * @layout: the layout of registers
6af8d30527e6abb Julia Lawall 2024-09-30 259 * @cs: the CS id
1574360a98cef98 Lee Jones 2020-06-24 260 * @conf: the SMC CS conf to apply
fe9d7cb22ef3a26 Boris Brezillon 2017-03-16 261 *
fe9d7cb22ef3a26 Boris Brezillon 2017-03-16 262 * Applies an SMC CS configuration.
fe9d7cb22ef3a26 Boris Brezillon 2017-03-16 263 * Only valid on post-sama5 SoCs.
fe9d7cb22ef3a26 Boris Brezillon 2017-03-16 264 */
b0f3ab20e76499d Ludovic Desroches 2017-07-18 265 void atmel_hsmc_cs_conf_apply(struct regmap *regmap,
b0f3ab20e76499d Ludovic Desroches 2017-07-18 266 const struct atmel_hsmc_reg_layout *layout,
b0f3ab20e76499d Ludovic Desroches 2017-07-18 267 int cs, const struct atmel_smc_cs_conf *conf)
fe9d7cb22ef3a26 Boris Brezillon 2017-03-16 268 {
b0f3ab20e76499d Ludovic Desroches 2017-07-18 269 regmap_write(regmap, ATMEL_HSMC_SETUP(layout, cs), conf->setup);
b0f3ab20e76499d Ludovic Desroches 2017-07-18 270 regmap_write(regmap, ATMEL_HSMC_PULSE(layout, cs), conf->pulse);
b0f3ab20e76499d Ludovic Desroches 2017-07-18 271 regmap_write(regmap, ATMEL_HSMC_CYCLE(layout, cs), conf->cycle);
b0f3ab20e76499d Ludovic Desroches 2017-07-18 272 regmap_write(regmap, ATMEL_HSMC_TIMINGS(layout, cs), conf->timings);
b0f3ab20e76499d Ludovic Desroches 2017-07-18 273 regmap_write(regmap, ATMEL_HSMC_MODE(layout, cs), conf->mode);
fe9d7cb22ef3a26 Boris Brezillon 2017-03-16 274 }
fe9d7cb22ef3a26 Boris Brezillon 2017-03-16 275 EXPORT_SYMBOL_GPL(atmel_hsmc_cs_conf_apply);
fe9d7cb22ef3a26 Boris Brezillon 2017-03-16 276
fe9d7cb22ef3a26 Boris Brezillon 2017-03-16 277 /**
fe9d7cb22ef3a26 Boris Brezillon 2017-03-16 278 * atmel_smc_cs_conf_get - retrieve the current SMC CS conf
fe9d7cb22ef3a26 Boris Brezillon 2017-03-16 279 * @regmap: the SMC regmap
fe9d7cb22ef3a26 Boris Brezillon 2017-03-16 280 * @cs: the CS id
fe9d7cb22ef3a26 Boris Brezillon 2017-03-16 281 * @conf: the SMC CS conf object to store the current conf
fe9d7cb22ef3a26 Boris Brezillon 2017-03-16 282 *
fe9d7cb22ef3a26 Boris Brezillon 2017-03-16 283 * Retrieve the SMC CS configuration.
53291cb23c919c5 Hans-Christian Noren Egtvedt 2018-10-20 284 * Only valid on at91sam9 SoCs.
fe9d7cb22ef3a26 Boris Brezillon 2017-03-16 285 */
fe9d7cb22ef3a26 Boris Brezillon 2017-03-16 286 void atmel_smc_cs_conf_get(struct regmap *regmap, int cs,
fe9d7cb22ef3a26 Boris Brezillon 2017-03-16 287 struct atmel_smc_cs_conf *conf)
fe9d7cb22ef3a26 Boris Brezillon 2017-03-16 288 {
fe9d7cb22ef3a26 Boris Brezillon 2017-03-16 @289 regmap_read(regmap, ATMEL_SMC_SETUP(cs), &conf->setup);
fe9d7cb22ef3a26 Boris Brezillon 2017-03-16 290 regmap_read(regmap, ATMEL_SMC_PULSE(cs), &conf->pulse);
fe9d7cb22ef3a26 Boris Brezillon 2017-03-16 291 regmap_read(regmap, ATMEL_SMC_CYCLE(cs), &conf->cycle);
fe9d7cb22ef3a26 Boris Brezillon 2017-03-16 292 regmap_read(regmap, ATMEL_SMC_MODE(cs), &conf->mode);
fe9d7cb22ef3a26 Boris Brezillon 2017-03-16 293 }
fe9d7cb22ef3a26 Boris Brezillon 2017-03-16 294 EXPORT_SYMBOL_GPL(atmel_smc_cs_conf_get);
fe9d7cb22ef3a26 Boris Brezillon 2017-03-16 295
fe9d7cb22ef3a26 Boris Brezillon 2017-03-16 296 /**
fe9d7cb22ef3a26 Boris Brezillon 2017-03-16 297 * atmel_hsmc_cs_conf_get - retrieve the current SMC CS conf
fe9d7cb22ef3a26 Boris Brezillon 2017-03-16 298 * @regmap: the HSMC regmap
b0f3ab20e76499d Ludovic Desroches 2017-07-18 299 * @layout: the layout of registers
6af8d30527e6abb Julia Lawall 2024-09-30 300 * @cs: the CS id
fe9d7cb22ef3a26 Boris Brezillon 2017-03-16 301 * @conf: the SMC CS conf object to store the current conf
fe9d7cb22ef3a26 Boris Brezillon 2017-03-16 302 *
fe9d7cb22ef3a26 Boris Brezillon 2017-03-16 303 * Retrieve the SMC CS configuration.
fe9d7cb22ef3a26 Boris Brezillon 2017-03-16 304 * Only valid on post-sama5 SoCs.
fe9d7cb22ef3a26 Boris Brezillon 2017-03-16 305 */
b0f3ab20e76499d Ludovic Desroches 2017-07-18 306 void atmel_hsmc_cs_conf_get(struct regmap *regmap,
b0f3ab20e76499d Ludovic Desroches 2017-07-18 307 const struct atmel_hsmc_reg_layout *layout,
b0f3ab20e76499d Ludovic Desroches 2017-07-18 308 int cs, struct atmel_smc_cs_conf *conf)
fe9d7cb22ef3a26 Boris Brezillon 2017-03-16 309 {
b0f3ab20e76499d Ludovic Desroches 2017-07-18 310 regmap_read(regmap, ATMEL_HSMC_SETUP(layout, cs), &conf->setup);
b0f3ab20e76499d Ludovic Desroches 2017-07-18 311 regmap_read(regmap, ATMEL_HSMC_PULSE(layout, cs), &conf->pulse);
b0f3ab20e76499d Ludovic Desroches 2017-07-18 312 regmap_read(regmap, ATMEL_HSMC_CYCLE(layout, cs), &conf->cycle);
b0f3ab20e76499d Ludovic Desroches 2017-07-18 313 regmap_read(regmap, ATMEL_HSMC_TIMINGS(layout, cs), &conf->timings);
b0f3ab20e76499d Ludovic Desroches 2017-07-18 314 regmap_read(regmap, ATMEL_HSMC_MODE(layout, cs), &conf->mode);
fe9d7cb22ef3a26 Boris Brezillon 2017-03-16 315 }
fe9d7cb22ef3a26 Boris Brezillon 2017-03-16 316 EXPORT_SYMBOL_GPL(atmel_hsmc_cs_conf_get);
b0f3ab20e76499d Ludovic Desroches 2017-07-18 317
b0f3ab20e76499d Ludovic Desroches 2017-07-18 318 static const struct atmel_hsmc_reg_layout sama5d3_reg_layout = {
b0f3ab20e76499d Ludovic Desroches 2017-07-18 319 .timing_regs_offset = 0x600,
b0f3ab20e76499d Ludovic Desroches 2017-07-18 320 };
b0f3ab20e76499d Ludovic Desroches 2017-07-18 321
b0f3ab20e76499d Ludovic Desroches 2017-07-18 322 static const struct atmel_hsmc_reg_layout sama5d2_reg_layout = {
b0f3ab20e76499d Ludovic Desroches 2017-07-18 323 .timing_regs_offset = 0x700,
b0f3ab20e76499d Ludovic Desroches 2017-07-18 324 };
b0f3ab20e76499d Ludovic Desroches 2017-07-18 325
f130faebcdb6c7f Krzysztof Kozlowski 2023-03-11 @326 static const struct of_device_id atmel_smc_ids[] __maybe_unused = {
b0f3ab20e76499d Ludovic Desroches 2017-07-18 327 { .compatible = "atmel,at91sam9260-smc", .data = NULL },
b0f3ab20e76499d Ludovic Desroches 2017-07-18 328 { .compatible = "atmel,sama5d3-smc", .data = &sama5d3_reg_layout },
b0f3ab20e76499d Ludovic Desroches 2017-07-18 329 { .compatible = "atmel,sama5d2-smc", .data = &sama5d2_reg_layout },
b0f3ab20e76499d Ludovic Desroches 2017-07-18 330 { /* sentinel */ },
b0f3ab20e76499d Ludovic Desroches 2017-07-18 331 };
b0f3ab20e76499d Ludovic Desroches 2017-07-18 332
b0f3ab20e76499d Ludovic Desroches 2017-07-18 333 /**
b0f3ab20e76499d Ludovic Desroches 2017-07-18 334 * atmel_hsmc_get_reg_layout - retrieve the layout of HSMC registers
b0f3ab20e76499d Ludovic Desroches 2017-07-18 335 * @np: the HSMC regmap
b0f3ab20e76499d Ludovic Desroches 2017-07-18 336 *
b0f3ab20e76499d Ludovic Desroches 2017-07-18 337 * Retrieve the layout of HSMC registers.
b0f3ab20e76499d Ludovic Desroches 2017-07-18 338 *
b0f3ab20e76499d Ludovic Desroches 2017-07-18 339 * Returns NULL in case of SMC, a struct atmel_hsmc_reg_layout pointer
b0f3ab20e76499d Ludovic Desroches 2017-07-18 340 * in HSMC case, otherwise ERR_PTR(-EINVAL).
b0f3ab20e76499d Ludovic Desroches 2017-07-18 341 */
b0f3ab20e76499d Ludovic Desroches 2017-07-18 342 const struct atmel_hsmc_reg_layout *
b0f3ab20e76499d Ludovic Desroches 2017-07-18 343 atmel_hsmc_get_reg_layout(struct device_node *np)
b0f3ab20e76499d Ludovic Desroches 2017-07-18 344 {
b0f3ab20e76499d Ludovic Desroches 2017-07-18 345 const struct of_device_id *match;
b0f3ab20e76499d Ludovic Desroches 2017-07-18 346
b0f3ab20e76499d Ludovic Desroches 2017-07-18 @347 match = of_match_node(atmel_smc_ids, np);
b0f3ab20e76499d Ludovic Desroches 2017-07-18 348
b0f3ab20e76499d Ludovic Desroches 2017-07-18 @349 return match ? match->data : ERR_PTR(-EINVAL);
b0f3ab20e76499d Ludovic Desroches 2017-07-18 @350 }
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v1 1/1] mfd: syscon: atmel-smc: Don't use "proxy" headers
2025-06-26 15:54 [PATCH v1 1/1] mfd: syscon: atmel-smc: Don't use "proxy" headers Andy Shevchenko
2025-06-26 20:56 ` kernel test robot
@ 2025-06-27 11:30 ` kernel test robot
1 sibling, 0 replies; 3+ messages in thread
From: kernel test robot @ 2025-06-27 11:30 UTC (permalink / raw)
To: Andy Shevchenko, linux-arm-kernel, linux-kernel
Cc: oe-kbuild-all, Lee Jones, Nicolas Ferre, Alexandre Belloni,
Claudiu Beznea
Hi Andy,
kernel test robot noticed the following build warnings:
[auto build test WARNING on lee-mfd/for-mfd-next]
[also build test WARNING on lee-mfd/for-mfd-fixes soc/for-next lee-leds/for-leds-next linus/master v6.16-rc3 next-20250626]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Andy-Shevchenko/mfd-syscon-atmel-smc-Don-t-use-proxy-headers/20250626-235519
base: https://git.kernel.org/pub/scm/linux/kernel/git/lee/mfd.git for-mfd-next
patch link: https://lore.kernel.org/r/20250626155435.325336-1-andriy.shevchenko%40linux.intel.com
patch subject: [PATCH v1 1/1] mfd: syscon: atmel-smc: Don't use "proxy" headers
config: alpha-allyesconfig (https://download.01.org/0day-ci/archive/20250627/202506271909.O9FuRVos-lkp@intel.com/config)
compiler: alpha-linux-gcc (GCC) 15.1.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250627/202506271909.O9FuRVos-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202506271909.O9FuRVos-lkp@intel.com/
All warnings (new ones prefixed by >>):
>> drivers/mfd/atmel-smc.c:24:1: warning: data definition has no type or storage class
24 | EXPORT_SYMBOL_GPL(atmel_smc_cs_conf_init);
| ^~~~~~~~~~~~~~~~~
drivers/mfd/atmel-smc.c:24:1: error: type defaults to 'int' in declaration of 'EXPORT_SYMBOL_GPL' [-Wimplicit-int]
drivers/mfd/atmel-smc.c:24:1: error: parameter names (without types) in function declaration [-Wdeclaration-missing-parameter-type]
drivers/mfd/atmel-smc.c:118:1: warning: data definition has no type or storage class
118 | EXPORT_SYMBOL_GPL(atmel_smc_cs_conf_set_timing);
| ^~~~~~~~~~~~~~~~~
drivers/mfd/atmel-smc.c:118:1: error: type defaults to 'int' in declaration of 'EXPORT_SYMBOL_GPL' [-Wimplicit-int]
drivers/mfd/atmel-smc.c:118:1: error: parameter names (without types) in function declaration [-Wdeclaration-missing-parameter-type]
drivers/mfd/atmel-smc.c:157:1: warning: data definition has no type or storage class
157 | EXPORT_SYMBOL_GPL(atmel_smc_cs_conf_set_setup);
| ^~~~~~~~~~~~~~~~~
drivers/mfd/atmel-smc.c:157:1: error: type defaults to 'int' in declaration of 'EXPORT_SYMBOL_GPL' [-Wimplicit-int]
drivers/mfd/atmel-smc.c:157:1: error: parameter names (without types) in function declaration [-Wdeclaration-missing-parameter-type]
drivers/mfd/atmel-smc.c:196:1: warning: data definition has no type or storage class
196 | EXPORT_SYMBOL_GPL(atmel_smc_cs_conf_set_pulse);
| ^~~~~~~~~~~~~~~~~
drivers/mfd/atmel-smc.c:196:1: error: type defaults to 'int' in declaration of 'EXPORT_SYMBOL_GPL' [-Wimplicit-int]
drivers/mfd/atmel-smc.c:196:1: error: parameter names (without types) in function declaration [-Wdeclaration-missing-parameter-type]
drivers/mfd/atmel-smc.c:234:1: warning: data definition has no type or storage class
234 | EXPORT_SYMBOL_GPL(atmel_smc_cs_conf_set_cycle);
| ^~~~~~~~~~~~~~~~~
drivers/mfd/atmel-smc.c:234:1: error: type defaults to 'int' in declaration of 'EXPORT_SYMBOL_GPL' [-Wimplicit-int]
drivers/mfd/atmel-smc.c:234:1: error: parameter names (without types) in function declaration [-Wdeclaration-missing-parameter-type]
drivers/mfd/atmel-smc.c: In function 'atmel_smc_cs_conf_apply':
drivers/mfd/atmel-smc.c:248:9: error: implicit declaration of function 'regmap_write' [-Wimplicit-function-declaration]
248 | regmap_write(regmap, ATMEL_SMC_SETUP(cs), conf->setup);
| ^~~~~~~~~~~~
drivers/mfd/atmel-smc.c: At top level:
drivers/mfd/atmel-smc.c:253:1: warning: data definition has no type or storage class
253 | EXPORT_SYMBOL_GPL(atmel_smc_cs_conf_apply);
| ^~~~~~~~~~~~~~~~~
drivers/mfd/atmel-smc.c:253:1: error: type defaults to 'int' in declaration of 'EXPORT_SYMBOL_GPL' [-Wimplicit-int]
drivers/mfd/atmel-smc.c:253:1: error: parameter names (without types) in function declaration [-Wdeclaration-missing-parameter-type]
drivers/mfd/atmel-smc.c:275:1: warning: data definition has no type or storage class
275 | EXPORT_SYMBOL_GPL(atmel_hsmc_cs_conf_apply);
| ^~~~~~~~~~~~~~~~~
drivers/mfd/atmel-smc.c:275:1: error: type defaults to 'int' in declaration of 'EXPORT_SYMBOL_GPL' [-Wimplicit-int]
drivers/mfd/atmel-smc.c:275:1: error: parameter names (without types) in function declaration [-Wdeclaration-missing-parameter-type]
drivers/mfd/atmel-smc.c: In function 'atmel_smc_cs_conf_get':
drivers/mfd/atmel-smc.c:289:9: error: implicit declaration of function 'regmap_read' [-Wimplicit-function-declaration]
289 | regmap_read(regmap, ATMEL_SMC_SETUP(cs), &conf->setup);
| ^~~~~~~~~~~
drivers/mfd/atmel-smc.c: At top level:
drivers/mfd/atmel-smc.c:294:1: warning: data definition has no type or storage class
294 | EXPORT_SYMBOL_GPL(atmel_smc_cs_conf_get);
| ^~~~~~~~~~~~~~~~~
drivers/mfd/atmel-smc.c:294:1: error: type defaults to 'int' in declaration of 'EXPORT_SYMBOL_GPL' [-Wimplicit-int]
drivers/mfd/atmel-smc.c:294:1: error: parameter names (without types) in function declaration [-Wdeclaration-missing-parameter-type]
drivers/mfd/atmel-smc.c:316:1: warning: data definition has no type or storage class
316 | EXPORT_SYMBOL_GPL(atmel_hsmc_cs_conf_get);
| ^~~~~~~~~~~~~~~~~
drivers/mfd/atmel-smc.c:316:1: error: type defaults to 'int' in declaration of 'EXPORT_SYMBOL_GPL' [-Wimplicit-int]
drivers/mfd/atmel-smc.c:316:1: error: parameter names (without types) in function declaration [-Wdeclaration-missing-parameter-type]
drivers/mfd/atmel-smc.c:326:34: error: array type has incomplete element type 'struct of_device_id'
326 | static const struct of_device_id atmel_smc_ids[] __maybe_unused = {
| ^~~~~~~~~~~~~
drivers/mfd/atmel-smc.c: In function 'atmel_hsmc_get_reg_layout':
drivers/mfd/atmel-smc.c:347:17: error: implicit declaration of function 'of_match_node' [-Wimplicit-function-declaration]
347 | match = of_match_node(atmel_smc_ids, np);
| ^~~~~~~~~~~~~
drivers/mfd/atmel-smc.c:349:29: error: invalid use of undefined type 'const struct of_device_id'
349 | return match ? match->data : ERR_PTR(-EINVAL);
| ^~
drivers/mfd/atmel-smc.c: At top level:
drivers/mfd/atmel-smc.c:351:1: warning: data definition has no type or storage class
351 | EXPORT_SYMBOL_GPL(atmel_hsmc_get_reg_layout);
| ^~~~~~~~~~~~~~~~~
drivers/mfd/atmel-smc.c:351:1: error: type defaults to 'int' in declaration of 'EXPORT_SYMBOL_GPL' [-Wimplicit-int]
drivers/mfd/atmel-smc.c:351:1: error: parameter names (without types) in function declaration [-Wdeclaration-missing-parameter-type]
drivers/mfd/atmel-smc.c:326:34: warning: 'atmel_smc_ids' defined but not used [-Wunused-variable]
326 | static const struct of_device_id atmel_smc_ids[] __maybe_unused = {
| ^~~~~~~~~~~~~
vim +24 drivers/mfd/atmel-smc.c
fe9d7cb22ef3a2 Boris Brezillon 2017-03-16 13
fe9d7cb22ef3a2 Boris Brezillon 2017-03-16 14 /**
fe9d7cb22ef3a2 Boris Brezillon 2017-03-16 15 * atmel_smc_cs_conf_init - initialize a SMC CS conf
fe9d7cb22ef3a2 Boris Brezillon 2017-03-16 16 * @conf: the SMC CS conf to initialize
fe9d7cb22ef3a2 Boris Brezillon 2017-03-16 17 *
fe9d7cb22ef3a2 Boris Brezillon 2017-03-16 18 * Set all fields to 0 so that one can start defining a new config.
fe9d7cb22ef3a2 Boris Brezillon 2017-03-16 19 */
fe9d7cb22ef3a2 Boris Brezillon 2017-03-16 20 void atmel_smc_cs_conf_init(struct atmel_smc_cs_conf *conf)
fe9d7cb22ef3a2 Boris Brezillon 2017-03-16 21 {
fe9d7cb22ef3a2 Boris Brezillon 2017-03-16 22 memset(conf, 0, sizeof(*conf));
fe9d7cb22ef3a2 Boris Brezillon 2017-03-16 23 }
fe9d7cb22ef3a2 Boris Brezillon 2017-03-16 @24 EXPORT_SYMBOL_GPL(atmel_smc_cs_conf_init);
fe9d7cb22ef3a2 Boris Brezillon 2017-03-16 25
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2025-06-27 11:35 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-06-26 15:54 [PATCH v1 1/1] mfd: syscon: atmel-smc: Don't use "proxy" headers Andy Shevchenko
2025-06-26 20:56 ` kernel test robot
2025-06-27 11:30 ` kernel test robot
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.