[android-common:android16-6.12-desktop 0/2] drivers/gpu/drm/drm_writeback.c:233: warning: expecting prototype for drm_writeback_connector_init_with_encoder(). Prototype was for __drm_writeback_connector_init() instead

[android-common:android16-6.12-desktop 0/2] drivers/gpu/drm/drm_writeback.c:233: warning: expecting prototype for drm_writeback_connector_init_with_encoder(). Prototype was for __drm_writeback_connector_init() instead

[kernel test robot]

tree:   https://android.googlesource.com/kernel/common android16-6.12-desktop
head:   0144e2490a70c3551bfb173921278f21d8255d44
commit: 0d388fbee6e6a346d9849425ae6b94333226f69a [0/2] FROMGIT: drm: writeback: Create an helper for drm_writeback_connector initialization
config: x86_64-buildonly-randconfig-2002-20250626 (https://download.01.org/0day-ci/archive/20250627/202506272020.dQA7CBlW-lkp@intel.com/config)
compiler: clang version 20.1.7 (https://github.com/llvm/llvm-project 6146a88f60492b520a36f8f8f3231e15f3cc6082)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250627/202506272020.dQA7CBlW-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202506272020.dQA7CBlW-lkp@intel.com/

All warnings (new ones prefixed by >>):

>> drivers/gpu/drm/drm_writeback.c:233: warning: expecting prototype for drm_writeback_connector_init_with_encoder(). Prototype was for __drm_writeback_connector_init() instead


vim +233 drivers/gpu/drm/drm_writeback.c

7933aecffa28a1 Abhinav Kumar 2022-04-26  204  
7933aecffa28a1 Abhinav Kumar 2022-04-26  205  /**
7933aecffa28a1 Abhinav Kumar 2022-04-26  206   * drm_writeback_connector_init_with_encoder - Initialize a writeback connector with
7933aecffa28a1 Abhinav Kumar 2022-04-26  207   * a custom encoder
7933aecffa28a1 Abhinav Kumar 2022-04-26  208   *
7933aecffa28a1 Abhinav Kumar 2022-04-26  209   * @dev: DRM device
7933aecffa28a1 Abhinav Kumar 2022-04-26  210   * @wb_connector: Writeback connector to initialize
7933aecffa28a1 Abhinav Kumar 2022-04-26  211   * @enc: handle to the already initialized drm encoder
7933aecffa28a1 Abhinav Kumar 2022-04-26  212   * @formats: Array of supported pixel formats for the writeback engine
7933aecffa28a1 Abhinav Kumar 2022-04-26  213   * @n_formats: Length of the formats array
7933aecffa28a1 Abhinav Kumar 2022-04-26  214   *
7933aecffa28a1 Abhinav Kumar 2022-04-26  215   * This function creates the writeback-connector-specific properties if they
7933aecffa28a1 Abhinav Kumar 2022-04-26  216   * have not been already created, initializes the connector as
7933aecffa28a1 Abhinav Kumar 2022-04-26  217   * type DRM_MODE_CONNECTOR_WRITEBACK, and correctly initializes the property
7933aecffa28a1 Abhinav Kumar 2022-04-26  218   * values.
7933aecffa28a1 Abhinav Kumar 2022-04-26  219   *
7933aecffa28a1 Abhinav Kumar 2022-04-26  220   * This function assumes that the drm_writeback_connector's encoder has already been
7933aecffa28a1 Abhinav Kumar 2022-04-26  221   * created and initialized before invoking this function.
7933aecffa28a1 Abhinav Kumar 2022-04-26  222   *
7933aecffa28a1 Abhinav Kumar 2022-04-26  223   * In addition, this function also assumes that callers of this API will manage
7933aecffa28a1 Abhinav Kumar 2022-04-26  224   * assigning the encoder helper functions, possible_crtcs and any other encoder
7933aecffa28a1 Abhinav Kumar 2022-04-26  225   * specific operation.
7933aecffa28a1 Abhinav Kumar 2022-04-26  226   *
7933aecffa28a1 Abhinav Kumar 2022-04-26  227   * Returns: 0 on success, or a negative error code
7933aecffa28a1 Abhinav Kumar 2022-04-26  228   */
0d388fbee6e6a3 Louis Chauvet 2025-01-16  229  static int __drm_writeback_connector_init(struct drm_device *dev,
0d388fbee6e6a3 Louis Chauvet 2025-01-16  230  					  struct drm_writeback_connector *wb_connector,
0d388fbee6e6a3 Louis Chauvet 2025-01-16  231  					  struct drm_encoder *enc, const u32 *formats,
7933aecffa28a1 Abhinav Kumar 2022-04-26  232  					  int n_formats)
935774cd71fe60 Brian Starkey 2017-03-29 @233  {
935774cd71fe60 Brian Starkey 2017-03-29  234  	struct drm_connector *connector = &wb_connector->base;
935774cd71fe60 Brian Starkey 2017-03-29  235  	struct drm_mode_config *config = &dev->mode_config;
0d388fbee6e6a3 Louis Chauvet 2025-01-16  236  	struct drm_property_blob *blob;
935774cd71fe60 Brian Starkey 2017-03-29  237  	int ret = create_writeback_properties(dev);
935774cd71fe60 Brian Starkey 2017-03-29  238  
935774cd71fe60 Brian Starkey 2017-03-29  239  	if (ret != 0)
935774cd71fe60 Brian Starkey 2017-03-29  240  		return ret;
935774cd71fe60 Brian Starkey 2017-03-29  241  
935774cd71fe60 Brian Starkey 2017-03-29  242  	connector->interlace_allowed = 0;
935774cd71fe60 Brian Starkey 2017-03-29  243  
7933aecffa28a1 Abhinav Kumar 2022-04-26  244  	ret = drm_connector_attach_encoder(connector, enc);
935774cd71fe60 Brian Starkey 2017-03-29  245  	if (ret)
0d388fbee6e6a3 Louis Chauvet 2025-01-16  246  		return ret;
0d388fbee6e6a3 Louis Chauvet 2025-01-16  247  
0d388fbee6e6a3 Louis Chauvet 2025-01-16  248  	blob = drm_property_create_blob(dev, n_formats * sizeof(*formats),
0d388fbee6e6a3 Louis Chauvet 2025-01-16  249  					formats);
0d388fbee6e6a3 Louis Chauvet 2025-01-16  250  	if (IS_ERR(blob))
0d388fbee6e6a3 Louis Chauvet 2025-01-16  251  		return PTR_ERR(blob);
935774cd71fe60 Brian Starkey 2017-03-29  252  
935774cd71fe60 Brian Starkey 2017-03-29  253  	INIT_LIST_HEAD(&wb_connector->job_queue);
935774cd71fe60 Brian Starkey 2017-03-29  254  	spin_lock_init(&wb_connector->job_lock);
935774cd71fe60 Brian Starkey 2017-03-29  255  
b13cc8dd588434 Brian Starkey 2017-03-29  256  	wb_connector->fence_context = dma_fence_context_alloc(1);
b13cc8dd588434 Brian Starkey 2017-03-29  257  	spin_lock_init(&wb_connector->fence_lock);
b13cc8dd588434 Brian Starkey 2017-03-29  258  	snprintf(wb_connector->timeline_name,
b13cc8dd588434 Brian Starkey 2017-03-29  259  		 sizeof(wb_connector->timeline_name),
b13cc8dd588434 Brian Starkey 2017-03-29  260  		 "CONNECTOR:%d-%s", connector->base.id, connector->name);
b13cc8dd588434 Brian Starkey 2017-03-29  261  
b13cc8dd588434 Brian Starkey 2017-03-29  262  	drm_object_attach_property(&connector->base,
b13cc8dd588434 Brian Starkey 2017-03-29  263  				   config->writeback_out_fence_ptr_property, 0);
b13cc8dd588434 Brian Starkey 2017-03-29  264  
935774cd71fe60 Brian Starkey 2017-03-29  265  	drm_object_attach_property(&connector->base,
935774cd71fe60 Brian Starkey 2017-03-29  266  				   config->writeback_fb_id_property, 0);
935774cd71fe60 Brian Starkey 2017-03-29  267  
935774cd71fe60 Brian Starkey 2017-03-29  268  	drm_object_attach_property(&connector->base,
935774cd71fe60 Brian Starkey 2017-03-29  269  				   config->writeback_pixel_formats_property,
935774cd71fe60 Brian Starkey 2017-03-29  270  				   blob->base.id);
935774cd71fe60 Brian Starkey 2017-03-29  271  	wb_connector->pixel_formats_blob_ptr = blob;
935774cd71fe60 Brian Starkey 2017-03-29  272  
935774cd71fe60 Brian Starkey 2017-03-29  273  	return 0;
0d388fbee6e6a3 Louis Chauvet 2025-01-16  274  }
0d388fbee6e6a3 Louis Chauvet 2025-01-16  275  

:::::: The code at line 233 was first introduced by commit
:::::: 935774cd71fe604cc8ed24adcb507d7784255672 drm: Add writeback connector type

:::::: TO: Brian Starkey <brian.starkey@arm.com>
:::::: CC: Liviu Dudau <Liviu.Dudau@arm.com>

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki