All of lore.kernel.org
 help / color / mirror / Atom feed
From: Diederik de Haas <didi.debian@cknow.org>
To: Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Heiko Stuebner <heiko@sntech.de>
Cc: Dragan Simic <dsimic@manjaro.org>,
	Quentin Schulz <quentin.schulz@cherry.de>,
	Johan Jonker <jbx6244@gmail.com>,
	devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org,
	Diederik de Haas <didi.debian@cknow.org>
Subject: [PATCH v3 08/10] arm64: dts: rockchip: Fix LCD panel port on rk3566-pinetab2
Date: Sun, 29 Jun 2025 14:34:49 +0200	[thread overview]
Message-ID: <20250629123840.34948-9-didi.debian@cknow.org> (raw)
In-Reply-To: <20250629123840.34948-1-didi.debian@cknow.org>

The MIPI DSI connector on the PineTab2 only has 1 port with 1 endpoint,
so drop the unit-address properties.

While at it, move 'rotation' property to its proper sorting position.

This fixes the following DTB validation warnings:

  node has a unit name, but no reg or ranges property

Signed-off-by: Diederik de Haas <didi.debian@cknow.org>
---
 arch/arm64/boot/dts/rockchip/rk3566-pinetab2.dtsi | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/arch/arm64/boot/dts/rockchip/rk3566-pinetab2.dtsi b/arch/arm64/boot/dts/rockchip/rk3566-pinetab2.dtsi
index 3473b1eef5cd..d0e38412d56a 100644
--- a/arch/arm64/boot/dts/rockchip/rk3566-pinetab2.dtsi
+++ b/arch/arm64/boot/dts/rockchip/rk3566-pinetab2.dtsi
@@ -282,11 +282,11 @@ lcd: panel@0 {
 		reg = <0>;
 		backlight = <&backlight>;
 		enable-gpios = <&gpio0 RK_PC7 GPIO_ACTIVE_HIGH>;
-		rotation = <90>;
 		power-supply = <&vcc_3v3>;
+		rotation = <90>;
 
-		port@0 {
-			panel_in_dsi: endpoint@0 {
+		port {
+			panel_in_dsi: endpoint {
 				remote-endpoint = <&dsi0_out_con>;
 			};
 		};
-- 
2.50.0



WARNING: multiple messages have this Message-ID (diff)
From: Diederik de Haas <didi.debian@cknow.org>
To: Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Heiko Stuebner <heiko@sntech.de>
Cc: Dragan Simic <dsimic@manjaro.org>,
	Quentin Schulz <quentin.schulz@cherry.de>,
	Johan Jonker <jbx6244@gmail.com>,
	devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org,
	Diederik de Haas <didi.debian@cknow.org>
Subject: [PATCH v3 08/10] arm64: dts: rockchip: Fix LCD panel port on rk3566-pinetab2
Date: Sun, 29 Jun 2025 14:34:49 +0200	[thread overview]
Message-ID: <20250629123840.34948-9-didi.debian@cknow.org> (raw)
In-Reply-To: <20250629123840.34948-1-didi.debian@cknow.org>

The MIPI DSI connector on the PineTab2 only has 1 port with 1 endpoint,
so drop the unit-address properties.

While at it, move 'rotation' property to its proper sorting position.

This fixes the following DTB validation warnings:

  node has a unit name, but no reg or ranges property

Signed-off-by: Diederik de Haas <didi.debian@cknow.org>
---
 arch/arm64/boot/dts/rockchip/rk3566-pinetab2.dtsi | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/arch/arm64/boot/dts/rockchip/rk3566-pinetab2.dtsi b/arch/arm64/boot/dts/rockchip/rk3566-pinetab2.dtsi
index 3473b1eef5cd..d0e38412d56a 100644
--- a/arch/arm64/boot/dts/rockchip/rk3566-pinetab2.dtsi
+++ b/arch/arm64/boot/dts/rockchip/rk3566-pinetab2.dtsi
@@ -282,11 +282,11 @@ lcd: panel@0 {
 		reg = <0>;
 		backlight = <&backlight>;
 		enable-gpios = <&gpio0 RK_PC7 GPIO_ACTIVE_HIGH>;
-		rotation = <90>;
 		power-supply = <&vcc_3v3>;
+		rotation = <90>;
 
-		port@0 {
-			panel_in_dsi: endpoint@0 {
+		port {
+			panel_in_dsi: endpoint {
 				remote-endpoint = <&dsi0_out_con>;
 			};
 		};
-- 
2.50.0


_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip

  parent reply	other threads:[~2025-06-29 13:00 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-06-29 12:34 [PATCH v3 00/10] Fix several DTB validation issues Diederik de Haas
2025-06-29 12:34 ` Diederik de Haas
2025-06-29 12:34 ` [PATCH v3 01/10] arm64: dts: rockchip: Move dsi address+size-cells from SoC to px30 boards Diederik de Haas
2025-06-29 12:34   ` Diederik de Haas
2025-06-29 12:34 ` [PATCH v3 02/10] arm64: dts: rockchip: Move dsi address+size-cells from SoC to rk3399 boards Diederik de Haas
2025-06-29 12:34   ` Diederik de Haas
2025-06-29 12:34 ` [PATCH v3 03/10] dt-bindings: display: rockchip,dw-mipi-dsi: Drop address/size cells Diederik de Haas
2025-06-29 12:34   ` Diederik de Haas
2025-07-08 15:47   ` Rob Herring
2025-07-08 15:47     ` Rob Herring
2025-07-08 16:18     ` Diederik de Haas
2025-07-08 16:18       ` Diederik de Haas
2025-06-29 12:34 ` [PATCH v3 04/10] arm64: dts: rockchip: Simplify VOP port definition on rk3328 Diederik de Haas
2025-06-29 12:34   ` Diederik de Haas
2025-06-29 12:34 ` [PATCH v3 05/10] arm64: dts: rockchip: Simplify edp endpoints on several rk3399 boards Diederik de Haas
2025-06-29 12:34   ` Diederik de Haas
2025-06-29 12:34 ` [PATCH v3 06/10] arm64: dts: rockchip: Simplify mipi_out endpoint on rk3399 RP64 dtso Diederik de Haas
2025-06-29 12:34   ` Diederik de Haas
2025-06-29 12:34 ` [PATCH v3 07/10] arm64: dts: rockchip: Move mipi_out node on rk3399 haikou demo dtso Diederik de Haas
2025-06-29 12:34   ` Diederik de Haas
2025-06-29 12:34 ` Diederik de Haas [this message]
2025-06-29 12:34   ` [PATCH v3 08/10] arm64: dts: rockchip: Fix LCD panel port on rk3566-pinetab2 Diederik de Haas
2025-06-29 12:34 ` [PATCH v3 09/10] arm64: dts: rockchip: Drop unneeded address+size-cells on px30 Diederik de Haas
2025-06-29 12:34   ` Diederik de Haas
2025-06-29 12:34 ` [PATCH v3 10/10] arm64: dts: rockchip: Drop regulator-compatible property on rk3399 Diederik de Haas
2025-06-29 12:34   ` Diederik de Haas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250629123840.34948-9-didi.debian@cknow.org \
    --to=didi.debian@cknow.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dsimic@manjaro.org \
    --cc=heiko@sntech.de \
    --cc=jbx6244@gmail.com \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rockchip@lists.infradead.org \
    --cc=quentin.schulz@cherry.de \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.