* [PATCH] target/s390x: set has_deprecated_props flag
@ 2025-06-30 2:44 Collin Walling
2025-06-30 6:16 ` Philippe Mathieu-Daudé
0 siblings, 1 reply; 2+ messages in thread
From: Collin Walling @ 2025-06-30 2:44 UTC (permalink / raw)
To: qemu-s390x, qemu-devel; +Cc: thuth, richard.henderson, david, iii, fiuczy
Now that the deprecated_props is an optional field, the expansion method
must now set the "has_deprecated_props" flag in order for the data to be
output from the response.
Fixes: 448553bb7c (qapi: Make CpuModelExpansionInfo::deprecated-props optional and generic)
Signed-off-by: Collin Walling <walling@linux.ibm.com>
---
target/s390x/cpu_models_system.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/target/s390x/cpu_models_system.c b/target/s390x/cpu_models_system.c
index 9d84faa3c9e..5b846048675 100644
--- a/target/s390x/cpu_models_system.c
+++ b/target/s390x/cpu_models_system.c
@@ -252,6 +252,9 @@ CpuModelExpansionInfo *qmp_query_cpu_model_expansion(CpuModelExpansionType type,
s390_feat_bitmap_to_ascii(deprecated_feats,
&expansion_info->deprecated_props, list_add_feat);
+
+ expansion_info->has_deprecated_props = !!expansion_info->deprecated_props;
+
return expansion_info;
}
--
2.49.0
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] target/s390x: set has_deprecated_props flag
2025-06-30 2:44 [PATCH] target/s390x: set has_deprecated_props flag Collin Walling
@ 2025-06-30 6:16 ` Philippe Mathieu-Daudé
0 siblings, 0 replies; 2+ messages in thread
From: Philippe Mathieu-Daudé @ 2025-06-30 6:16 UTC (permalink / raw)
To: Collin Walling, qemu-s390x, qemu-devel
Cc: thuth, richard.henderson, david, iii, fiuczy
On 30/6/25 04:44, Collin Walling wrote:
> Now that the deprecated_props is an optional field, the expansion method
> must now set the "has_deprecated_props" flag in order for the data to be
> output from the response.
>
> Fixes: 448553bb7c (qapi: Make CpuModelExpansionInfo::deprecated-props optional and generic)
> Signed-off-by: Collin Walling <walling@linux.ibm.com>
> ---
> target/s390x/cpu_models_system.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/target/s390x/cpu_models_system.c b/target/s390x/cpu_models_system.c
> index 9d84faa3c9e..5b846048675 100644
> --- a/target/s390x/cpu_models_system.c
> +++ b/target/s390x/cpu_models_system.c
> @@ -252,6 +252,9 @@ CpuModelExpansionInfo *qmp_query_cpu_model_expansion(CpuModelExpansionType type,
>
> s390_feat_bitmap_to_ascii(deprecated_feats,
> &expansion_info->deprecated_props, list_add_feat);
> +
> + expansion_info->has_deprecated_props = !!expansion_info->deprecated_props;
> +
> return expansion_info;
> }
>
Oops.
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2025-06-30 6:16 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-06-30 2:44 [PATCH] target/s390x: set has_deprecated_props flag Collin Walling
2025-06-30 6:16 ` Philippe Mathieu-Daudé
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.