[linux-next:master 889/5998] drivers/spi/spi-fsl-dspi.c:1358 dspi_resume() warn: 'dspi->clk' from clk_prepare_enable() not released on lines: 1352.

[linux-next:master 889/5998] drivers/spi/spi-fsl-dspi.c:1358 dspi_resume() warn: 'dspi->clk' from clk_prepare_enable() not released on lines: 1352.

[kernel test robot]

BCC: lkp@intel.com
CC: oe-kbuild-all@lists.linux.dev
TO: Larisa Grigore <larisa.grigore@nxp.com>
CC: Mark Brown <broonie@kernel.org>
CC: James Clark <james.clark@linaro.org>

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
head:   2aeda9592360c200085898a258c4754bfe879921
commit: c5412ec5f687732f9722bd0f94f9632ad78f4c52 [889/5998] spi: spi-fsl-dspi: Reinitialize DSPI regs after resuming for S32G
:::::: branch date: 3 days ago
:::::: commit date: 3 weeks ago
config: arm-randconfig-r072-20250630 (https://download.01.org/0day-ci/archive/20250630/202506301541.8dfVGezn-lkp@intel.com/config)
compiler: clang version 20.1.7 (https://github.com/llvm/llvm-project 6146a88f60492b520a36f8f8f3231e15f3cc6082)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Reported-by: Dan Carpenter <error27@gmail.com>
| Closes: https://lore.kernel.org/r/202506301541.8dfVGezn-lkp@intel.com/

New smatch warnings:
drivers/spi/spi-fsl-dspi.c:1358 dspi_resume() warn: 'dspi->clk' from clk_prepare_enable() not released on lines: 1352.

Old smatch warnings:
drivers/spi/spi-fsl-dspi.c:1516 dspi_probe() warn: why call request_threaded_irq() with a NULL thread

vim +1358 drivers/spi/spi-fsl-dspi.c

c5412ec5f68773 Larisa Grigore 2025-05-22  1336  
c5412ec5f68773 Larisa Grigore 2025-05-22  1337  static int dspi_resume(struct device *dev)
c5412ec5f68773 Larisa Grigore 2025-05-22  1338  {
c5412ec5f68773 Larisa Grigore 2025-05-22  1339  	struct fsl_dspi *dspi = dev_get_drvdata(dev);
c5412ec5f68773 Larisa Grigore 2025-05-22  1340  	int ret;
c5412ec5f68773 Larisa Grigore 2025-05-22  1341  
c5412ec5f68773 Larisa Grigore 2025-05-22  1342  	pinctrl_pm_select_default_state(dev);
c5412ec5f68773 Larisa Grigore 2025-05-22  1343  
c5412ec5f68773 Larisa Grigore 2025-05-22  1344  	ret = clk_prepare_enable(dspi->clk);
c5412ec5f68773 Larisa Grigore 2025-05-22  1345  	if (ret)
c5412ec5f68773 Larisa Grigore 2025-05-22  1346  		return ret;
c5412ec5f68773 Larisa Grigore 2025-05-22  1347  	spi_controller_resume(dspi->ctlr);
c5412ec5f68773 Larisa Grigore 2025-05-22  1348  
c5412ec5f68773 Larisa Grigore 2025-05-22  1349  	ret = dspi_init(dspi);
c5412ec5f68773 Larisa Grigore 2025-05-22  1350  	if (ret) {
c5412ec5f68773 Larisa Grigore 2025-05-22  1351  		dev_err(dev, "failed to initialize dspi during resume\n");
c5412ec5f68773 Larisa Grigore 2025-05-22  1352  		return ret;
c5412ec5f68773 Larisa Grigore 2025-05-22  1353  	}
c5412ec5f68773 Larisa Grigore 2025-05-22  1354  
c5412ec5f68773 Larisa Grigore 2025-05-22  1355  	if (dspi->irq)
c5412ec5f68773 Larisa Grigore 2025-05-22  1356  		enable_irq(dspi->irq);
c5412ec5f68773 Larisa Grigore 2025-05-22  1357  
c5412ec5f68773 Larisa Grigore 2025-05-22 @1358  	return 0;
c5412ec5f68773 Larisa Grigore 2025-05-22  1359  }
c5412ec5f68773 Larisa Grigore 2025-05-22  1360  #endif /* CONFIG_PM_SLEEP */
c5412ec5f68773 Larisa Grigore 2025-05-22  1361  

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki