Re: [Intel-wired-lan] [PATCH net] i40e: report VF tx_dropped with tx_errors instead of tx_discards

[Simon Horman <horms@kernel.org>]

On Wed, Jun 18, 2025 at 03:52:40PM -0400, Dennis Chen wrote:
> Currently the tx_dropped field in VF stats is not updated correctly
> when reading stats from the PF. This is because it reads from
> i40e_eth_stats.tx_discards which seems to be unused for per VSI stats,
> as it is not updated by i40e_update_eth_stats() and the corresponding
> register, GLV_TDPC, is not implemented[1].
> 
> Use i40e_eth_stats.tx_errors instead, which is actually updated by
> i40e_update_eth_stats() by reading from GLV_TEPC.

...

> Fixes: dc645daef9af5bcbd9c ("i40e: implement VF stats NDO")
> Signed-off-by: Dennis Chen <dechen@redhat.com>
>     Link: https://www.intel.com/content/www/us/en/content-details/596333/intel-ethernet-controller-x710-tm4-at2-carlsville-datasheet.html

Hi Dennis,

Thanks for the detailed explanation, it's very much appreciated.

One minor nit, is that there are some leading spaces before "Link: "
a few lines above. But I suspect you don't need to repost just to
address that.

Reviewed-by: Simon Horman <horms@kernel.org>