[PATCH] tests/functional/test_aarch64_sbsaref_freebsd: Fix the URL of the ISO image

[PATCH] tests/functional/test_aarch64_sbsaref_freebsd: Fix the URL of the ISO image

[Thomas Huth]

From: Thomas Huth <thuth@redhat.com>

The original image has been removed from the server, so the test
currently fails if it has to fetch the asset, but we can still
download the ISO from the archive server. While we're at it, prefer
the XZ compressed image, it's much smaller and thus the download
should be faster.

Signed-off-by: Thomas Huth <thuth@redhat.com>
---
 tests/functional/test_aarch64_sbsaref_freebsd.py | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/tests/functional/test_aarch64_sbsaref_freebsd.py b/tests/functional/test_aarch64_sbsaref_freebsd.py
index 26dfc5878bb..92ebc69c9b1 100755
--- a/tests/functional/test_aarch64_sbsaref_freebsd.py
+++ b/tests/functional/test_aarch64_sbsaref_freebsd.py
@@ -18,9 +18,9 @@
 class Aarch64SbsarefFreeBSD(QemuSystemTest):
 
     ASSET_FREEBSD_ISO = Asset(
-        ('https://download.freebsd.org/releases/arm64/aarch64/ISO-IMAGES/'
-         '14.1/FreeBSD-14.1-RELEASE-arm64-aarch64-bootonly.iso'),
-        '44cdbae275ef1bb6dab1d5fbb59473d4f741e1c8ea8a80fd9e906b531d6ad461')
+        ('http://ftp-archive.freebsd.org/pub/FreeBSD-Archive/old-releases/arm64'
+         '/aarch64/ISO-IMAGES/14.1/FreeBSD-14.1-RELEASE-arm64-aarch64-bootonly.iso.xz'),
+        '7313a4495ffd71ab77b49b1e83f571521c32756e1d75bf48bd890e0ab0f75827')
 
     # This tests the whole boot chain from EFI to Userspace
     # We only boot a whole OS for the current top level CPU and GIC
@@ -28,7 +28,7 @@ class Aarch64SbsarefFreeBSD(QemuSystemTest):
     def boot_freebsd14(self, cpu=None):
         fetch_firmware(self)
 
-        img_path = self.ASSET_FREEBSD_ISO.fetch()
+        img_path = self.uncompress(self.ASSET_FREEBSD_ISO)
 
         self.vm.set_console()
         self.vm.add_args(
-- 
2.50.0

Re: [PATCH] tests/functional/test_aarch64_sbsaref_freebsd: Fix the URL of the ISO image

[Stefan Hajnoczi]

On Tue, Jul 1, 2025 at 6:58 AM Thomas Huth <thuth@redhat.com> wrote:
>
> From: Thomas Huth <thuth@redhat.com>
>
> The original image has been removed from the server, so the test
> currently fails if it has to fetch the asset, but we can still
> download the ISO from the archive server. While we're at it, prefer
> the XZ compressed image, it's much smaller and thus the download
> should be faster.
>
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
>  tests/functional/test_aarch64_sbsaref_freebsd.py | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)

Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>

>
> diff --git a/tests/functional/test_aarch64_sbsaref_freebsd.py b/tests/functional/test_aarch64_sbsaref_freebsd.py
> index 26dfc5878bb..92ebc69c9b1 100755
> --- a/tests/functional/test_aarch64_sbsaref_freebsd.py
> +++ b/tests/functional/test_aarch64_sbsaref_freebsd.py
> @@ -18,9 +18,9 @@
>  class Aarch64SbsarefFreeBSD(QemuSystemTest):
>
>      ASSET_FREEBSD_ISO = Asset(
> -        ('https://download.freebsd.org/releases/arm64/aarch64/ISO-IMAGES/'
> -         '14.1/FreeBSD-14.1-RELEASE-arm64-aarch64-bootonly.iso'),
> -        '44cdbae275ef1bb6dab1d5fbb59473d4f741e1c8ea8a80fd9e906b531d6ad461')
> +        ('http://ftp-archive.freebsd.org/pub/FreeBSD-Archive/old-releases/arm64'
> +         '/aarch64/ISO-IMAGES/14.1/FreeBSD-14.1-RELEASE-arm64-aarch64-bootonly.iso.xz'),
> +        '7313a4495ffd71ab77b49b1e83f571521c32756e1d75bf48bd890e0ab0f75827')
>
>      # This tests the whole boot chain from EFI to Userspace
>      # We only boot a whole OS for the current top level CPU and GIC
> @@ -28,7 +28,7 @@ class Aarch64SbsarefFreeBSD(QemuSystemTest):
>      def boot_freebsd14(self, cpu=None):
>          fetch_firmware(self)
>
> -        img_path = self.ASSET_FREEBSD_ISO.fetch()
> +        img_path = self.uncompress(self.ASSET_FREEBSD_ISO)
>
>          self.vm.set_console()
>          self.vm.add_args(
> --
> 2.50.0
>

Re: [PATCH] tests/functional/test_aarch64_sbsaref_freebsd: Fix the URL of the ISO image

[Warner Losh]

On Tue, Jul 1, 2025 at 4:58 AM Thomas Huth <thuth@redhat.com> wrote:
>
> From: Thomas Huth <thuth@redhat.com>
>
> The original image has been removed from the server, so the test
> currently fails if it has to fetch the asset, but we can still
> download the ISO from the archive server. While we're at it, prefer
> the XZ compressed image, it's much smaller and thus the download
> should be faster.
>
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
>  tests/functional/test_aarch64_sbsaref_freebsd.py | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/tests/functional/test_aarch64_sbsaref_freebsd.py b/tests/functional/test_aarch64_sbsaref_freebsd.py
> index 26dfc5878bb..92ebc69c9b1 100755
> --- a/tests/functional/test_aarch64_sbsaref_freebsd.py
> +++ b/tests/functional/test_aarch64_sbsaref_freebsd.py
> @@ -18,9 +18,9 @@
>  class Aarch64SbsarefFreeBSD(QemuSystemTest):
>
>      ASSET_FREEBSD_ISO = Asset(
> -        ('https://download.freebsd.org/releases/arm64/aarch64/ISO-IMAGES/'
> -         '14.1/FreeBSD-14.1-RELEASE-arm64-aarch64-bootonly.iso'),
> -        '44cdbae275ef1bb6dab1d5fbb59473d4f741e1c8ea8a80fd9e906b531d6ad461')
> +        ('http://ftp-archive.freebsd.org/pub/FreeBSD-Archive/old-releases/arm64'
> +         '/aarch64/ISO-IMAGES/14.1/FreeBSD-14.1-RELEASE-arm64-aarch64-bootonly.iso.xz'),
> +        '7313a4495ffd71ab77b49b1e83f571521c32756e1d75bf48bd890e0ab0f75827')
>
>      # This tests the whole boot chain from EFI to Userspace
>      # We only boot a whole OS for the current top level CPU and GIC
> @@ -28,7 +28,7 @@ class Aarch64SbsarefFreeBSD(QemuSystemTest):
>      def boot_freebsd14(self, cpu=None):
>          fetch_firmware(self)
>
> -        img_path = self.ASSET_FREEBSD_ISO.fetch()
> +        img_path = self.uncompress(self.ASSET_FREEBSD_ISO)
>
>          self.vm.set_console()
>          self.vm.add_args(

Reviewed-by: Warner Losh <imp@bsdimp.com>

Though maybe updating to 14.3 would be better.

Warner