Re: [PATCH v4 2/7] mfd: simple-mfd-i2c: add SpacemiT P1 support

From: Lee Jones <lee@kernel.org>
To: Alex Elder <elder@riscstar.com>
Cc: lgirdwood@gmail.com, broonie@kernel.org,
	alexandre.belloni@bootlin.com, robh@kernel.org,
	krzk+dt@kernel.org, conor+dt@kernel.org, mat.jonczyk@o2.pl,
	dlan@gentoo.org, paul.walmsley@sifive.com, palmer@dabbelt.com,
	aou@eecs.berkeley.edu, alex@ghiti.fr, troymitchell988@gmail.com,
	linux-rtc@vger.kernel.org, devicetree@vger.kernel.org,
	linux-riscv@lists.infradead.org, spacemit@lists.linux.dev,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 2/7] mfd: simple-mfd-i2c: add SpacemiT P1 support
Date: Tue, 1 Jul 2025 12:07:13 +0100	[thread overview]
Message-ID: <20250701110713.GL10134@google.com> (raw)
In-Reply-To: <0eda5bf4-ce63-43da-9c2f-7d4ec902758c@riscstar.com>

On Fri, 27 Jun 2025, Alex Elder wrote:

> On 6/27/25 7:51 AM, Lee Jones wrote:
> > > @@ -93,12 +93,30 @@ static const struct simple_mfd_data maxim_mon_max77705 = {
> > >   	.mfd_cell_size = ARRAY_SIZE(max77705_sensor_cells),
> > >   };
> > > +static const struct regmap_config spacemit_p1_regmap_config = {
> > > +	.reg_bits = 8,
> > > +	.val_bits = 8,
> > > +	.max_register = 0xaa,
> > > +};
> > Suggest making this more widely useful by adding the 'max_register'
> > attribute to 'struct simple_mfd' and conditionally overriding
> > regmap_config_8r_8v's value during probe.
> 
> So you're suggesting I make a general improvement to
> "simple-mfd-i2c.c", because everybody else just uses
> the generic fallback regmap config?

Yes, exactly that.

> (I'm asking because at first I didn't understand your
> statement, and the "more widely useful" comment).
> 
> I would be happy to do this, and it's not that hard.
> Can I do it as a follow-on patch though?  It's adding
> scope (again), beyond what I anticipated and honestly
> I'm ready to be done with this...

Good job you're not working on a complex addition then.  =;-)

> Anyway, if you say "no" I'll send another version of
> this series today.

A follow-up would be good, thanks.

-- 
Lee Jones [李琼斯]