[RESEND PATCH mfd-next v2] mfd: Drop unused variables 'node'

[RESEND PATCH mfd-next v2] mfd: Drop unused variables 'node'

[Geliang Tang]

From: Geliang Tang <tanggeliang@kylinos.cn>

This patch drops the unused variables 'node' to fix the following build
warnings:

drivers/mfd/88pm860x-core.c: In function 'device_irq_init':
drivers/mfd/88pm860x-core.c:576:29: warning: unused variable 'node' [-Wunused-variable]
  576 |         struct device_node *node = i2c->dev.of_node;
      |                             ^~~~

drivers/mfd/max8925-core.c: In function 'max8925_irq_init':
drivers/mfd/max8925-core.c:659:29: warning: unused variable 'node' [-Wunused-variable]
  659 |         struct device_node *node = chip->dev->of_node;
      |                             ^~~~

drivers/mfd/twl4030-irq.c: In function 'twl4030_init_irq':
drivers/mfd/twl4030-irq.c:679:46: warning: unused variable 'node' [-Wunused-variable]
  679 |         struct                  device_node *node = dev->of_node;
      |                                              ^~~~

Signed-off-by: Geliang Tang <tanggeliang@kylinos.cn>
---
RESEND:
 - cc more people.
v2:
 - drop unused variables 'node' in max8925-core.c and twl4030-irq.c too.
---
 drivers/mfd/88pm860x-core.c | 1 -
 drivers/mfd/max8925-core.c  | 1 -
 drivers/mfd/twl4030-irq.c   | 1 -
 3 files changed, 3 deletions(-)

diff --git a/drivers/mfd/88pm860x-core.c b/drivers/mfd/88pm860x-core.c
index 488e346047c1..750f9db95386 100644
--- a/drivers/mfd/88pm860x-core.c
+++ b/drivers/mfd/88pm860x-core.c
@@ -573,7 +573,6 @@ static int device_irq_init(struct pm860x_chip *chip,
 	unsigned long flags = IRQF_TRIGGER_FALLING | IRQF_ONESHOT;
 	int data, mask, ret = -EINVAL;
 	int nr_irqs, irq_base = -1;
-	struct device_node *node = i2c->dev.of_node;
 
 	mask = PM8607_B0_MISC1_INV_INT | PM8607_B0_MISC1_INT_CLEAR
 		| PM8607_B0_MISC1_INT_MASK;
diff --git a/drivers/mfd/max8925-core.c b/drivers/mfd/max8925-core.c
index 78b16c67a5fc..9d6358337d97 100644
--- a/drivers/mfd/max8925-core.c
+++ b/drivers/mfd/max8925-core.c
@@ -656,7 +656,6 @@ static int max8925_irq_init(struct max8925_chip *chip, int irq,
 {
 	unsigned long flags = IRQF_TRIGGER_FALLING | IRQF_ONESHOT;
 	int ret;
-	struct device_node *node = chip->dev->of_node;
 
 	/* clear all interrupts */
 	max8925_reg_read(chip->i2c, MAX8925_CHG_IRQ1);
diff --git a/drivers/mfd/twl4030-irq.c b/drivers/mfd/twl4030-irq.c
index 232c2bfe8c18..c95a73186112 100644
--- a/drivers/mfd/twl4030-irq.c
+++ b/drivers/mfd/twl4030-irq.c
@@ -676,7 +676,6 @@ int twl4030_init_irq(struct device *dev, int irq_num)
 	static struct irq_chip	twl4030_irq_chip;
 	int			status, i;
 	int			irq_base, irq_end, nr_irqs;
-	struct			device_node *node = dev->of_node;
 
 	/*
 	 * TWL core and pwr interrupts must be contiguous because
-- 
2.48.1

Re: (subset) [RESEND PATCH mfd-next v2] mfd: Drop unused variables 'node'

[Lee Jones]

On Thu, 26 Jun 2025 10:48:07 +0800, Geliang Tang wrote:
> This patch drops the unused variables 'node' to fix the following build
> warnings:
> 
> drivers/mfd/88pm860x-core.c: In function 'device_irq_init':
> drivers/mfd/88pm860x-core.c:576:29: warning: unused variable 'node' [-Wunused-variable]
>   576 |         struct device_node *node = i2c->dev.of_node;
>       |                             ^~~~
> 
> [...]

Applied, thanks!

[1/1] mfd: Drop unused variables 'node'
      commit: 0e76098aa66eb82189f5a0681717862271bfb805

--
Lee Jones [李琼斯]

Re: (subset) [RESEND PATCH mfd-next v2] mfd: Drop unused variables 'node'

[Lee Jones]

On Tue, 01 Jul 2025, Lee Jones wrote:

> On Thu, 26 Jun 2025 10:48:07 +0800, Geliang Tang wrote:
> > This patch drops the unused variables 'node' to fix the following build
> > warnings:
> > 
> > drivers/mfd/88pm860x-core.c: In function 'device_irq_init':
> > drivers/mfd/88pm860x-core.c:576:29: warning: unused variable 'node' [-Wunused-variable]
> >   576 |         struct device_node *node = i2c->dev.of_node;
> >       |                             ^~~~
> > 
> > [...]
> 
> Applied, thanks!
> 
> [1/1] mfd: Drop unused variables 'node'
>       commit: 0e76098aa66eb82189f5a0681717862271bfb805

Ah, change of plan.  Arnd already fixed this.

-- 
Lee Jones [李琼斯]