* Re: [PATCH v2] cxl: make cxl_bus_type constant
2025-07-01 12:07 [PATCH v2] cxl: make cxl_bus_type constant Greg Kroah-Hartman
@ 2025-07-01 12:54 ` Jonathan Cameron
2025-07-01 14:58 ` Ira Weiny
` (2 subsequent siblings)
3 siblings, 0 replies; 5+ messages in thread
From: Jonathan Cameron @ 2025-07-01 12:54 UTC (permalink / raw)
To: Greg Kroah-Hartman
Cc: linux-kernel, Davidlohr Bueso, Dave Jiang, Alison Schofield,
Vishal Verma, Ira Weiny, Dan Williams, linux-cxl
On Tue, 1 Jul 2025 14:07:39 +0200
Greg Kroah-Hartman <gregkh@linuxfoundation.org> wrote:
> Now that the driver core can properly handle constant struct bus_type,
> move the cxl_bus_type variable to be a constant structure as well,
> placing it into read-only memory which can not be modified at runtime.
>
> Cc: Davidlohr Bueso <dave@stgolabs.net>
> Cc: Jonathan Cameron <jonathan.cameron@huawei.com>
> Cc: Dave Jiang <dave.jiang@intel.com>
> Cc: Alison Schofield <alison.schofield@intel.com>
> Cc: Vishal Verma <vishal.l.verma@intel.com>
> Cc: Ira Weiny <ira.weiny@intel.com>
> Cc: Dan Williams <dan.j.williams@intel.com>
> Cc: linux-cxl@vger.kernel.org
> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Reviewed-by: Jonathan Cameron <jonathan.cameron@huawei.com>
> ---
> v2: fix up the subject line to be correct
>
> drivers/cxl/core/port.c | 2 +-
> drivers/cxl/cxl.h | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/cxl/core/port.c b/drivers/cxl/core/port.c
> index eb46c6764d20..0696f7fcef56 100644
> --- a/drivers/cxl/core/port.c
> +++ b/drivers/cxl/core/port.c
> @@ -2293,7 +2293,7 @@ static const struct attribute_group *cxl_bus_attribute_groups[] = {
> NULL,
> };
>
> -struct bus_type cxl_bus_type = {
> +const struct bus_type cxl_bus_type = {
> .name = "cxl",
> .uevent = cxl_bus_uevent,
> .match = cxl_bus_match,
> diff --git a/drivers/cxl/cxl.h b/drivers/cxl/cxl.h
> index 3f1695c96abc..e7b66ca1d423 100644
> --- a/drivers/cxl/cxl.h
> +++ b/drivers/cxl/cxl.h
> @@ -815,7 +815,7 @@ int cxl_dvsec_rr_decode(struct cxl_dev_state *cxlds,
>
> bool is_cxl_region(struct device *dev);
>
> -extern struct bus_type cxl_bus_type;
> +extern const struct bus_type cxl_bus_type;
>
> struct cxl_driver {
> const char *name;
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH v2] cxl: make cxl_bus_type constant
2025-07-01 12:07 [PATCH v2] cxl: make cxl_bus_type constant Greg Kroah-Hartman
2025-07-01 12:54 ` Jonathan Cameron
@ 2025-07-01 14:58 ` Ira Weiny
2025-07-01 15:11 ` Dave Jiang
2025-07-01 15:16 ` Dave Jiang
3 siblings, 0 replies; 5+ messages in thread
From: Ira Weiny @ 2025-07-01 14:58 UTC (permalink / raw)
To: Greg Kroah-Hartman, linux-kernel
Cc: Greg Kroah-Hartman, Davidlohr Bueso, Jonathan Cameron, Dave Jiang,
Alison Schofield, Vishal Verma, Ira Weiny, Dan Williams,
linux-cxl
Greg Kroah-Hartman wrote:
> Now that the driver core can properly handle constant struct bus_type,
> move the cxl_bus_type variable to be a constant structure as well,
> placing it into read-only memory which can not be modified at runtime.
>
> Cc: Davidlohr Bueso <dave@stgolabs.net>
> Cc: Jonathan Cameron <jonathan.cameron@huawei.com>
> Cc: Dave Jiang <dave.jiang@intel.com>
> Cc: Alison Schofield <alison.schofield@intel.com>
> Cc: Vishal Verma <vishal.l.verma@intel.com>
> Cc: Ira Weiny <ira.weiny@intel.com>
Reviewed-by: Ira Weiny <ira.weiny@intel.com>
[snip]
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v2] cxl: make cxl_bus_type constant
2025-07-01 12:07 [PATCH v2] cxl: make cxl_bus_type constant Greg Kroah-Hartman
2025-07-01 12:54 ` Jonathan Cameron
2025-07-01 14:58 ` Ira Weiny
@ 2025-07-01 15:11 ` Dave Jiang
2025-07-01 15:16 ` Dave Jiang
3 siblings, 0 replies; 5+ messages in thread
From: Dave Jiang @ 2025-07-01 15:11 UTC (permalink / raw)
To: Greg Kroah-Hartman, linux-kernel
Cc: Davidlohr Bueso, Jonathan Cameron, Alison Schofield, Vishal Verma,
Ira Weiny, Dan Williams, linux-cxl
On 7/1/25 5:07 AM, Greg Kroah-Hartman wrote:
> Now that the driver core can properly handle constant struct bus_type,
> move the cxl_bus_type variable to be a constant structure as well,
> placing it into read-only memory which can not be modified at runtime.
>
> Cc: Davidlohr Bueso <dave@stgolabs.net>
> Cc: Jonathan Cameron <jonathan.cameron@huawei.com>
> Cc: Dave Jiang <dave.jiang@intel.com>
> Cc: Alison Schofield <alison.schofield@intel.com>
> Cc: Vishal Verma <vishal.l.verma@intel.com>
> Cc: Ira Weiny <ira.weiny@intel.com>
> Cc: Dan Williams <dan.j.williams@intel.com>
> Cc: linux-cxl@vger.kernel.org
> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Reviewed-by: Dave Jiang <dave.jiang@intel.com>
> ---
> v2: fix up the subject line to be correct
>
> drivers/cxl/core/port.c | 2 +-
> drivers/cxl/cxl.h | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/cxl/core/port.c b/drivers/cxl/core/port.c
> index eb46c6764d20..0696f7fcef56 100644
> --- a/drivers/cxl/core/port.c
> +++ b/drivers/cxl/core/port.c
> @@ -2293,7 +2293,7 @@ static const struct attribute_group *cxl_bus_attribute_groups[] = {
> NULL,
> };
>
> -struct bus_type cxl_bus_type = {
> +const struct bus_type cxl_bus_type = {
> .name = "cxl",
> .uevent = cxl_bus_uevent,
> .match = cxl_bus_match,
> diff --git a/drivers/cxl/cxl.h b/drivers/cxl/cxl.h
> index 3f1695c96abc..e7b66ca1d423 100644
> --- a/drivers/cxl/cxl.h
> +++ b/drivers/cxl/cxl.h
> @@ -815,7 +815,7 @@ int cxl_dvsec_rr_decode(struct cxl_dev_state *cxlds,
>
> bool is_cxl_region(struct device *dev);
>
> -extern struct bus_type cxl_bus_type;
> +extern const struct bus_type cxl_bus_type;
>
> struct cxl_driver {
> const char *name;
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH v2] cxl: make cxl_bus_type constant
2025-07-01 12:07 [PATCH v2] cxl: make cxl_bus_type constant Greg Kroah-Hartman
` (2 preceding siblings ...)
2025-07-01 15:11 ` Dave Jiang
@ 2025-07-01 15:16 ` Dave Jiang
3 siblings, 0 replies; 5+ messages in thread
From: Dave Jiang @ 2025-07-01 15:16 UTC (permalink / raw)
To: Greg Kroah-Hartman, linux-kernel
Cc: Davidlohr Bueso, Jonathan Cameron, Alison Schofield, Vishal Verma,
Ira Weiny, Dan Williams, linux-cxl
On 7/1/25 5:07 AM, Greg Kroah-Hartman wrote:
> Now that the driver core can properly handle constant struct bus_type,
> move the cxl_bus_type variable to be a constant structure as well,
> placing it into read-only memory which can not be modified at runtime.
>
> Cc: Davidlohr Bueso <dave@stgolabs.net>
> Cc: Jonathan Cameron <jonathan.cameron@huawei.com>
> Cc: Dave Jiang <dave.jiang@intel.com>
> Cc: Alison Schofield <alison.schofield@intel.com>
> Cc: Vishal Verma <vishal.l.verma@intel.com>
> Cc: Ira Weiny <ira.weiny@intel.com>
> Cc: Dan Williams <dan.j.williams@intel.com>
> Cc: linux-cxl@vger.kernel.org
> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Applied to cxl/next
ac0fe6a5731700bcea6fecfd5d0b76c0454b3a20
> ---
> v2: fix up the subject line to be correct
>
> drivers/cxl/core/port.c | 2 +-
> drivers/cxl/cxl.h | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/cxl/core/port.c b/drivers/cxl/core/port.c
> index eb46c6764d20..0696f7fcef56 100644
> --- a/drivers/cxl/core/port.c
> +++ b/drivers/cxl/core/port.c
> @@ -2293,7 +2293,7 @@ static const struct attribute_group *cxl_bus_attribute_groups[] = {
> NULL,
> };
>
> -struct bus_type cxl_bus_type = {
> +const struct bus_type cxl_bus_type = {
> .name = "cxl",
> .uevent = cxl_bus_uevent,
> .match = cxl_bus_match,
> diff --git a/drivers/cxl/cxl.h b/drivers/cxl/cxl.h
> index 3f1695c96abc..e7b66ca1d423 100644
> --- a/drivers/cxl/cxl.h
> +++ b/drivers/cxl/cxl.h
> @@ -815,7 +815,7 @@ int cxl_dvsec_rr_decode(struct cxl_dev_state *cxlds,
>
> bool is_cxl_region(struct device *dev);
>
> -extern struct bus_type cxl_bus_type;
> +extern const struct bus_type cxl_bus_type;
>
> struct cxl_driver {
> const char *name;
^ permalink raw reply [flat|nested] 5+ messages in thread