[PATCH v2 1/1] dt-bindings: net: convert nxp,lpc1850-dwmac.txt to yaml format

[PATCH v2 1/1] dt-bindings: net: convert nxp,lpc1850-dwmac.txt to yaml format

[Frank Li]

Convert nxp,lpc1850-dwmac.txt to yaml format.

Additional changes:
- compatible string add fallback as "nxp,lpc1850-dwmac", "snps,dwmac-3.611"
"snps,dwmac".
- add common interrupts, interrupt-names, clocks, clock-names, resets and
  reset-names properties.
- add ref snps,dwmac.yaml.
- add phy-mode in example to avoid dt_binding_check warning.
- update examples to align lpc18xx.dtsi.

Reviewed-by: Rob Herring (Arm) <robh@kernel.org>
Signed-off-by: Frank Li <Frank.Li@nxp.com>
---
changes in v2
- add Rob's review tags.
- change phy-mode to rgmii-id according to Andrew's suggestions.
---
 .../bindings/net/nxp,lpc1850-dwmac.txt        | 20 -----
 .../bindings/net/nxp,lpc1850-dwmac.yaml       | 85 +++++++++++++++++++
 2 files changed, 85 insertions(+), 20 deletions(-)
 delete mode 100644 Documentation/devicetree/bindings/net/nxp,lpc1850-dwmac.txt
 create mode 100644 Documentation/devicetree/bindings/net/nxp,lpc1850-dwmac.yaml

diff --git a/Documentation/devicetree/bindings/net/nxp,lpc1850-dwmac.txt b/Documentation/devicetree/bindings/net/nxp,lpc1850-dwmac.txt
deleted file mode 100644
index 7edba1264f6f2..0000000000000
--- a/Documentation/devicetree/bindings/net/nxp,lpc1850-dwmac.txt
+++ /dev/null
@@ -1,20 +0,0 @@
-* NXP LPC1850 GMAC ethernet controller
-
-This device is a platform glue layer for stmmac.
-Please see stmmac.txt for the other unchanged properties.
-
-Required properties:
- - compatible:  Should contain "nxp,lpc1850-dwmac"
-
-Examples:
-
-mac: ethernet@40010000 {
-	compatible = "nxp,lpc1850-dwmac", "snps,dwmac-3.611", "snps,dwmac";
-	reg = <0x40010000 0x2000>;
-	interrupts = <5>;
-	interrupt-names = "macirq";
-	clocks = <&ccu1 CLK_CPU_ETHERNET>;
-	clock-names = "stmmaceth";
-	resets = <&rgu 22>;
-	reset-names = "stmmaceth";
-}
diff --git a/Documentation/devicetree/bindings/net/nxp,lpc1850-dwmac.yaml b/Documentation/devicetree/bindings/net/nxp,lpc1850-dwmac.yaml
new file mode 100644
index 0000000000000..05acd9bc76163
--- /dev/null
+++ b/Documentation/devicetree/bindings/net/nxp,lpc1850-dwmac.yaml
@@ -0,0 +1,85 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/net/nxp,lpc1850-dwmac.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: NXP LPC1850 GMAC ethernet controller
+
+maintainers:
+  - Frank Li <Frank.Li@nxp.com>
+
+# We need a select here so we don't match all nodes with 'snps,dwmac'
+select:
+  properties:
+    compatible:
+      contains:
+        enum:
+          - nxp,lpc1850-dwmac
+  required:
+    - compatible
+
+properties:
+  compatible:
+    items:
+      - enum:
+          - nxp,lpc1850-dwmac
+      - const: snps,dwmac-3.611
+      - const: snps,dwmac
+
+  reg:
+    maxItems: 1
+
+  clocks:
+    maxItems: 1
+
+  clock-names:
+    items:
+      - const: stmmaceth
+
+  interrupts:
+    maxItems: 1
+
+  interrupt-names:
+    items:
+      - const: macirq
+
+  resets:
+    maxItems: 1
+
+  reset-names:
+    items:
+      - const: stmmaceth
+
+required:
+  - compatible
+  - reg
+  - clocks
+  - clock-names
+  - interrupts
+  - interrupt-names
+
+allOf:
+  - $ref: snps,dwmac.yaml#
+
+unevaluatedProperties: false
+
+examples:
+  - |
+    #include <dt-bindings/clock/lpc18xx-ccu.h>
+
+    ethernet@40010000 {
+        compatible = "nxp,lpc1850-dwmac", "snps,dwmac-3.611", "snps,dwmac";
+        reg = <0x40010000 0x2000>;
+        interrupts = <5>;
+        interrupt-names = "macirq";
+        clocks = <&ccu1 CLK_CPU_ETHERNET>;
+        clock-names = "stmmaceth";
+        resets = <&rgu 22>;
+        reset-names = "stmmaceth";
+        rx-fifo-depth = <256>;
+        tx-fifo-depth = <256>;
+        snps,pbl = <4>;
+        snps,force_thresh_dma_mode;
+        phy-mode = "rgmii-id";
+    };
-- 
2.34.1

Re: [PATCH v2 1/1] dt-bindings: net: convert nxp,lpc1850-dwmac.txt to yaml format

[patchwork-bot+netdevbpf]

Hello:

This patch was applied to netdev/net-next.git (main)
by Jakub Kicinski <kuba@kernel.org>:

On Mon, 30 Jun 2025 12:16:12 -0400 you wrote:
> Convert nxp,lpc1850-dwmac.txt to yaml format.
> 
> Additional changes:
> - compatible string add fallback as "nxp,lpc1850-dwmac", "snps,dwmac-3.611"
> "snps,dwmac".
> - add common interrupts, interrupt-names, clocks, clock-names, resets and
>   reset-names properties.
> - add ref snps,dwmac.yaml.
> - add phy-mode in example to avoid dt_binding_check warning.
> - update examples to align lpc18xx.dtsi.
> 
> [...]

Here is the summary with links:
  - [v2,1/1] dt-bindings: net: convert nxp,lpc1850-dwmac.txt to yaml format
    https://git.kernel.org/netdev/net-next/c/69fcb70c4334

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html

Re: [PATCH v2 1/1] dt-bindings: net: convert nxp,lpc1850-dwmac.txt to yaml format

[kernel test robot]

:::::: 
:::::: Manual check reason: "dtcheck: binding changes may go via different trees"
:::::: 

BCC: lkp@intel.com
CC: oe-kbuild-all@lists.linux.dev
In-Reply-To: <20250630161613.2838039-1-Frank.Li@nxp.com>
References: <20250630161613.2838039-1-Frank.Li@nxp.com>
TO: Frank Li <Frank.Li@nxp.com>

Hi Frank,

kernel test robot noticed the following build warnings:

[auto build test WARNING on robh/for-next]
[also build test WARNING on net-next/main net/main linus/master v6.16-rc4 next-20250701]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Frank-Li/dt-bindings-net-convert-nxp-lpc1850-dwmac-txt-to-yaml-format/20250701-002132
base:   https://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git for-next
patch link:    https://lore.kernel.org/r/20250630161613.2838039-1-Frank.Li%40nxp.com
patch subject: [PATCH v2 1/1] dt-bindings: net: convert nxp,lpc1850-dwmac.txt to yaml format
:::::: branch date: 2 days ago
:::::: commit date: 2 days ago
config: arm-randconfig-052-20250701 (https://download.01.org/0day-ci/archive/20250702/202507021604.JHDfqJCu-lkp@intel.com/config)
compiler: arm-linux-gnueabi-gcc (GCC) 10.5.0
dtschema version: 2025.6.1
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250702/202507021604.JHDfqJCu-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/r/202507021604.JHDfqJCu-lkp@intel.com/

dtcheck warnings: (new ones prefixed by >>)
   arch/arm/boot/dts/nxp/lpc/lpc4357-myd-lpc4357.dtb: mmcsd@40004000 (snps,dw-mshc): $nodename:0: 'mmcsd@40004000' does not match '^mmc(@.*)?$'
   	from schema $id: http://devicetree.org/schemas/mmc/synopsys-dw-mshc.yaml#
   arch/arm/boot/dts/nxp/lpc/lpc4357-myd-lpc4357.dtb: mmcsd@40004000 (snps,dw-mshc): clock-names:0: 'biu' was expected
   	from schema $id: http://devicetree.org/schemas/mmc/synopsys-dw-mshc.yaml#
   arch/arm/boot/dts/nxp/lpc/lpc4357-myd-lpc4357.dtb: mmcsd@40004000 (snps,dw-mshc): clock-names:1: 'ciu' was expected
   	from schema $id: http://devicetree.org/schemas/mmc/synopsys-dw-mshc.yaml#
   arch/arm/boot/dts/nxp/lpc/lpc4357-myd-lpc4357.dtb: mmcsd@40004000 (snps,dw-mshc): Unevaluated properties are not allowed ('bus-width', 'clock-names', 'resets', 'vmmc-supply' were unexpected)
   	from schema $id: http://devicetree.org/schemas/mmc/synopsys-dw-mshc.yaml#
   arch/arm/boot/dts/nxp/lpc/lpc4357-myd-lpc4357.dtb: /soc/memory-controller@40005000: failed to match any schema with compatible: ['arm,pl172', 'arm,primecell']
   arch/arm/boot/dts/nxp/lpc/lpc4357-myd-lpc4357.dtb: /soc/eeprom@4000e000: failed to match any schema with compatible: ['nxp,lpc1857-eeprom']
>> arch/arm/boot/dts/nxp/lpc/lpc4357-myd-lpc4357.dtb: ethernet@40010000 (nxp,lpc1850-dwmac): Unevaluated properties are not allowed ('mdio0' was unexpected)
   	from schema $id: http://devicetree.org/schemas/net/nxp,lpc1850-dwmac.yaml#
   arch/arm/boot/dts/nxp/lpc/lpc4357-myd-lpc4357.dtb: /soc/syscon@40043000: failed to match any schema with compatible: ['nxp,lpc1850-creg', 'syscon', 'simple-mfd']
   arch/arm/boot/dts/nxp/lpc/lpc4357-myd-lpc4357.dtb: /soc/syscon@40043000/clock-controller: failed to match any schema with compatible: ['nxp,lpc1850-creg-clk']
   arch/arm/boot/dts/nxp/lpc/lpc4357-myd-lpc4357.dtb: /soc/syscon@40043000/phy: failed to match any schema with compatible: ['nxp,lpc1850-usb-otg-phy']
   arch/arm/boot/dts/nxp/lpc/lpc4357-myd-lpc4357.dtb: /soc/syscon@40043000/dma-mux: failed to match any schema with compatible: ['nxp,lpc1850-dmamux']
   arch/arm/boot/dts/nxp/lpc/lpc4357-myd-lpc4357.dtb: rtc@40046000 (nxp,lpc1850-rtc): compatible:0: 'nxp,lpc1788-rtc' was expected
   	from schema $id: http://devicetree.org/schemas/rtc/nxp,lpc1788-rtc.yaml#
   arch/arm/boot/dts/nxp/lpc/lpc4357-myd-lpc4357.dtb: rtc@40046000 (nxp,lpc1850-rtc): compatible: ['nxp,lpc1850-rtc', 'nxp,lpc1788-rtc'] is too long
   	from schema $id: http://devicetree.org/schemas/rtc/nxp,lpc1788-rtc.yaml#
   arch/arm/boot/dts/nxp/lpc/lpc4357-myd-lpc4357.dtb: rtc@40046000 (nxp,lpc1850-rtc): Unevaluated properties are not allowed ('compatible' was unexpected)

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki