From: Lee Jones <lee@kernel.org>
To: Alex Elder <elder@riscstar.com>
Cc: lgirdwood@gmail.com, broonie@kernel.org,
alexandre.belloni@bootlin.com, robh@kernel.org,
krzk+dt@kernel.org, conor+dt@kernel.org, mat.jonczyk@o2.pl,
dlan@gentoo.org, paul.walmsley@sifive.com, palmer@dabbelt.com,
aou@eecs.berkeley.edu, alex@ghiti.fr, troymitchell988@gmail.com,
guodong@riscstar.com, linux-rtc@vger.kernel.org,
devicetree@vger.kernel.org, linux-riscv@lists.infradead.org,
spacemit@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v6 2/8] mfd: simple-mfd-i2c: specify max_register
Date: Wed, 2 Jul 2025 17:26:20 +0100 [thread overview]
Message-ID: <20250702162620.GA10134@google.com> (raw)
In-Reply-To: <0219b698-2f1b-4fcd-bce7-0ba6f6895b11@riscstar.com>
On Wed, 02 Jul 2025, Alex Elder wrote:
> On 7/2/25 10:26 AM, Lee Jones wrote:
> > On Fri, 27 Jun 2025, Alex Elder wrote:
> >
> > > All devices supported by simple MFD use the same 8-bit register
> > > 8-bit value regmap configuration. There is an option available
> > > for a device to specify a custome configuration, but no existing
> > > device uses it.
> > >
> > > Lee Jones suggested modifying the simple MFD implementation to
> > > remove the generality of the full regmap configuration and add a
> > > max_register value to the simple_mfd_data structure. This can
> > > be used in the regmap configuration to limit the valid register
> > > addresses if desired. It's simpler, and covers all existing and
> > > anticipated device types.
> >
> > Woah, not like this. I wanted to make the framework _more_ flexible.
>
> OK, sorry I misunderstood. I'll send another new version today
> that does what you suggest.
No worries. Perhaps I wasn't clear enough.
--
Lee Jones [李琼斯]
WARNING: multiple messages have this Message-ID (diff)
From: Lee Jones <lee@kernel.org>
To: Alex Elder <elder@riscstar.com>
Cc: lgirdwood@gmail.com, broonie@kernel.org,
alexandre.belloni@bootlin.com, robh@kernel.org,
krzk+dt@kernel.org, conor+dt@kernel.org, mat.jonczyk@o2.pl,
dlan@gentoo.org, paul.walmsley@sifive.com, palmer@dabbelt.com,
aou@eecs.berkeley.edu, alex@ghiti.fr, troymitchell988@gmail.com,
guodong@riscstar.com, linux-rtc@vger.kernel.org,
devicetree@vger.kernel.org, linux-riscv@lists.infradead.org,
spacemit@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v6 2/8] mfd: simple-mfd-i2c: specify max_register
Date: Wed, 2 Jul 2025 17:26:20 +0100 [thread overview]
Message-ID: <20250702162620.GA10134@google.com> (raw)
In-Reply-To: <0219b698-2f1b-4fcd-bce7-0ba6f6895b11@riscstar.com>
On Wed, 02 Jul 2025, Alex Elder wrote:
> On 7/2/25 10:26 AM, Lee Jones wrote:
> > On Fri, 27 Jun 2025, Alex Elder wrote:
> >
> > > All devices supported by simple MFD use the same 8-bit register
> > > 8-bit value regmap configuration. There is an option available
> > > for a device to specify a custome configuration, but no existing
> > > device uses it.
> > >
> > > Lee Jones suggested modifying the simple MFD implementation to
> > > remove the generality of the full regmap configuration and add a
> > > max_register value to the simple_mfd_data structure. This can
> > > be used in the regmap configuration to limit the valid register
> > > addresses if desired. It's simpler, and covers all existing and
> > > anticipated device types.
> >
> > Woah, not like this. I wanted to make the framework _more_ flexible.
>
> OK, sorry I misunderstood. I'll send another new version today
> that does what you suggest.
No worries. Perhaps I wasn't clear enough.
--
Lee Jones [李琼斯]
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
next prev parent reply other threads:[~2025-07-02 16:26 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-27 14:22 [PATCH v6 0/8] spacemit: introduce P1 PMIC support Alex Elder
2025-06-27 14:22 ` Alex Elder
2025-06-27 14:23 ` [PATCH v6 1/8] dt-bindings: mfd: add support the SpacemiT P1 PMIC Alex Elder
2025-06-27 14:23 ` Alex Elder
2025-06-27 14:23 ` [PATCH v6 2/8] mfd: simple-mfd-i2c: specify max_register Alex Elder
2025-06-27 14:23 ` Alex Elder
2025-07-02 15:26 ` Lee Jones
2025-07-02 15:26 ` Lee Jones
2025-07-02 15:35 ` Alex Elder
2025-07-02 15:35 ` Alex Elder
2025-07-02 16:26 ` Lee Jones [this message]
2025-07-02 16:26 ` Lee Jones
2025-06-27 14:23 ` [PATCH v6 3/8] mfd: simple-mfd-i2c: add SpacemiT P1 support Alex Elder
2025-06-27 14:23 ` Alex Elder
2025-06-27 14:23 ` [PATCH v6 4/8] regulator: spacemit: support SpacemiT P1 regulators Alex Elder
2025-06-27 14:23 ` Alex Elder
2025-06-27 14:23 ` [PATCH v6 5/8] rtc: spacemit: support the SpacemiT P1 RTC Alex Elder
2025-06-27 14:23 ` Alex Elder
2025-06-27 14:23 ` [PATCH v6 6/8] riscv: dts: spacemit: enable the i2c8 adapter Alex Elder
2025-06-27 14:23 ` Alex Elder
2025-06-27 14:23 ` [PATCH v6 7/8] riscv: dts: spacemit: define fixed regulators Alex Elder
2025-06-27 14:23 ` Alex Elder
2025-06-27 14:23 ` [PATCH v6 8/8] riscv: dts: spacemit: define regulator constraints Alex Elder
2025-06-27 14:23 ` Alex Elder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250702162620.GA10134@google.com \
--to=lee@kernel.org \
--cc=alex@ghiti.fr \
--cc=alexandre.belloni@bootlin.com \
--cc=aou@eecs.berkeley.edu \
--cc=broonie@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dlan@gentoo.org \
--cc=elder@riscstar.com \
--cc=guodong@riscstar.com \
--cc=krzk+dt@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=linux-rtc@vger.kernel.org \
--cc=mat.jonczyk@o2.pl \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
--cc=robh@kernel.org \
--cc=spacemit@lists.linux.dev \
--cc=troymitchell988@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.