All of lore.kernel.org
 help / color / mirror / Atom feed
From: Simon Horman <horms@kernel.org>
To: Vivian Wang <wangruikang@iscas.ac.cn>
Cc: Andrew Lunn <andrew+netdev@lunn.ch>,
	"David S. Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
	Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>, Yixun Lan <dlan@gentoo.org>,
	Philipp Zabel <p.zabel@pengutronix.de>,
	Paul Walmsley <paul.walmsley@sifive.com>,
	Palmer Dabbelt <palmer@dabbelt.com>,
	Albert Ou <aou@eecs.berkeley.edu>,
	Alexandre Ghiti <alex@ghiti.fr>, Vivian Wang <uwu@dram.page>,
	Lukas Bulwahn <lukas.bulwahn@redhat.com>,
	Geert Uytterhoeven <geert+renesas@glider.be>,
	Parthiban Veerasooran <Parthiban.Veerasooran@microchip.com>,
	netdev@vger.kernel.org, devicetree@vger.kernel.org,
	linux-riscv@lists.infradead.org, spacemit@lists.linux.dev,
	linux-kernel@vger.kernel.org,
	Conor Dooley <conor.dooley@microchip.com>
Subject: Re: [PATCH net-next v3 0/5] Add Ethernet MAC support for SpacemiT K1
Date: Thu, 3 Jul 2025 08:23:17 +0100	[thread overview]
Message-ID: <20250703072317.GK41770@horms.kernel.org> (raw)
In-Reply-To: <20250702-net-k1-emac-v3-0-882dc55404f3@iscas.ac.cn>

On Wed, Jul 02, 2025 at 02:01:39PM +0800, Vivian Wang wrote:
> SpacemiT K1 has two gigabit Ethernet MACs with RGMII and RMII support.
> Add a driver for them, as well as the supporting devicetree and bindings
> updates.
> 
> Tested on BananaPi BPI-F3 and Milk-V Jupiter.
> 
> I would like to note that even though some bit field names superficially
> resemble that of DesignWare MAC, all other differences point to it in
> fact being a custom design.
> 
> Based on SpacemiT drivers [1].
> 
> This series depends on reset controller support [2] and DMA buses [3]
> for K1. There are some minor conflicts resulting from both touching
> k1.dtsi, but it should just both be adding nodes.
> 
> These patches can also be pulled from:
> 
> https://github.com/dramforever/linux/tree/k1/ethernet/v3
> 
> [1]: https://github.com/spacemit-com/linux-k1x
> [2]: https://lore.kernel.org/all/20250613011139.1201702-1-elder@riscstar.com
> [3]: https://lore.kernel.org/all/20250623-k1-dma-buses-rfc-wip-v1-0-c0144082061f@iscas.ac.cn
> 
> ---
> Changes in v3:
> - Refactored and simplified emac_tx_mem_map
> - Addressed other minor v2 review comments
> - Removed what was patch 3 in v2, depend on DMA buses instead
> - DT nodes in alphabetical order where appropriate
> - Link to v2: https://lore.kernel.org/r/20250618-net-k1-emac-v2-0-94f5f07227a8@iscas.ac.cn
> 
> Changes in v2:
> - dts: Put eth0 and eth1 nodes under a bus with dma-ranges
> - dts: Added Milk-V Jupiter
> - Fix typo in emac_init_hw() that broke the driver (Oops!)
> - Reformatted line lengths to under 80
> - Addressed other v1 review comments
> - Link to v1: https://lore.kernel.org/r/20250613-net-k1-emac-v1-0-cc6f9e510667@iscas.ac.cn
> 
> ---
> Vivian Wang (5):
>       dt-bindings: net: Add support for SpacemiT K1
>       net: spacemit: Add K1 Ethernet MAC
>       riscv: dts: spacemit: Add Ethernet support for K1
>       riscv: dts: spacemit: Add Ethernet support for BPI-F3
>       riscv: dts: spacemit: Add Ethernet support for Jupiter

I'm unsure on the plan for merging this.  But it seems to me that the first
two patches ought to go though net-next. But in order for patches to
proceed through net-next the entire series ought to apply on that tree - so
CI can run.

I'm not sure on the way forward.  But perhaps splitting the series in two:
the first two patches for net-next; and, the riscv patches targeted elsewhere
makes sense?

</2c>

_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv

WARNING: multiple messages have this Message-ID (diff)
From: Simon Horman <horms@kernel.org>
To: Vivian Wang <wangruikang@iscas.ac.cn>
Cc: Andrew Lunn <andrew+netdev@lunn.ch>,
	"David S. Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
	Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>, Yixun Lan <dlan@gentoo.org>,
	Philipp Zabel <p.zabel@pengutronix.de>,
	Paul Walmsley <paul.walmsley@sifive.com>,
	Palmer Dabbelt <palmer@dabbelt.com>,
	Albert Ou <aou@eecs.berkeley.edu>,
	Alexandre Ghiti <alex@ghiti.fr>, Vivian Wang <uwu@dram.page>,
	Lukas Bulwahn <lukas.bulwahn@redhat.com>,
	Geert Uytterhoeven <geert+renesas@glider.be>,
	Parthiban Veerasooran <Parthiban.Veerasooran@microchip.com>,
	netdev@vger.kernel.org, devicetree@vger.kernel.org,
	linux-riscv@lists.infradead.org, spacemit@lists.linux.dev,
	linux-kernel@vger.kernel.org,
	Conor Dooley <conor.dooley@microchip.com>
Subject: Re: [PATCH net-next v3 0/5] Add Ethernet MAC support for SpacemiT K1
Date: Thu, 3 Jul 2025 08:23:17 +0100	[thread overview]
Message-ID: <20250703072317.GK41770@horms.kernel.org> (raw)
In-Reply-To: <20250702-net-k1-emac-v3-0-882dc55404f3@iscas.ac.cn>

On Wed, Jul 02, 2025 at 02:01:39PM +0800, Vivian Wang wrote:
> SpacemiT K1 has two gigabit Ethernet MACs with RGMII and RMII support.
> Add a driver for them, as well as the supporting devicetree and bindings
> updates.
> 
> Tested on BananaPi BPI-F3 and Milk-V Jupiter.
> 
> I would like to note that even though some bit field names superficially
> resemble that of DesignWare MAC, all other differences point to it in
> fact being a custom design.
> 
> Based on SpacemiT drivers [1].
> 
> This series depends on reset controller support [2] and DMA buses [3]
> for K1. There are some minor conflicts resulting from both touching
> k1.dtsi, but it should just both be adding nodes.
> 
> These patches can also be pulled from:
> 
> https://github.com/dramforever/linux/tree/k1/ethernet/v3
> 
> [1]: https://github.com/spacemit-com/linux-k1x
> [2]: https://lore.kernel.org/all/20250613011139.1201702-1-elder@riscstar.com
> [3]: https://lore.kernel.org/all/20250623-k1-dma-buses-rfc-wip-v1-0-c0144082061f@iscas.ac.cn
> 
> ---
> Changes in v3:
> - Refactored and simplified emac_tx_mem_map
> - Addressed other minor v2 review comments
> - Removed what was patch 3 in v2, depend on DMA buses instead
> - DT nodes in alphabetical order where appropriate
> - Link to v2: https://lore.kernel.org/r/20250618-net-k1-emac-v2-0-94f5f07227a8@iscas.ac.cn
> 
> Changes in v2:
> - dts: Put eth0 and eth1 nodes under a bus with dma-ranges
> - dts: Added Milk-V Jupiter
> - Fix typo in emac_init_hw() that broke the driver (Oops!)
> - Reformatted line lengths to under 80
> - Addressed other v1 review comments
> - Link to v1: https://lore.kernel.org/r/20250613-net-k1-emac-v1-0-cc6f9e510667@iscas.ac.cn
> 
> ---
> Vivian Wang (5):
>       dt-bindings: net: Add support for SpacemiT K1
>       net: spacemit: Add K1 Ethernet MAC
>       riscv: dts: spacemit: Add Ethernet support for K1
>       riscv: dts: spacemit: Add Ethernet support for BPI-F3
>       riscv: dts: spacemit: Add Ethernet support for Jupiter

I'm unsure on the plan for merging this.  But it seems to me that the first
two patches ought to go though net-next. But in order for patches to
proceed through net-next the entire series ought to apply on that tree - so
CI can run.

I'm not sure on the way forward.  But perhaps splitting the series in two:
the first two patches for net-next; and, the riscv patches targeted elsewhere
makes sense?

</2c>

  parent reply	other threads:[~2025-07-03  7:27 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-07-02  6:01 [PATCH net-next v3 0/5] Add Ethernet MAC support for SpacemiT K1 Vivian Wang
2025-07-02  6:01 ` Vivian Wang
2025-07-02  6:01 ` [PATCH net-next v3 1/5] dt-bindings: net: Add " Vivian Wang
2025-07-02  6:01   ` Vivian Wang
2025-07-02  6:01 ` [PATCH net-next v3 2/5] net: spacemit: Add K1 Ethernet MAC Vivian Wang
2025-07-02  6:01   ` Vivian Wang
2025-07-02  7:17   ` Maxime Chevallier
2025-07-02  7:17     ` Maxime Chevallier
2025-07-02  7:41     ` Vivian Wang
2025-07-02  7:41       ` Vivian Wang
2025-07-03  7:19   ` Simon Horman
2025-07-03  7:19     ` Simon Horman
2025-07-03  7:58     ` Vivian Wang
2025-07-03  7:58       ` Vivian Wang
2025-07-02  6:01 ` [PATCH net-next v3 3/5] riscv: dts: spacemit: Add Ethernet support for K1 Vivian Wang
2025-07-02  6:01   ` Vivian Wang
2025-07-02  6:01 ` [PATCH net-next v3 4/5] riscv: dts: spacemit: Add Ethernet support for BPI-F3 Vivian Wang
2025-07-02  6:01   ` Vivian Wang
2025-07-02  6:01 ` [PATCH net-next v3 5/5] riscv: dts: spacemit: Add Ethernet support for Jupiter Vivian Wang
2025-07-02  6:01   ` Vivian Wang
2025-07-03  6:48   ` Junhui Liu
2025-07-03  6:48     ` Junhui Liu
2025-07-03  7:46     ` Vivian Wang
2025-07-03  7:46       ` Vivian Wang
2025-07-03  9:00       ` Junhui Liu
2025-07-03  9:00         ` Junhui Liu
2025-07-03  7:23 ` Simon Horman [this message]
2025-07-03  7:23   ` [PATCH net-next v3 0/5] Add Ethernet MAC support for SpacemiT K1 Simon Horman
2025-07-03  7:39   ` Vivian Wang
2025-07-03  7:39     ` Vivian Wang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250703072317.GK41770@horms.kernel.org \
    --to=horms@kernel.org \
    --cc=Parthiban.Veerasooran@microchip.com \
    --cc=alex@ghiti.fr \
    --cc=andrew+netdev@lunn.ch \
    --cc=aou@eecs.berkeley.edu \
    --cc=conor+dt@kernel.org \
    --cc=conor.dooley@microchip.com \
    --cc=davem@davemloft.net \
    --cc=devicetree@vger.kernel.org \
    --cc=dlan@gentoo.org \
    --cc=edumazet@google.com \
    --cc=geert+renesas@glider.be \
    --cc=krzk+dt@kernel.org \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-riscv@lists.infradead.org \
    --cc=lukas.bulwahn@redhat.com \
    --cc=netdev@vger.kernel.org \
    --cc=p.zabel@pengutronix.de \
    --cc=pabeni@redhat.com \
    --cc=palmer@dabbelt.com \
    --cc=paul.walmsley@sifive.com \
    --cc=robh@kernel.org \
    --cc=spacemit@lists.linux.dev \
    --cc=uwu@dram.page \
    --cc=wangruikang@iscas.ac.cn \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.