From: Jonathan Cameron <Jonathan.Cameron@huawei.com>
To: <alison.schofield@intel.com>
Cc: Davidlohr Bueso <dave@stgolabs.net>,
Dave Jiang <dave.jiang@intel.com>,
Vishal Verma <vishal.l.verma@intel.com>,
Ira Weiny <ira.weiny@intel.com>,
Dan Williams <dan.j.williams@intel.com>,
<linux-cxl@vger.kernel.org>
Subject: Re: [PATCH v2 1/4] cxl: Define a SPA->CXL HPA root decoder callback for XOR Math
Date: Thu, 3 Jul 2025 14:43:17 +0100 [thread overview]
Message-ID: <20250703144317.00000f9a@huawei.com> (raw)
In-Reply-To: <0ba61cc55f1c3a99e33594a66e470b54bd4b81ef.1751513505.git.alison.schofield@intel.com>
On Wed, 2 Jul 2025 21:03:20 -0700
alison.schofield@intel.com wrote:
> From: Alison Schofield <alison.schofield@intel.com>
>
> When DPA->SPA translation was introduced, it included a helper that
> applied the XOR maps to do the CXL HPA -> SPA translation for XOR
> region interleaves. In preparation for adding SPA->DPA address
> translation, introduce the reverse callback.
>
> The root decoder callback is defined generically and not all usages
> may be self inverting like this XOR function. Add another root decoder
> callback that is the spa_to_hpa function.
>
> Update the existing cxl_xor_hpa_to_spa() with a name that reflects
> what it does without directionality: cxl_apply_xor_maps(), a generic
> parameter: addr replaces hpa, and code comments stating that the
> function supports the translation in either direction.
>
> Signed-off-by: Alison Schofield <alison.schofield@intel.com>
Reviewed-by: Jonathan Cameron <jonathan.cameron@huawei.com>
next prev parent reply other threads:[~2025-07-03 13:43 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-03 4:03 [PATCH v2 0/4] cxl: Support Poison Inject & Clear by Region Offset alison.schofield
2025-07-03 4:03 ` [PATCH v2 1/4] cxl: Define a SPA->CXL HPA root decoder callback for XOR Math alison.schofield
2025-07-03 13:43 ` Jonathan Cameron [this message]
2025-07-03 4:03 ` [PATCH v2 2/4] cxl/region: Introduce SPA to DPA address translation alison.schofield
2025-07-03 14:23 ` Jonathan Cameron
2025-07-12 4:17 ` Alison Schofield
2025-07-03 4:03 ` [PATCH v2 3/4] cxl/core: Add locked variants of the poison inject and clear funcs alison.schofield
2025-07-03 14:25 ` Jonathan Cameron
2025-07-12 4:23 ` Alison Schofield
2025-07-03 4:03 ` [PATCH v2 4/4] cxl/region: Add inject and clear poison by region offset alison.schofield
2025-07-03 14:31 ` Jonathan Cameron
2025-07-12 4:40 ` Alison Schofield
2025-07-15 15:20 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250703144317.00000f9a@huawei.com \
--to=jonathan.cameron@huawei.com \
--cc=alison.schofield@intel.com \
--cc=dan.j.williams@intel.com \
--cc=dave.jiang@intel.com \
--cc=dave@stgolabs.net \
--cc=ira.weiny@intel.com \
--cc=linux-cxl@vger.kernel.org \
--cc=vishal.l.verma@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.