Re: [PATCH v2 4/4] cxl/region: Add inject and clear poison by region offset

[Jonathan Cameron <Jonathan.Cameron@huawei.com>]

> > > +
> > > +	rc = region_offset_to_dpa_result(cxlr, offset, &result);
> > > +	if (rc || !result.cxlmd || result.dpa == ULLONG_MAX) {
> > > +		dev_dbg(&cxlr->dev,
> > > +			"Failed to resolve DPA for region offset %#llx\n",
> > > +			offset);
> > > +
> > > +		return -EINVAL;  
> > 
> > If rc was set, preferable to return that. I'd split the condition
> > into two parts to avoid this.  
> 
> I want to dev_dbg() regardless, so how about adding the rc to dev_dbg()
> and returning like this:
> 
>         rc = region_offset_to_dpa_result(cxlr, offset, &result);
>         if (rc || !result.cxlmd || result.dpa == ULLONG_MAX) {
>                 dev_dbg(&cxlr->dev,
> -                       "Failed to resolve DPA for region offset %#llx\n",
> -                       offset);
> +                       "Failed to resolve DPA for region offset %#llx rc %d\n",
> +                       offset, rc);
>  
> -               return -EINVAL;
> +               return rc ? rc : -EINVAL;
>         }
> 
LGTM