* [PATCH] net: ipv4: fix mixed tab and space indentation in af_inet.c
@ 2025-07-04 9:10 Liangming Liu
2025-07-04 14:23 ` Simon Horman
0 siblings, 1 reply; 2+ messages in thread
From: Liangming Liu @ 2025-07-04 9:10 UTC (permalink / raw)
To: davem; +Cc: netdev, Liangming Liu
Fixes mixed use of tabs and spaces in af_inet.c to comply with
Linux kernel coding style. This change does not affect logic
or functionality.
Signed-off-by: Liangming Liu <liangming.liu@foxmail.com>
---
net/ipv4/af_inet.c | 24 ++++++++++++------------
1 file changed, 12 insertions(+), 12 deletions(-)
diff --git a/net/ipv4/af_inet.c b/net/ipv4/af_inet.c
index 76e38092cd8a..5a5aabb962d8 100644
--- a/net/ipv4/af_inet.c
+++ b/net/ipv4/af_inet.c
@@ -501,7 +501,7 @@ int __inet_bind(struct sock *sk, struct sockaddr *uaddr, int addr_len,
*/
err = -EADDRNOTAVAIL;
if (!inet_addr_valid_or_nonlocal(net, inet, addr->sin_addr.s_addr,
- chk_addr_ret))
+ chk_addr_ret))
goto out;
snum = ntohs(addr->sin_port);
@@ -1167,23 +1167,23 @@ static struct inet_protosw inetsw_array[] =
.prot = &udp_prot,
.ops = &inet_dgram_ops,
.flags = INET_PROTOSW_PERMANENT,
- },
+ },
- {
+ {
.type = SOCK_DGRAM,
.protocol = IPPROTO_ICMP,
.prot = &ping_prot,
.ops = &inet_sockraw_ops,
.flags = INET_PROTOSW_REUSE,
- },
-
- {
- .type = SOCK_RAW,
- .protocol = IPPROTO_IP, /* wild card */
- .prot = &raw_prot,
- .ops = &inet_sockraw_ops,
- .flags = INET_PROTOSW_REUSE,
- }
+ },
+
+ {
+ .type = SOCK_RAW,
+ .protocol = IPPROTO_IP, /* wild card */
+ .prot = &raw_prot,
+ .ops = &inet_sockraw_ops,
+ .flags = INET_PROTOSW_REUSE,
+ }
};
#define INETSW_ARRAY_LEN ARRAY_SIZE(inetsw_array)
--
2.43.0
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] net: ipv4: fix mixed tab and space indentation in af_inet.c
2025-07-04 9:10 [PATCH] net: ipv4: fix mixed tab and space indentation in af_inet.c Liangming Liu
@ 2025-07-04 14:23 ` Simon Horman
0 siblings, 0 replies; 2+ messages in thread
From: Simon Horman @ 2025-07-04 14:23 UTC (permalink / raw)
To: Liangming Liu; +Cc: davem, netdev
On Fri, Jul 04, 2025 at 05:10:11PM +0800, Liangming Liu wrote:
> Fixes mixed use of tabs and spaces in af_inet.c to comply with
> Linux kernel coding style. This change does not affect logic
> or functionality.
>
> Signed-off-by: Liangming Liu <liangming.liu@foxmail.com>
Hi,
Unfortunately we don't accept patches like this that
aren't part of a larger body of work.
Quoting documentation:
Clean-up patches
~~~~~~~~~~~~~~~~
Netdev discourages patches which perform simple clean-ups, which are not in
the context of other work. For example:
* Addressing ``checkpatch.pl`` warnings
* Addressing :ref:`Local variable ordering<rcs>` issues
* Conversions to device-managed APIs (``devm_`` helpers)
This is because it is felt that the churn that such changes produce comes
at a greater cost than the value of such clean-ups.
Conversely, spelling and grammar fixes are not discouraged.
See: https://www.kernel.org/doc/html/next/process/maintainer-netdev.html#clean-up-patches
--
pw-bot: cr
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2025-07-04 14:23 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-07-04 9:10 [PATCH] net: ipv4: fix mixed tab and space indentation in af_inet.c Liangming Liu
2025-07-04 14:23 ` Simon Horman
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.