[PATCH 0/2] drm/bridge: fix OF node leaks

[PATCH 0/2] drm/bridge: fix OF node leaks

[Johan Hovold]

Make sure to drop the OF node references taken when creating bridge
device when the devices are later released.

Johan


Johan Hovold (2):
  drm/bridge: fix OF node leak
  drm/bridge: ti-sn65dsi86: fix OF node leak

 drivers/gpu/drm/bridge/aux-bridge.c   | 2 ++
 drivers/gpu/drm/bridge/ti-sn65dsi86.c | 2 ++
 2 files changed, 4 insertions(+)

-- 
2.49.0

[PATCH 1/2] drm/bridge: fix OF node leak

[Johan Hovold]

Make sure to drop the OF node reference taken when creating the aux
bridge device when the device is later released.

Fixes: 6914968a0b52 ("drm/bridge: properly refcount DT nodes in aux bridge drivers")
Cc: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
Signed-off-by: Johan Hovold <johan@kernel.org>
---
 drivers/gpu/drm/bridge/aux-bridge.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/gpu/drm/bridge/aux-bridge.c b/drivers/gpu/drm/bridge/aux-bridge.c
index c179b86d208f..6642ac6819a0 100644
--- a/drivers/gpu/drm/bridge/aux-bridge.c
+++ b/drivers/gpu/drm/bridge/aux-bridge.c
@@ -17,6 +17,7 @@ static void drm_aux_bridge_release(struct device *dev)
 {
 	struct auxiliary_device *adev = to_auxiliary_dev(dev);
 
+	of_node_put(dev->of_node);
 	ida_free(&drm_aux_bridge_ida, adev->id);
 
 	kfree(adev);
@@ -64,6 +65,7 @@ int drm_aux_bridge_register(struct device *parent)
 
 	ret = auxiliary_device_init(adev);
 	if (ret) {
+		of_node_put(adev->dev.of_node);
 		ida_free(&drm_aux_bridge_ida, adev->id);
 		kfree(adev);
 		return ret;
-- 
2.49.0

[PATCH 2/2] drm/bridge: ti-sn65dsi86: fix OF node leak

[Johan Hovold]

Make sure to drop the OF node reference taken when creating the bridge
device when the device is later released.

Fixes: a1e3667a9835 ("drm/bridge: ti-sn65dsi86: Promote the AUX channel to its own sub-dev")
Cc: Douglas Anderson <dianders@chromium.org>
Signed-off-by: Johan Hovold <johan@kernel.org>
---
 drivers/gpu/drm/bridge/ti-sn65dsi86.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/gpu/drm/bridge/ti-sn65dsi86.c b/drivers/gpu/drm/bridge/ti-sn65dsi86.c
index de9c23537465..79f4d02f24cb 100644
--- a/drivers/gpu/drm/bridge/ti-sn65dsi86.c
+++ b/drivers/gpu/drm/bridge/ti-sn65dsi86.c
@@ -467,6 +467,7 @@ static void ti_sn65dsi86_aux_device_release(struct device *dev)
 {
 	struct auxiliary_device *aux = container_of(dev, struct auxiliary_device, dev);
 
+	of_node_put(dev->of_node);
 	kfree(aux);
 }
 
@@ -490,6 +491,7 @@ static int ti_sn65dsi86_add_aux_device(struct ti_sn65dsi86 *pdata,
 	device_set_of_node_from_dev(&aux->dev, dev);
 	ret = auxiliary_device_init(aux);
 	if (ret) {
+		of_node_put(aux->dev.of_node);
 		kfree(aux);
 		return ret;
 	}
-- 
2.49.0

Re: [PATCH 2/2] drm/bridge: ti-sn65dsi86: fix OF node leak

[Doug Anderson]

Hi,

On Tue, Jul 8, 2025 at 1:52 AM Johan Hovold <johan@kernel.org> wrote:
>
> Make sure to drop the OF node reference taken when creating the bridge
> device when the device is later released.
>
> Fixes: a1e3667a9835 ("drm/bridge: ti-sn65dsi86: Promote the AUX channel to its own sub-dev")
> Cc: Douglas Anderson <dianders@chromium.org>
> Signed-off-by: Johan Hovold <johan@kernel.org>
> ---
>  drivers/gpu/drm/bridge/ti-sn65dsi86.c | 2 ++
>  1 file changed, 2 insertions(+)

The patch doesn't apply to drm-misc-next, which has commit
6526b02e1020 ("drm/bridge: ti-sn65dsi86: use the auxiliary device").
Seems like you need to resubmit as a patch to the new
auxiliary_device_create() function? Do you feel that this is urgent
enough that we need a separate patch for stable?


-Doug

Re: [PATCH 2/2] drm/bridge: ti-sn65dsi86: fix OF node leak

[Johan Hovold]

On Mon, Jul 14, 2025 at 11:46:12AM -0700, Doug Anderson wrote:
> On Tue, Jul 8, 2025 at 1:52 AM Johan Hovold <johan@kernel.org> wrote:

> > Make sure to drop the OF node reference taken when creating the bridge
> > device when the device is later released.
> >
> > Fixes: a1e3667a9835 ("drm/bridge: ti-sn65dsi86: Promote the AUX channel to its own sub-dev")
> > Cc: Douglas Anderson <dianders@chromium.org>
> > Signed-off-by: Johan Hovold <johan@kernel.org>
> > ---
> >  drivers/gpu/drm/bridge/ti-sn65dsi86.c | 2 ++
> >  1 file changed, 2 insertions(+)
> 
> The patch doesn't apply to drm-misc-next, which has commit
> 6526b02e1020 ("drm/bridge: ti-sn65dsi86: use the auxiliary device").
> Seems like you need to resubmit as a patch to the new
> auxiliary_device_create() function?

I've already sent a fix for the generic implementation here:

	https://lore.kernel.org/lkml/20250708084654.15145-1-johan@kernel.org/

> Do you feel that this is urgent
> enough that we need a separate patch for stable?

No, we should be good then as I assume this bridge is typically
registered at boot and never deregistered (that's also why I left out
the stable tag).

Johan

Re: [PATCH 1/2] drm/bridge: fix OF node leak

[Johan Hovold]

On Tue, Jul 08, 2025 at 10:51:23AM +0200, Johan Hovold wrote:
> Make sure to drop the OF node reference taken when creating the aux
> bridge device when the device is later released.
> 
> Fixes: 6914968a0b52 ("drm/bridge: properly refcount DT nodes in aux bridge drivers")
> Cc: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
> Signed-off-by: Johan Hovold <johan@kernel.org>
> ---

Any chance we can get this one into 6.17-rc1?

Johan

Re: [PATCH 1/2] drm/bridge: fix OF node leak

[Dmitry Baryshkov]

On Tue, Jul 08, 2025 at 10:51:23AM +0200, Johan Hovold wrote:
> Make sure to drop the OF node reference taken when creating the aux
> bridge device when the device is later released.
> 
> Fixes: 6914968a0b52 ("drm/bridge: properly refcount DT nodes in aux bridge drivers")
> Cc: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
> Signed-off-by: Johan Hovold <johan@kernel.org>
> ---
>  drivers/gpu/drm/bridge/aux-bridge.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
PLease excuse me for the delay.

Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>




-- 
With best wishes
Dmitry

Re: (subset) [PATCH 0/2] drm/bridge: fix OF node leaks

[Dmitry Baryshkov]

On Tue, 08 Jul 2025 10:51:22 +0200, Johan Hovold wrote:
> Make sure to drop the OF node references taken when creating bridge
> device when the devices are later released.
> 
> Johan
> 
> 
> Johan Hovold (2):
>   drm/bridge: fix OF node leak
>   drm/bridge: ti-sn65dsi86: fix OF node leak
> 
> [...]

Applied to drm-misc-next-fixes, thanks!

[1/2] drm/bridge: fix OF node leak
      commit: be71ce9796c36517c677ab1d3c6691423dd0bdec

Best regards,
-- 
With best wishes
Dmitry