[PATCH 0/6] reset: bcm6345: add support for internal ephy resets on bcm63xx

[PATCH 0/6] reset: bcm6345: add support for internal ephy resets on bcm63xx

[Kyle Hendry]

bcm63xx SoCs have a register in the gpio controller that controls some
of the phy functionality. Some of the bits reset individual phys and 
need a driver to set. 

The other fields in the register configure phy power and will be set
by the network device driver. 

Kyle Hendry (6):
  reset: bcm6345: add support for bcm63xx ephy control register
  dt-bindings: reset: add compatible for bcm63xx ephy control
  dt-bindings: reset: add BCM63268 ephy reset definitions
  dt-bindings: reset: add BCM6318 ephy reset definitions
  dt-bindings: reset: add BCM6362 ephy reset definitions
  dt-bindings: reset: add BCM6328 ephy reset definitions

 .../devicetree/bindings/reset/brcm,bcm6345-reset.yaml        | 4 +++-
 drivers/reset/reset-bcm6345.c                                | 1 +
 include/dt-bindings/reset/bcm6318-reset.h                    | 5 +++++
 include/dt-bindings/reset/bcm63268-reset.h                   | 4 ++++
 include/dt-bindings/reset/bcm6328-reset.h                    | 5 +++++
 include/dt-bindings/reset/bcm6362-reset.h                    | 5 +++++
 6 files changed, 23 insertions(+), 1 deletion(-)

-- 
2.43.0

[PATCH 1/6] reset: bcm6345: add support for bcm63xx ephy control register

[Kyle Hendry]

The ephy control register on bcm63xx SoCs contain bits for
resetting individual internal phys. Use the existing bcm6345-reset
driver to set bits.

Signed-off-by: Kyle Hendry <kylehendrydev@gmail.com>
---
 drivers/reset/reset-bcm6345.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/reset/reset-bcm6345.c b/drivers/reset/reset-bcm6345.c
index aa9353439e70..56518f7bfbb3 100644
--- a/drivers/reset/reset-bcm6345.c
+++ b/drivers/reset/reset-bcm6345.c
@@ -119,6 +119,7 @@ static int bcm6345_reset_probe(struct platform_device *pdev)
 
 static const struct of_device_id bcm6345_reset_of_match[] = {
 	{ .compatible = "brcm,bcm6345-reset" },
+	{ .compatible = "brcm,bcm63xx-ephy-ctrl" },
 	{ /* sentinel */ },
 };
 
-- 
2.43.0

[PATCH 2/6] dt-bindings: reset: add compatible for bcm63xx ephy control

[Kyle Hendry]

Add compatible string for bcm63xx ephy control.

Signed-off-by: Kyle Hendry <kylehendrydev@gmail.com>
---
 .../devicetree/bindings/reset/brcm,bcm6345-reset.yaml         | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/reset/brcm,bcm6345-reset.yaml b/Documentation/devicetree/bindings/reset/brcm,bcm6345-reset.yaml
index 00150b93fca0..b8a320bb1776 100644
--- a/Documentation/devicetree/bindings/reset/brcm,bcm6345-reset.yaml
+++ b/Documentation/devicetree/bindings/reset/brcm,bcm6345-reset.yaml
@@ -13,7 +13,9 @@ maintainers:
 
 properties:
   compatible:
-    const: brcm,bcm6345-reset
+    enum:
+      - brcm,bcm6345-reset
+      - brcm,bcm63xx-ephy-ctrl
 
   reg:
     maxItems: 1
-- 
2.43.0

[PATCH 3/6] dt-bindings: reset: add BCM63268 ephy reset definitions

[Kyle Hendry]

Add definitions for resets in the ephy control register.

Signed-off-by: Kyle Hendry <kylehendrydev@gmail.com>
---
 include/dt-bindings/reset/bcm63268-reset.h | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/include/dt-bindings/reset/bcm63268-reset.h b/include/dt-bindings/reset/bcm63268-reset.h
index d87a7882782a..676a62c9777b 100644
--- a/include/dt-bindings/reset/bcm63268-reset.h
+++ b/include/dt-bindings/reset/bcm63268-reset.h
@@ -27,4 +27,8 @@
 #define BCM63268_TRST_HW	30
 #define BCM63268_TRST_POR	31
 
+#define BCM63268_RST_EPHY1 0
+#define BCM63268_RST_EPHY2 1
+#define BCM63268_RST_EPHY3 2
+
 #endif /* __DT_BINDINGS_RESET_BCM63268_H */
-- 
2.43.0

[PATCH 4/6] dt-bindings: reset: add BCM6318 ephy reset definitions

[Kyle Hendry]

Add definitions for resets in the ephy control register.

Signed-off-by: Kyle Hendry <kylehendrydev@gmail.com>
---
 include/dt-bindings/reset/bcm6318-reset.h | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/include/dt-bindings/reset/bcm6318-reset.h b/include/dt-bindings/reset/bcm6318-reset.h
index f882662505ea..33d06b45704f 100644
--- a/include/dt-bindings/reset/bcm6318-reset.h
+++ b/include/dt-bindings/reset/bcm6318-reset.h
@@ -17,4 +17,9 @@
 #define BCM6318_RST_PHYMIPS	11
 #define BCM6318_RST_HOSTMIPS	12
 
+#define BCM6318_RST_EPHY1 0
+#define BCM6318_RST_EPHY2 1
+#define BCM6318_RST_EPHY3 2
+#define BCM6318_RST_EPHY4 3
+
 #endif /* __DT_BINDINGS_RESET_BCM6318_H */
-- 
2.43.0

[PATCH 5/6] dt-bindings: reset: add BCM6362 ephy reset definitions

[Kyle Hendry]

Add definitions for resets in the ephy control register.

Signed-off-by: Kyle Hendry <kylehendrydev@gmail.com>
---
 include/dt-bindings/reset/bcm6362-reset.h | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/include/dt-bindings/reset/bcm6362-reset.h b/include/dt-bindings/reset/bcm6362-reset.h
index 7ebb0546e0ab..503fd651eba7 100644
--- a/include/dt-bindings/reset/bcm6362-reset.h
+++ b/include/dt-bindings/reset/bcm6362-reset.h
@@ -19,4 +19,9 @@
 #define BCM6362_RST_FAP		13
 #define BCM6362_RST_WLAN_UBUS	14
 
+#define BCM6362_RST_EPHY1 0
+#define BCM6362_RST_EPHY2 1
+#define BCM6362_RST_EPHY3 2
+#define BCM6362_RST_EPHY4 3
+
 #endif /* __DT_BINDINGS_RESET_BCM6362_H */
-- 
2.43.0

[PATCH 6/6] dt-bindings: reset: add BCM6328 ephy reset definitions

[Kyle Hendry]

Add definitions for resets in the ephy control register.

Signed-off-by: Kyle Hendry <kylehendrydev@gmail.com>
---
 include/dt-bindings/reset/bcm6328-reset.h | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/include/dt-bindings/reset/bcm6328-reset.h b/include/dt-bindings/reset/bcm6328-reset.h
index 0f3df87d47af..f0a164af4105 100644
--- a/include/dt-bindings/reset/bcm6328-reset.h
+++ b/include/dt-bindings/reset/bcm6328-reset.h
@@ -15,4 +15,9 @@
 #define BCM6328_RST_PCIE_EXT	9
 #define BCM6328_RST_PCIE_HARD	10
 
+#define BCM6328_RST_EPHY1 0
+#define BCM6328_RST_EPHY2 1
+#define BCM6328_RST_EPHY3 2
+#define BCM6328_RST_EPHY4 3
+
 #endif /* __DT_BINDINGS_RESET_BCM6328_H */
-- 
2.43.0

Re: [PATCH 2/6] dt-bindings: reset: add compatible for bcm63xx ephy control

[Rob Herring (Arm)]

On Tue, 08 Jul 2025 19:47:26 -0700, Kyle Hendry wrote:
> Add compatible string for bcm63xx ephy control.
> 
> Signed-off-by: Kyle Hendry <kylehendrydev@gmail.com>
> ---
>  .../devicetree/bindings/reset/brcm,bcm6345-reset.yaml         | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 

Acked-by: Rob Herring (Arm) <robh@kernel.org>

Re: [PATCH 3/6] dt-bindings: reset: add BCM63268 ephy reset definitions

[Rob Herring]

On Tue, Jul 08, 2025 at 07:47:27PM -0700, Kyle Hendry wrote:
> Add definitions for resets in the ephy control register.
> 
> Signed-off-by: Kyle Hendry <kylehendrydev@gmail.com>
> ---
>  include/dt-bindings/reset/bcm63268-reset.h | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/include/dt-bindings/reset/bcm63268-reset.h b/include/dt-bindings/reset/bcm63268-reset.h
> index d87a7882782a..676a62c9777b 100644
> --- a/include/dt-bindings/reset/bcm63268-reset.h
> +++ b/include/dt-bindings/reset/bcm63268-reset.h
> @@ -27,4 +27,8 @@
>  #define BCM63268_TRST_HW	30
>  #define BCM63268_TRST_POR	31
>  
> +#define BCM63268_RST_EPHY1 0
> +#define BCM63268_RST_EPHY2 1
> +#define BCM63268_RST_EPHY3 2

These are kind of pointless IMO. The provider is only for the EPHYs and 
your number is just index+1.

Rob

Re: [PATCH 0/6] reset: bcm6345: add support for internal ephy resets on bcm63xx

[Philipp Zabel]

On Di, 2025-07-08 at 19:47 -0700, Kyle Hendry wrote:
> bcm63xx SoCs have a register in the gpio controller that controls some
> of the phy functionality. Some of the bits reset individual phys and 
> need a driver to set. 
> 
> The other fields in the register configure phy power and will be set
> by the network device driver. 
> 
> Kyle Hendry (6):
>   reset: bcm6345: add support for bcm63xx ephy control register
>   dt-bindings: reset: add compatible for bcm63xx ephy control
[...]

Applied patches 1 and 2 to reset/next (in inverse order), thanks!

[2/6] dt-bindings: reset: add compatible for bcm63xx ephy control
      https://git.pengutronix.de/cgit/pza/linux/commit/?id=a341bcfbfa74
[1/6] reset: bcm6345: add support for bcm63xx ephy control register
      https://git.pengutronix.de/cgit/pza/linux/commit/?id=6e273caeacf0

Do you agree that patches 2-6 are not necessary?

regards
Philipp

Re: [PATCH 1/6] reset: bcm6345: add support for bcm63xx ephy control register

[Krzysztof Kozlowski]

On 09/07/2025 04:47, Kyle Hendry wrote:
> The ephy control register on bcm63xx SoCs contain bits for
> resetting individual internal phys. Use the existing bcm6345-reset
> driver to set bits.
> 
> Signed-off-by: Kyle Hendry <kylehendrydev@gmail.com>
> ---
>  drivers/reset/reset-bcm6345.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/reset/reset-bcm6345.c b/drivers/reset/reset-bcm6345.c
> index aa9353439e70..56518f7bfbb3 100644
> --- a/drivers/reset/reset-bcm6345.c
> +++ b/drivers/reset/reset-bcm6345.c
> @@ -119,6 +119,7 @@ static int bcm6345_reset_probe(struct platform_device *pdev)
>  
>  static const struct of_device_id bcm6345_reset_of_match[] = {
>  	{ .compatible = "brcm,bcm6345-reset" },
> +	{ .compatible = "brcm,bcm63xx-ephy-ctrl" },
So devices are compatible?

Best regards,
Krzysztof

Re: [PATCH 2/6] dt-bindings: reset: add compatible for bcm63xx ephy control

[Krzysztof Kozlowski]

On 09/07/2025 04:47, Kyle Hendry wrote:
> Add compatible string for bcm63xx ephy control.
> 
> Signed-off-by: Kyle Hendry <kylehendrydev@gmail.com>
> ---
>  .../devicetree/bindings/reset/brcm,bcm6345-reset.yaml         | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/reset/brcm,bcm6345-reset.yaml b/Documentation/devicetree/bindings/reset/brcm,bcm6345-reset.yaml
> index 00150b93fca0..b8a320bb1776 100644
> --- a/Documentation/devicetree/bindings/reset/brcm,bcm6345-reset.yaml
> +++ b/Documentation/devicetree/bindings/reset/brcm,bcm6345-reset.yaml
> @@ -13,7 +13,9 @@ maintainers:
>  
>  properties:
>    compatible:
> -    const: brcm,bcm6345-reset
> +    enum:
> +      - brcm,bcm6345-reset
> +      - brcm,bcm63xx-ephy-ctrl

Don't use wildcards.

Best regards,
Krzysztof