+ kexec_core-drop-redundant-pm_restore_gfp_mask-call.patch added to mm-nonmm-unstable branch

+ kexec_core-drop-redundant-pm_restore_gfp_mask-call.patch added to mm-nonmm-unstable branch

[Andrew Morton]

The patch titled
     Subject: kexec_core: Drop redundant pm_restore_gfp_mask() call
has been added to the -mm mm-nonmm-unstable branch.  Its filename is
     kexec_core-drop-redundant-pm_restore_gfp_mask-call.patch

This patch will shortly appear at
     https://git.kernel.org/pub/scm/linux/kernel/git/akpm/25-new.git/tree/patches/kexec_core-drop-redundant-pm_restore_gfp_mask-call.patch

This patch will later appear in the mm-nonmm-unstable branch at
    git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm

Before you just go and hit "reply", please:
   a) Consider who else should be cc'ed
   b) Prefer to cc a suitable mailing list as well
   c) Ideally: find the original patch on the mailing list and do a
      reply-to-all to that, adding suitable additional cc's

*** Remember to use Documentation/process/submit-checklist.rst when testing your code ***

The -mm tree is included into linux-next via the mm-everything
branch at git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm
and is updated there every 2-3 working days

------------------------------------------------------
From: "Rafael J. Wysocki" <rafael@kernel.org>
Subject: kexec_core: Drop redundant pm_restore_gfp_mask() call
Date: Thu, 10 Jul 2025 15:12:20 +0200


Drop the direct pm_restore_gfp_mask() call from the KEXEC_JUMP flow in
kernel_kexec() because it is redundant.  Namely, dpm_resume_end()
called beforehand in the same code path invokes that function and
it is sufficient to invoke it once.

Link: https://lkml.kernel.org/r/1949230.tdWV9SEqCh@rjwysocki.net
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Cc: Dave Young <dyoung@redhat.com>
Cc: Baoquan He <bhe@redhat.com>
Cc: David Woodhouse <dwmw2@infradead.org>
Cc: Mario Limonciello <mario.limonciello@amd.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---

 kernel/kexec_core.c |    1 -
 1 file changed, 1 deletion(-)

--- a/kernel/kexec_core.c~kexec_core-drop-redundant-pm_restore_gfp_mask-call
+++ a/kernel/kexec_core.c
@@ -1136,7 +1136,6 @@ int kernel_kexec(void)
  Resume_devices:
 		dpm_resume_end(PMSG_RESTORE);
  Resume_console:
-		pm_restore_gfp_mask();
 		console_resume_all();
 		thaw_processes();
  Restore_console:
_

Patches currently in -mm which might be from rafael@kernel.org are

kexec_core-drop-redundant-pm_restore_gfp_mask-call.patch

Re: + kexec_core-drop-redundant-pm_restore_gfp_mask-call.patch added to mm-nonmm-unstable branch

[Rafael J. Wysocki]

On Thu, Jul 10, 2025 at 11:53 PM Andrew Morton
<akpm@linux-foundation.org> wrote:
>
>
> The patch titled
>      Subject: kexec_core: Drop redundant pm_restore_gfp_mask() call
> has been added to the -mm mm-nonmm-unstable branch.  Its filename is
>      kexec_core-drop-redundant-pm_restore_gfp_mask-call.patch

This patch depends on

https://lore.kernel.org/linux-pm/aHCsUAhqRz5zJH2t@MiWiFi-R3L-srv/

so you need to queue up both or let me queue them up.

Thanks!

> This patch will shortly appear at
>      https://git.kernel.org/pub/scm/linux/kernel/git/akpm/25-new.git/tree/patches/kexec_core-drop-redundant-pm_restore_gfp_mask-call.patch
>
> This patch will later appear in the mm-nonmm-unstable branch at
>     git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm
>
> Before you just go and hit "reply", please:
>    a) Consider who else should be cc'ed
>    b) Prefer to cc a suitable mailing list as well
>    c) Ideally: find the original patch on the mailing list and do a
>       reply-to-all to that, adding suitable additional cc's
>
> *** Remember to use Documentation/process/submit-checklist.rst when testing your code ***
>
> The -mm tree is included into linux-next via the mm-everything
> branch at git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm
> and is updated there every 2-3 working days
>
> ------------------------------------------------------
> From: "Rafael J. Wysocki" <rafael@kernel.org>
> Subject: kexec_core: Drop redundant pm_restore_gfp_mask() call
> Date: Thu, 10 Jul 2025 15:12:20 +0200
>
>
> Drop the direct pm_restore_gfp_mask() call from the KEXEC_JUMP flow in
> kernel_kexec() because it is redundant.  Namely, dpm_resume_end()
> called beforehand in the same code path invokes that function and
> it is sufficient to invoke it once.
>
> Link: https://lkml.kernel.org/r/1949230.tdWV9SEqCh@rjwysocki.net
> Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
> Cc: Dave Young <dyoung@redhat.com>
> Cc: Baoquan He <bhe@redhat.com>
> Cc: David Woodhouse <dwmw2@infradead.org>
> Cc: Mario Limonciello <mario.limonciello@amd.com>
> Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
> ---
>
>  kernel/kexec_core.c |    1 -
>  1 file changed, 1 deletion(-)
>
> --- a/kernel/kexec_core.c~kexec_core-drop-redundant-pm_restore_gfp_mask-call
> +++ a/kernel/kexec_core.c
> @@ -1136,7 +1136,6 @@ int kernel_kexec(void)
>   Resume_devices:
>                 dpm_resume_end(PMSG_RESTORE);
>   Resume_console:
> -               pm_restore_gfp_mask();
>                 console_resume_all();
>                 thaw_processes();
>   Restore_console:
> _
>
> Patches currently in -mm which might be from rafael@kernel.org are
>
> kexec_core-drop-redundant-pm_restore_gfp_mask-call.patch
>

Re: + kexec_core-drop-redundant-pm_restore_gfp_mask-call.patch added to mm-nonmm-unstable branch

[Andrew Morton]

On Fri, 11 Jul 2025 10:35:31 +0200 "Rafael J. Wysocki" <rafael@kernel.org> wrote:

> On Thu, Jul 10, 2025 at 11:53 PM Andrew Morton
> <akpm@linux-foundation.org> wrote:
> >
> >
> > The patch titled
> >      Subject: kexec_core: Drop redundant pm_restore_gfp_mask() call
> > has been added to the -mm mm-nonmm-unstable branch.  Its filename is
> >      kexec_core-drop-redundant-pm_restore_gfp_mask-call.patch
> 
> This patch depends on
> 
> https://lore.kernel.org/linux-pm/aHCsUAhqRz5zJH2t@MiWiFi-R3L-srv/

I noticed ;)

> so you need to queue up both or let me queue them up.

Well what's your preference?  This was unknowable from the emails as-sent...

Re: + kexec_core-drop-redundant-pm_restore_gfp_mask-call.patch added to mm-nonmm-unstable branch

[Rafael J. Wysocki]

On Sat, Jul 12, 2025 at 1:06 AM Andrew Morton <akpm@linux-foundation.org> wrote:
>
> On Fri, 11 Jul 2025 10:35:31 +0200 "Rafael J. Wysocki" <rafael@kernel.org> wrote:
>
> > On Thu, Jul 10, 2025 at 11:53 PM Andrew Morton
> > <akpm@linux-foundation.org> wrote:
> > >
> > >
> > > The patch titled
> > >      Subject: kexec_core: Drop redundant pm_restore_gfp_mask() call
> > > has been added to the -mm mm-nonmm-unstable branch.  Its filename is
> > >      kexec_core-drop-redundant-pm_restore_gfp_mask-call.patch
> >
> > This patch depends on
> >
> > https://lore.kernel.org/linux-pm/aHCsUAhqRz5zJH2t@MiWiFi-R3L-srv/
>
> I noticed ;)
>
> > so you need to queue up both or let me queue them up.
>
> Well what's your preference?  This was unknowable from the emails as-sent...

Yes, sorry.

I can take care of these patches.  They should not clash with other
changes in kernel_kexec() and they are related to PM.

Re: + kexec_core-drop-redundant-pm_restore_gfp_mask-call.patch added to mm-nonmm-unstable branch

[Andrew Morton]

On Sat, 12 Jul 2025 10:15:14 +0200 "Rafael J. Wysocki" <rafael@kernel.org> wrote:

> On Sat, Jul 12, 2025 at 1:06 AM Andrew Morton <akpm@linux-foundation.org> wrote:
> >
> > On Fri, 11 Jul 2025 10:35:31 +0200 "Rafael J. Wysocki" <rafael@kernel.org> wrote:
> >
> > > On Thu, Jul 10, 2025 at 11:53 PM Andrew Morton
> > > <akpm@linux-foundation.org> wrote:
> > > >
> > > >
> > > > The patch titled
> > > >      Subject: kexec_core: Drop redundant pm_restore_gfp_mask() call
> > > > has been added to the -mm mm-nonmm-unstable branch.  Its filename is
> > > >      kexec_core-drop-redundant-pm_restore_gfp_mask-call.patch
> > >
> > > This patch depends on
> > >
> > > https://lore.kernel.org/linux-pm/aHCsUAhqRz5zJH2t@MiWiFi-R3L-srv/
> >
> > I noticed ;)
> >
> > > so you need to queue up both or let me queue them up.
> >
> > Well what's your preference?  This was unknowable from the emails as-sent...
> 
> Yes, sorry.
> 
> I can take care of these patches.  They should not clash with other
> changes in kernel_kexec() and they are related to PM.

No probs, I removed both from mm.git.