* [PATCH v2] tools: bootconfig: Regex enclosed with quotes to make syntax highlight proper
@ 2025-07-09 2:57 Bhaskar Chowdhury
2025-07-14 1:21 ` Masami Hiramatsu
0 siblings, 1 reply; 2+ messages in thread
From: Bhaskar Chowdhury @ 2025-07-09 2:57 UTC (permalink / raw)
To: mhiramat, linux-kernel, linux-trace-kernel; +Cc: Bhaskar Chowdhury
As suggested, changed the square brackets escaping to quote the whole Regex
class.
Signed-off-by: Bhaskar Chowdhury <unixbhaskar@gmail.com>
---
Changes to V2 from V1:
Surround the Regex class with single quotations.
tools/bootconfig/test-bootconfig.sh | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/tools/bootconfig/test-bootconfig.sh b/tools/bootconfig/test-bootconfig.sh
index a2c484c243f5..32401bf61340 100755
--- a/tools/bootconfig/test-bootconfig.sh
+++ b/tools/bootconfig/test-bootconfig.sh
@@ -167,8 +167,8 @@ echo > $INITRD
xpass $BOOTCONF -a $TEMPCONF $INITRD
$BOOTCONF $INITRD > $OUTFILE
-xfail grep -q val[[:space:]] $OUTFILE
-xpass grep -q val2[[:space:]] $OUTFILE
+xfail grep -q 'val[[:space:]]' $OUTFILE
+xpass grep -q 'val2[[:space:]]' $OUTFILE
echo "=== expected failure cases ==="
for i in samples/bad-* ; do
--
2.49.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v2] tools: bootconfig: Regex enclosed with quotes to make syntax highlight proper
2025-07-09 2:57 [PATCH v2] tools: bootconfig: Regex enclosed with quotes to make syntax highlight proper Bhaskar Chowdhury
@ 2025-07-14 1:21 ` Masami Hiramatsu
0 siblings, 0 replies; 2+ messages in thread
From: Masami Hiramatsu @ 2025-07-14 1:21 UTC (permalink / raw)
To: Bhaskar Chowdhury; +Cc: linux-kernel, linux-trace-kernel
On Wed, 9 Jul 2025 08:27:59 +0530
Bhaskar Chowdhury <unixbhaskar@gmail.com> wrote:
> As suggested, changed the square brackets escaping to quote the whole Regex
> class.
>
Yeah, let me pick it.
Thanks,
> Signed-off-by: Bhaskar Chowdhury <unixbhaskar@gmail.com>
> ---
> Changes to V2 from V1:
> Surround the Regex class with single quotations.
>
> tools/bootconfig/test-bootconfig.sh | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/tools/bootconfig/test-bootconfig.sh b/tools/bootconfig/test-bootconfig.sh
> index a2c484c243f5..32401bf61340 100755
> --- a/tools/bootconfig/test-bootconfig.sh
> +++ b/tools/bootconfig/test-bootconfig.sh
> @@ -167,8 +167,8 @@ echo > $INITRD
>
> xpass $BOOTCONF -a $TEMPCONF $INITRD
> $BOOTCONF $INITRD > $OUTFILE
> -xfail grep -q val[[:space:]] $OUTFILE
> -xpass grep -q val2[[:space:]] $OUTFILE
> +xfail grep -q 'val[[:space:]]' $OUTFILE
> +xpass grep -q 'val2[[:space:]]' $OUTFILE
>
> echo "=== expected failure cases ==="
> for i in samples/bad-* ; do
> --
> 2.49.1
>
--
Masami Hiramatsu (Google) <mhiramat@kernel.org>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2025-07-14 1:21 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-07-09 2:57 [PATCH v2] tools: bootconfig: Regex enclosed with quotes to make syntax highlight proper Bhaskar Chowdhury
2025-07-14 1:21 ` Masami Hiramatsu
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.