[PATCH 1/2] samples/kobject: fix path comment

[PATCH 1/2] samples/kobject: fix path comment

[Meng Shao Liu]

The introductory comment still says the example creates
/sys/kernel/kobject-example, but the code actually creates
/sys/kernel/kobject_example.

Update both comments to reflect the actual sysfs paths. Also,
fix "tree"->"three" typo in kset-example.c.

Signed-off-by: Meng Shao Liu <sau525@gmail.com>
---
 samples/kobject/kobject-example.c | 2 +-
 samples/kobject/kset-example.c    | 4 ++--
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/samples/kobject/kobject-example.c b/samples/kobject/kobject-example.c
index c9c3db197..e6d7fc18e 100644
--- a/samples/kobject/kobject-example.c
+++ b/samples/kobject/kobject-example.c
@@ -13,7 +13,7 @@
 
 /*
  * This module shows how to create a simple subdirectory in sysfs called
- * /sys/kernel/kobject-example  In that directory, 3 files are created:
+ * /sys/kernel/kobject_example  In that directory, 3 files are created:
  * "foo", "baz", and "bar".  If an integer is written to these files, it can be
  * later read out of it.
  */
diff --git a/samples/kobject/kset-example.c b/samples/kobject/kset-example.c
index 552d7e363..579ce1502 100644
--- a/samples/kobject/kset-example.c
+++ b/samples/kobject/kset-example.c
@@ -14,8 +14,8 @@
 
 /*
  * This module shows how to create a kset in sysfs called
- * /sys/kernel/kset-example
- * Then tree kobjects are created and assigned to this kset, "foo", "baz",
+ * /sys/kernel/kset_example
+ * Then three kobjects are created and assigned to this kset, "foo", "baz",
  * and "bar".  In those kobjects, attributes of the same name are also
  * created and if an integer is written to these files, it can be later
  * read out of it.
-- 
2.43.0

[PATCH 2/2] samples/kobject: make attribute_group const

[Meng Shao Liu]

The attr_group structures are allocated once and never modified at
runtime.  Also to match the const‑qualified parameter of
sysfs_create_group().

Signed-off-by: Meng Shao Liu <sau525@gmail.com>
---
 samples/kobject/kobject-example.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/samples/kobject/kobject-example.c b/samples/kobject/kobject-example.c
index e6d7fc18e..36d87ca0b 100644
--- a/samples/kobject/kobject-example.c
+++ b/samples/kobject/kobject-example.c
@@ -102,7 +102,7 @@ static struct attribute *attrs[] = {
  * created for the attributes with the directory being the name of the
  * attribute group.
  */
-static struct attribute_group attr_group = {
+static const struct attribute_group attr_group = {
 	.attrs = attrs,
 };
 
-- 
2.43.0

Re: [PATCH 2/2] samples/kobject: make attribute_group const

[Greg KH]

On Wed, Jul 16, 2025 at 11:07:34AM +0800, Meng Shao Liu wrote:
> The attr_group structures are allocated once and never modified at
> runtime.  Also to match the const‑qualified parameter of
> sysfs_create_group().
> 
> Signed-off-by: Meng Shao Liu <sau525@gmail.com>
> ---
>  samples/kobject/kobject-example.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/samples/kobject/kobject-example.c b/samples/kobject/kobject-example.c
> index e6d7fc18e..36d87ca0b 100644
> --- a/samples/kobject/kobject-example.c
> +++ b/samples/kobject/kobject-example.c
> @@ -102,7 +102,7 @@ static struct attribute *attrs[] = {
>   * created for the attributes with the directory being the name of the
>   * attribute group.
>   */
> -static struct attribute_group attr_group = {
> +static const struct attribute_group attr_group = {
>  	.attrs = attrs,
>  };
>  
> -- 
> 2.43.0
> 

Hi,

This is the friendly patch-bot of Greg Kroah-Hartman.  You have sent him
a patch that has triggered this response.  He used to manually respond
to these common problems, but in order to save his sanity (he kept
writing the same thing over and over, yet to different people), I was
created.  Hopefully you will not take offence and will fix the problem
in your patch and resubmit it so that it can be accepted into the Linux
kernel tree.

You are receiving this message because of the following common error(s)
as indicated below:

- This looks like a new version of a previously submitted patch, but you
  did not list below the --- line any changes from the previous version.
  Please read the section entitled "The canonical patch format" in the
  kernel file, Documentation/process/submitting-patches.rst for what
  needs to be done here to properly describe this.

If you wish to discuss this problem further, or you have questions about
how to resolve this issue, please feel free to respond to this email and
Greg will reply once he has dug out from the pending patches received
from other developers.

thanks,

greg k-h's patch email bot

Re: [PATCH 1/2] samples/kobject: fix path comment

[Greg KH]

On Wed, Jul 16, 2025 at 11:07:33AM +0800, Meng Shao Liu wrote:
> The introductory comment still says the example creates
> /sys/kernel/kobject-example, but the code actually creates
> /sys/kernel/kobject_example.
> 
> Update both comments to reflect the actual sysfs paths. Also,
> fix "tree"->"three" typo in kset-example.c.
> 
> Signed-off-by: Meng Shao Liu <sau525@gmail.com>
> ---
>  samples/kobject/kobject-example.c | 2 +-
>  samples/kobject/kset-example.c    | 4 ++--
>  2 files changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/samples/kobject/kobject-example.c b/samples/kobject/kobject-example.c
> index c9c3db197..e6d7fc18e 100644
> --- a/samples/kobject/kobject-example.c
> +++ b/samples/kobject/kobject-example.c
> @@ -13,7 +13,7 @@
>  
>  /*
>   * This module shows how to create a simple subdirectory in sysfs called
> - * /sys/kernel/kobject-example  In that directory, 3 files are created:
> + * /sys/kernel/kobject_example  In that directory, 3 files are created:
>   * "foo", "baz", and "bar".  If an integer is written to these files, it can be
>   * later read out of it.
>   */
> diff --git a/samples/kobject/kset-example.c b/samples/kobject/kset-example.c
> index 552d7e363..579ce1502 100644
> --- a/samples/kobject/kset-example.c
> +++ b/samples/kobject/kset-example.c
> @@ -14,8 +14,8 @@
>  
>  /*
>   * This module shows how to create a kset in sysfs called
> - * /sys/kernel/kset-example
> - * Then tree kobjects are created and assigned to this kset, "foo", "baz",
> + * /sys/kernel/kset_example
> + * Then three kobjects are created and assigned to this kset, "foo", "baz",
>   * and "bar".  In those kobjects, attributes of the same name are also
>   * created and if an integer is written to these files, it can be later
>   * read out of it.
> -- 
> 2.43.0
> 

Hi,

This is the friendly patch-bot of Greg Kroah-Hartman.  You have sent him
a patch that has triggered this response.  He used to manually respond
to these common problems, but in order to save his sanity (he kept
writing the same thing over and over, yet to different people), I was
created.  Hopefully you will not take offence and will fix the problem
in your patch and resubmit it so that it can be accepted into the Linux
kernel tree.

You are receiving this message because of the following common error(s)
as indicated below:

- This looks like a new version of a previously submitted patch, but you
  did not list below the --- line any changes from the previous version.
  Please read the section entitled "The canonical patch format" in the
  kernel file, Documentation/process/submitting-patches.rst for what
  needs to be done here to properly describe this.

If you wish to discuss this problem further, or you have questions about
how to resolve this issue, please feel free to respond to this email and
Greg will reply once he has dug out from the pending patches received
from other developers.

thanks,

greg k-h's patch email bot

[PATCH 2/2] samples/kobject: make attribute_group const

[Meng-Shao.Liu]

The attr_group structures are allocated once and never modified at
runtime.  Also to match the const‑qualified parameter of
sysfs_create_group().

No functional change.

Signed-off-by: Meng-Shao.Liu <sau525@gmail.com>
---
 samples/kobject/kobject-example.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/samples/kobject/kobject-example.c b/samples/kobject/kobject-example.c
index e6d7fc18e..36d87ca0b 100644
--- a/samples/kobject/kobject-example.c
+++ b/samples/kobject/kobject-example.c
@@ -102,7 +102,7 @@ static struct attribute *attrs[] = {
  * created for the attributes with the directory being the name of the
  * attribute group.
  */
-static struct attribute_group attr_group = {
+static const struct attribute_group attr_group = {
 	.attrs = attrs,
 };
 
-- 
2.43.0

Re: [PATCH 2/2] samples/kobject: make attribute_group const

[Greg KH]

On Tue, Jul 15, 2025 at 10:30:35PM +0800, Meng-Shao.Liu wrote:
> The attr_group structures are allocated once and never modified at
> runtime.  Also to match the const‑qualified parameter of
> sysfs_create_group().
> 
> No functional change.

This line isn't needed, as there is a functional change, it moves it
into read-only memory, right?

thanks,

greg k-h