* [PATCH] riscv: dts: starfive: jh7110-common: add status power led node
@ 2025-07-16 4:04 ` E Shattow
0 siblings, 0 replies; 6+ messages in thread
From: E Shattow @ 2025-07-16 4:04 UTC (permalink / raw)
To: Emil Renner Berthing, Conor Dooley, Rob Herring,
Krzysztof Kozlowski, Paul Walmsley, Palmer Dabbelt, Albert Ou,
Alexandre Ghiti
Cc: E Shattow, linux-riscv, devicetree, linux-kernel
Add status power led node for StarFive VisionFive2 and variant boards.
Signed-off-by: E Shattow <e@freeshell.de>
---
arch/riscv/boot/dts/starfive/jh7110-common.dtsi | 9 +++++++++
1 file changed, 9 insertions(+)
diff --git a/arch/riscv/boot/dts/starfive/jh7110-common.dtsi b/arch/riscv/boot/dts/starfive/jh7110-common.dtsi
index 4baeb981d4df..2eaf01775ef5 100644
--- a/arch/riscv/boot/dts/starfive/jh7110-common.dtsi
+++ b/arch/riscv/boot/dts/starfive/jh7110-common.dtsi
@@ -8,6 +8,7 @@
#include "jh7110.dtsi"
#include "jh7110-pinfunc.h"
#include <dt-bindings/gpio/gpio.h>
+#include <dt-bindings/leds/common.h>
#include <dt-bindings/pinctrl/starfive,jh7110-pinctrl.h>
/ {
@@ -38,6 +39,14 @@ gpio-restart {
priority = <224>;
};
+ leds {
+ compatible = "gpio-leds";
+
+ led_status_power: led-0 {
+ gpios = <&aongpio 3 GPIO_ACTIVE_HIGH>;
+ };
+ };
+
pwmdac_codec: audio-codec {
compatible = "linux,spdif-dit";
#sound-dai-cells = <0>;
base-commit: 155a3c003e555a7300d156a5252c004c392ec6b0
--
2.50.0
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
^ permalink raw reply related [flat|nested] 6+ messages in thread* [PATCH] riscv: dts: starfive: jh7110-common: add status power led node
@ 2025-07-16 4:04 ` E Shattow
0 siblings, 0 replies; 6+ messages in thread
From: E Shattow @ 2025-07-16 4:04 UTC (permalink / raw)
To: Emil Renner Berthing, Conor Dooley, Rob Herring,
Krzysztof Kozlowski, Paul Walmsley, Palmer Dabbelt, Albert Ou,
Alexandre Ghiti
Cc: E Shattow, linux-riscv, devicetree, linux-kernel
Add status power led node for StarFive VisionFive2 and variant boards.
Signed-off-by: E Shattow <e@freeshell.de>
---
arch/riscv/boot/dts/starfive/jh7110-common.dtsi | 9 +++++++++
1 file changed, 9 insertions(+)
diff --git a/arch/riscv/boot/dts/starfive/jh7110-common.dtsi b/arch/riscv/boot/dts/starfive/jh7110-common.dtsi
index 4baeb981d4df..2eaf01775ef5 100644
--- a/arch/riscv/boot/dts/starfive/jh7110-common.dtsi
+++ b/arch/riscv/boot/dts/starfive/jh7110-common.dtsi
@@ -8,6 +8,7 @@
#include "jh7110.dtsi"
#include "jh7110-pinfunc.h"
#include <dt-bindings/gpio/gpio.h>
+#include <dt-bindings/leds/common.h>
#include <dt-bindings/pinctrl/starfive,jh7110-pinctrl.h>
/ {
@@ -38,6 +39,14 @@ gpio-restart {
priority = <224>;
};
+ leds {
+ compatible = "gpio-leds";
+
+ led_status_power: led-0 {
+ gpios = <&aongpio 3 GPIO_ACTIVE_HIGH>;
+ };
+ };
+
pwmdac_codec: audio-codec {
compatible = "linux,spdif-dit";
#sound-dai-cells = <0>;
base-commit: 155a3c003e555a7300d156a5252c004c392ec6b0
--
2.50.0
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH] riscv: dts: starfive: jh7110-common: add status power led node
2025-07-16 4:04 ` E Shattow
@ 2025-07-16 15:28 ` Conor Dooley
-1 siblings, 0 replies; 6+ messages in thread
From: Conor Dooley @ 2025-07-16 15:28 UTC (permalink / raw)
To: E Shattow
Cc: Emil Renner Berthing, Rob Herring, Krzysztof Kozlowski,
Paul Walmsley, Palmer Dabbelt, Albert Ou, Alexandre Ghiti,
linux-riscv, devicetree, linux-kernel
[-- Attachment #1.1: Type: text/plain, Size: 1269 bytes --]
On Tue, Jul 15, 2025 at 09:04:54PM -0700, E Shattow wrote:
> Add status power led node for StarFive VisionFive2 and variant boards.
>
> Signed-off-by: E Shattow <e@freeshell.de>
Again, I'll grab this too but it may be too late for 6.17.
> ---
> arch/riscv/boot/dts/starfive/jh7110-common.dtsi | 9 +++++++++
> 1 file changed, 9 insertions(+)
>
> diff --git a/arch/riscv/boot/dts/starfive/jh7110-common.dtsi b/arch/riscv/boot/dts/starfive/jh7110-common.dtsi
> index 4baeb981d4df..2eaf01775ef5 100644
> --- a/arch/riscv/boot/dts/starfive/jh7110-common.dtsi
> +++ b/arch/riscv/boot/dts/starfive/jh7110-common.dtsi
> @@ -8,6 +8,7 @@
> #include "jh7110.dtsi"
> #include "jh7110-pinfunc.h"
> #include <dt-bindings/gpio/gpio.h>
> +#include <dt-bindings/leds/common.h>
> #include <dt-bindings/pinctrl/starfive,jh7110-pinctrl.h>
>
> / {
> @@ -38,6 +39,14 @@ gpio-restart {
> priority = <224>;
> };
>
> + leds {
> + compatible = "gpio-leds";
> +
> + led_status_power: led-0 {
> + gpios = <&aongpio 3 GPIO_ACTIVE_HIGH>;
> + };
> + };
> +
> pwmdac_codec: audio-codec {
> compatible = "linux,spdif-dit";
> #sound-dai-cells = <0>;
>
> base-commit: 155a3c003e555a7300d156a5252c004c392ec6b0
> --
> 2.50.0
>
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
[-- Attachment #2: Type: text/plain, Size: 161 bytes --]
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] riscv: dts: starfive: jh7110-common: add status power led node
@ 2025-07-16 15:28 ` Conor Dooley
0 siblings, 0 replies; 6+ messages in thread
From: Conor Dooley @ 2025-07-16 15:28 UTC (permalink / raw)
To: E Shattow
Cc: Emil Renner Berthing, Rob Herring, Krzysztof Kozlowski,
Paul Walmsley, Palmer Dabbelt, Albert Ou, Alexandre Ghiti,
linux-riscv, devicetree, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 1269 bytes --]
On Tue, Jul 15, 2025 at 09:04:54PM -0700, E Shattow wrote:
> Add status power led node for StarFive VisionFive2 and variant boards.
>
> Signed-off-by: E Shattow <e@freeshell.de>
Again, I'll grab this too but it may be too late for 6.17.
> ---
> arch/riscv/boot/dts/starfive/jh7110-common.dtsi | 9 +++++++++
> 1 file changed, 9 insertions(+)
>
> diff --git a/arch/riscv/boot/dts/starfive/jh7110-common.dtsi b/arch/riscv/boot/dts/starfive/jh7110-common.dtsi
> index 4baeb981d4df..2eaf01775ef5 100644
> --- a/arch/riscv/boot/dts/starfive/jh7110-common.dtsi
> +++ b/arch/riscv/boot/dts/starfive/jh7110-common.dtsi
> @@ -8,6 +8,7 @@
> #include "jh7110.dtsi"
> #include "jh7110-pinfunc.h"
> #include <dt-bindings/gpio/gpio.h>
> +#include <dt-bindings/leds/common.h>
> #include <dt-bindings/pinctrl/starfive,jh7110-pinctrl.h>
>
> / {
> @@ -38,6 +39,14 @@ gpio-restart {
> priority = <224>;
> };
>
> + leds {
> + compatible = "gpio-leds";
> +
> + led_status_power: led-0 {
> + gpios = <&aongpio 3 GPIO_ACTIVE_HIGH>;
> + };
> + };
> +
> pwmdac_codec: audio-codec {
> compatible = "linux,spdif-dit";
> #sound-dai-cells = <0>;
>
> base-commit: 155a3c003e555a7300d156a5252c004c392ec6b0
> --
> 2.50.0
>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] riscv: dts: starfive: jh7110-common: add status power led node
2025-07-16 15:28 ` Conor Dooley
@ 2025-07-16 17:14 ` E Shattow
-1 siblings, 0 replies; 6+ messages in thread
From: E Shattow @ 2025-07-16 17:14 UTC (permalink / raw)
To: Conor Dooley
Cc: Emil Renner Berthing, Rob Herring, Krzysztof Kozlowski,
Paul Walmsley, Palmer Dabbelt, Albert Ou, Alexandre Ghiti,
linux-riscv, devicetree, linux-kernel
On 7/16/25 08:28, Conor Dooley wrote:
> On Tue, Jul 15, 2025 at 09:04:54PM -0700, E Shattow wrote:
>> Add status power led node for StarFive VisionFive2 and variant boards.
>>
>> Signed-off-by: E Shattow <e@freeshell.de>
>
> Again, I'll grab this too but it may be too late for 6.17.
>
>> ---
>> arch/riscv/boot/dts/starfive/jh7110-common.dtsi | 9 +++++++++
>> 1 file changed, 9 insertions(+)
>>
>> diff --git a/arch/riscv/boot/dts/starfive/jh7110-common.dtsi b/arch/riscv/boot/dts/starfive/jh7110-common.dtsi
>> index 4baeb981d4df..2eaf01775ef5 100644
>> --- a/arch/riscv/boot/dts/starfive/jh7110-common.dtsi
>> +++ b/arch/riscv/boot/dts/starfive/jh7110-common.dtsi
>> @@ -8,6 +8,7 @@
>> #include "jh7110.dtsi"
>> #include "jh7110-pinfunc.h"
>> #include <dt-bindings/gpio/gpio.h>
>> +#include <dt-bindings/leds/common.h>
>> #include <dt-bindings/pinctrl/starfive,jh7110-pinctrl.h>
>>
>> / {
>> @@ -38,6 +39,14 @@ gpio-restart {
>> priority = <224>;
>> };
>>
>> + leds {
>> + compatible = "gpio-leds";
>> +
>> + led_status_power: led-0 {
>> + gpios = <&aongpio 3 GPIO_ACTIVE_HIGH>;
>> + };
>> + };
>> +
>> pwmdac_codec: audio-codec {
>> compatible = "linux,spdif-dit";
>> #sound-dai-cells = <0>;
>>
>> base-commit: 155a3c003e555a7300d156a5252c004c392ec6b0
>> --
>> 2.50.0
>>
Ok sounds good to me. This is common on all JH7110 boards, but am not
sure if it is connected to anything on DeepComputing Framework 13 V01.
LED color varies yet there is an LED connected this way on variants I
could find a published schematic for:
- Milk-V Mars
- Pine64 Star64
- StarFive VisionFive2 1.2a
- StarFive VisionFive2 1.3b
Discussion about the OrangePi RV dts shows this to have the same
connection to an LED. I am putting together patches for adding Milk-V
Mars CM and Milk-V Mars CM Lite, tested successfully and listed on
schematics as well. Some early revision developer sample board
schematics for some of the above do not list RGPIO3 so assumed n/c and
no problem there.
If anyone out there can link to the FML13V01 schematic or confirm this
change does not break for users I'd appreciate that, for any follow-up
that might be needed per-board.
-E
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] riscv: dts: starfive: jh7110-common: add status power led node
@ 2025-07-16 17:14 ` E Shattow
0 siblings, 0 replies; 6+ messages in thread
From: E Shattow @ 2025-07-16 17:14 UTC (permalink / raw)
To: Conor Dooley
Cc: Emil Renner Berthing, Rob Herring, Krzysztof Kozlowski,
Paul Walmsley, Palmer Dabbelt, Albert Ou, Alexandre Ghiti,
linux-riscv, devicetree, linux-kernel
On 7/16/25 08:28, Conor Dooley wrote:
> On Tue, Jul 15, 2025 at 09:04:54PM -0700, E Shattow wrote:
>> Add status power led node for StarFive VisionFive2 and variant boards.
>>
>> Signed-off-by: E Shattow <e@freeshell.de>
>
> Again, I'll grab this too but it may be too late for 6.17.
>
>> ---
>> arch/riscv/boot/dts/starfive/jh7110-common.dtsi | 9 +++++++++
>> 1 file changed, 9 insertions(+)
>>
>> diff --git a/arch/riscv/boot/dts/starfive/jh7110-common.dtsi b/arch/riscv/boot/dts/starfive/jh7110-common.dtsi
>> index 4baeb981d4df..2eaf01775ef5 100644
>> --- a/arch/riscv/boot/dts/starfive/jh7110-common.dtsi
>> +++ b/arch/riscv/boot/dts/starfive/jh7110-common.dtsi
>> @@ -8,6 +8,7 @@
>> #include "jh7110.dtsi"
>> #include "jh7110-pinfunc.h"
>> #include <dt-bindings/gpio/gpio.h>
>> +#include <dt-bindings/leds/common.h>
>> #include <dt-bindings/pinctrl/starfive,jh7110-pinctrl.h>
>>
>> / {
>> @@ -38,6 +39,14 @@ gpio-restart {
>> priority = <224>;
>> };
>>
>> + leds {
>> + compatible = "gpio-leds";
>> +
>> + led_status_power: led-0 {
>> + gpios = <&aongpio 3 GPIO_ACTIVE_HIGH>;
>> + };
>> + };
>> +
>> pwmdac_codec: audio-codec {
>> compatible = "linux,spdif-dit";
>> #sound-dai-cells = <0>;
>>
>> base-commit: 155a3c003e555a7300d156a5252c004c392ec6b0
>> --
>> 2.50.0
>>
Ok sounds good to me. This is common on all JH7110 boards, but am not
sure if it is connected to anything on DeepComputing Framework 13 V01.
LED color varies yet there is an LED connected this way on variants I
could find a published schematic for:
- Milk-V Mars
- Pine64 Star64
- StarFive VisionFive2 1.2a
- StarFive VisionFive2 1.3b
Discussion about the OrangePi RV dts shows this to have the same
connection to an LED. I am putting together patches for adding Milk-V
Mars CM and Milk-V Mars CM Lite, tested successfully and listed on
schematics as well. Some early revision developer sample board
schematics for some of the above do not list RGPIO3 so assumed n/c and
no problem there.
If anyone out there can link to the FML13V01 schematic or confirm this
change does not break for users I'd appreciate that, for any follow-up
that might be needed per-board.
-E
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2025-07-16 17:14 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-07-16 4:04 [PATCH] riscv: dts: starfive: jh7110-common: add status power led node E Shattow
2025-07-16 4:04 ` E Shattow
2025-07-16 15:28 ` Conor Dooley
2025-07-16 15:28 ` Conor Dooley
2025-07-16 17:14 ` E Shattow
2025-07-16 17:14 ` E Shattow
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.