From: Jakub Kicinski <kuba@kernel.org>
To: Parvathi Pudi <parvathi@couthit.com>
Cc: Vignesh Raghavendra <vigneshr@ti.com>, praneeth <praneeth@ti.com>,
edumazet <edumazet@google.com>, glaroque <glaroque@baylibre.com>,
pmohan <pmohan@couthit.com>, diogo ivo <diogo.ivo@siemens.com>,
robh <robh@kernel.org>,
javier carrasco cruz <javier.carrasco.cruz@gmail.com>,
saikrishnag <saikrishnag@marvell.com>,
m-karicheri2 <m-karicheri2@ti.com>,
jacob e keller <jacob.e.keller@intel.com>,
pabeni <pabeni@redhat.com>,
richardcochran <richardcochran@gmail.com>,
devicetree <devicetree@vger.kernel.org>,
conor+dt <conor+dt@kernel.org>, mohan <mohan@couthit.com>,
s hauer <s.hauer@pengutronix.de>,
Prajith Jayarajan <prajith@ti.com>, rogerq <rogerq@kernel.org>,
basharath <basharath@couthit.com>, ssantosh <ssantosh@kernel.org>,
Vadim Fedorenko <vadim.fedorenko@linux.dev>,
linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
rogerq <rogerq@ti.com>, srk <srk@ti.com>,
pratheesh <pratheesh@ti.com>, m-malladi <m-malladi@ti.com>,
netdev <netdev@vger.kernel.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
danishanwar <danishanwar@ti.com>, afd <afd@ti.com>,
andrew+netdev <andrew+netdev@lunn.ch>, horms <horms@kernel.org>,
krishna <krishna@couthit.com>, krzk+dt <krzk+dt@kernel.org>,
davem <davem@davemloft.net>
Subject: Re: [PATCH net-next v10 04/11] net: ti: prueth: Adds link detection, RX and TX support.
Date: Wed, 16 Jul 2025 14:09:26 -0700 [thread overview]
Message-ID: <20250716140926.3aa10894@kernel.org> (raw)
In-Reply-To: <1616453705.30524.1752671471644.JavaMail.zimbra@couthit.local>
On Wed, 16 Jul 2025 18:41:11 +0530 (IST) Parvathi Pudi wrote:
> >> Something needs to stop the queue, right? Otherwise the stack will
> >> send the frame right back to the driver.
> >
> > Yes, we will notify upper layer with “netif_tx_stop_queue()” when returning
> > “NETDEV_TX_BUSY” to not push again immediately.
>
> We reviewed the flow and found that the reason for NETDEV_TX_BUSY being
> notified to the upper layers is due lack of support for reliably detecting
> the TX completion event.
>
> In case of ICSSM PRU Ethernet, we do not have support for TX complete
> notification back to the driver from firmware and its like store and
> forget approach. So it will be tricky to enable back/resume the queue
> if we stop it when we see busy status.
IIUC this is all implemented in SW / FW. You either need to add
the notification or use a timer to unblock the queue.
WARNING: multiple messages have this Message-ID (diff)
From: Jakub Kicinski <kuba@kernel.org>
To: Parvathi Pudi <parvathi@couthit.com>
Cc: danishanwar <danishanwar@ti.com>, rogerq <rogerq@kernel.org>,
andrew+netdev <andrew+netdev@lunn.ch>,
davem <davem@davemloft.net>, edumazet <edumazet@google.com>,
pabeni <pabeni@redhat.com>, robh <robh@kernel.org>,
krzk+dt <krzk+dt@kernel.org>, conor+dt <conor+dt@kernel.org>,
ssantosh <ssantosh@kernel.org>,
richardcochran <richardcochran@gmail.com>,
s hauer <s.hauer@pengutronix.de>,
m-karicheri2 <m-karicheri2@ti.com>,
glaroque <glaroque@baylibre.com>, afd <afd@ti.com>,
saikrishnag <saikrishnag@marvell.com>,
m-malladi <m-malladi@ti.com>,
jacob e keller <jacob.e.keller@intel.com>,
diogo ivo <diogo.ivo@siemens.com>,
javier carrasco cruz <javier.carrasco.cruz@gmail.com>,
horms <horms@kernel.org>, s-anna <s-anna@ti.com>,
basharath <basharath@couthit.com>,
linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
netdev <netdev@vger.kernel.org>,
devicetree <devicetree@vger.kernel.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
Vadim Fedorenko <vadim.fedorenko@linux.dev>,
pratheesh <pratheesh@ti.com>, Prajith Jayarajan <prajith@ti.com>,
Vignesh Raghavendra <vigneshr@ti.com>, praneeth <praneeth@ti.com>,
srk <srk@ti.com>, rogerq <rogerq@ti.com>,
krishna <krishna@couthit.com>, pmohan <pmohan@couthit.com>,
mohan <mohan@couthit.com>
Subject: Re: [PATCH net-next v10 04/11] net: ti: prueth: Adds link detection, RX and TX support.
Date: Wed, 16 Jul 2025 14:09:26 -0700 [thread overview]
Message-ID: <20250716140926.3aa10894@kernel.org> (raw)
In-Reply-To: <1616453705.30524.1752671471644.JavaMail.zimbra@couthit.local>
On Wed, 16 Jul 2025 18:41:11 +0530 (IST) Parvathi Pudi wrote:
> >> Something needs to stop the queue, right? Otherwise the stack will
> >> send the frame right back to the driver.
> >
> > Yes, we will notify upper layer with “netif_tx_stop_queue()” when returning
> > “NETDEV_TX_BUSY” to not push again immediately.
>
> We reviewed the flow and found that the reason for NETDEV_TX_BUSY being
> notified to the upper layers is due lack of support for reliably detecting
> the TX completion event.
>
> In case of ICSSM PRU Ethernet, we do not have support for TX complete
> notification back to the driver from firmware and its like store and
> forget approach. So it will be tricky to enable back/resume the queue
> if we stop it when we see busy status.
IIUC this is all implemented in SW / FW. You either need to add
the notification or use a timer to unblock the queue.
next prev parent reply other threads:[~2025-07-16 21:24 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-02 14:06 [PATCH net-next v10 00/11] PRU-ICSSM Ethernet Driver Parvathi Pudi
2025-07-02 14:06 ` [PATCH net-next v10 01/11] dt-bindings: net: ti: Adds DUAL-EMAC mode support on PRU-ICSS2 for AM57xx, AM43xx and AM33xx SOCs Parvathi Pudi
2025-07-02 14:06 ` [PATCH net-next v10 02/11] net: ti: prueth: Adds ICSSM Ethernet driver Parvathi Pudi
2025-07-09 0:44 ` Jakub Kicinski
2025-07-09 0:44 ` Jakub Kicinski
2025-07-11 12:25 ` Parvathi Pudi
2025-07-11 12:25 ` Parvathi Pudi
2025-07-02 14:06 ` [PATCH net-next v10 03/11] net: ti: prueth: Adds PRUETH HW and SW configuration Parvathi Pudi
2025-07-09 0:53 ` Jakub Kicinski
2025-07-09 0:53 ` Jakub Kicinski
2025-07-11 12:28 ` Parvathi Pudi
2025-07-11 12:28 ` Parvathi Pudi
2025-07-02 15:17 ` [PATCH net-next v10 04/11] net: ti: prueth: Adds link detection, RX and TX support Parvathi Pudi
2025-07-09 1:01 ` Jakub Kicinski
2025-07-09 1:01 ` Jakub Kicinski
2025-07-11 12:33 ` Parvathi Pudi
2025-07-11 12:33 ` Parvathi Pudi
2025-07-16 13:11 ` Parvathi Pudi
2025-07-16 13:11 ` Parvathi Pudi
2025-07-16 21:09 ` Jakub Kicinski [this message]
2025-07-16 21:09 ` Jakub Kicinski
2025-07-18 10:47 ` Parvathi Pudi
2025-07-18 10:47 ` Parvathi Pudi
2025-07-18 17:09 ` Jakub Kicinski
2025-07-18 17:09 ` Jakub Kicinski
2025-07-02 15:17 ` [PATCH net-next v10 05/11] net: ti: prueth: Adds ethtool support for ICSSM PRUETH Driver Parvathi Pudi
2025-07-02 15:17 ` [PATCH net-next v10 06/11] net: ti: prueth: Adds HW timestamping support for PTP using PRU-ICSS IEP module Parvathi Pudi
2025-07-03 22:52 ` Vadim Fedorenko
2025-07-02 15:17 ` [PATCH net-next v10 07/11] net: ti: prueth: Adds support for network filters for traffic control supported by PRU-ICSS Parvathi Pudi
2025-07-02 16:24 ` [PATCH net-next v10 08/11] net: ti: prueth: Adds support for RX interrupt coalescing/pacing Parvathi Pudi
2025-07-02 16:24 ` [PATCH net-next v10 09/11] net: ti: prueth: Adds power management support for PRU-ICSS Parvathi Pudi
2025-07-02 16:24 ` [PATCH net-next v10 10/11] net: ti: prueth: Adds support for PRUETH on AM33x and AM43x SOCs Parvathi Pudi
2025-07-02 16:24 ` [PATCH net-next v10 11/11] net: ti: prueth: Adds PTP OC Support for AM335x and AM437x Parvathi Pudi
2025-07-09 0:33 ` [PATCH net-next v10 00/11] PRU-ICSSM Ethernet Driver Jakub Kicinski
2025-07-09 0:33 ` Jakub Kicinski
2025-07-11 12:20 ` Parvathi Pudi
2025-07-11 12:20 ` Parvathi Pudi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250716140926.3aa10894@kernel.org \
--to=kuba@kernel.org \
--cc=afd@ti.com \
--cc=andrew+netdev@lunn.ch \
--cc=basharath@couthit.com \
--cc=conor+dt@kernel.org \
--cc=danishanwar@ti.com \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=diogo.ivo@siemens.com \
--cc=edumazet@google.com \
--cc=glaroque@baylibre.com \
--cc=horms@kernel.org \
--cc=jacob.e.keller@intel.com \
--cc=javier.carrasco.cruz@gmail.com \
--cc=krishna@couthit.com \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=m-karicheri2@ti.com \
--cc=m-malladi@ti.com \
--cc=mohan@couthit.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=parvathi@couthit.com \
--cc=pmohan@couthit.com \
--cc=prajith@ti.com \
--cc=praneeth@ti.com \
--cc=pratheesh@ti.com \
--cc=richardcochran@gmail.com \
--cc=robh@kernel.org \
--cc=rogerq@kernel.org \
--cc=rogerq@ti.com \
--cc=s.hauer@pengutronix.de \
--cc=saikrishnag@marvell.com \
--cc=srk@ti.com \
--cc=ssantosh@kernel.org \
--cc=vadim.fedorenko@linux.dev \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.