Re: [PATCH] ASoC: SDCA: Fix uninitialized use of name in sdca_irq_populate()

[Nathan Chancellor <nathan@kernel.org>]

On Wed, Jul 16, 2025 at 09:25:20AM +0100, Charles Keepax wrote:
> On Tue, Jul 15, 2025 at 08:34:21PM -0700, Nathan Chancellor wrote:
> > After a recent change in clang to strengthen uninitialized warnings [1],
> > it points out that name is used uninitialized in sdca_irq_populate():
> > 
> >   sound/soc/sdca/sdca_interrupts.c:388:6: error: variable 'name' is uninitialized when used here [-Werror,-Wuninitialized]
> >     388 |                                         name, ret);
> >         |                                         ^~~~
> > 
> > Remove name and use the name member in the interrupt variable, as that
> > is the proper string to print.
> > 
> > Fixes: b126394d9ec6 ("ASoC: SDCA: Generic interrupt support")
> > Link: https://github.com/llvm/llvm-project/commit/2464313eef01c5b1edf0eccf57a32cdee01472c7 [1]
> > Signed-off-by: Nathan Chancellor <nathan@kernel.org>
> > ---
> 
> A fix is already pending for this one:
> 
> https://lore.kernel.org/linux-sound/20250715151723.2964336-3-ckeepax@opensource.cirrus.com/T/#u
> 
> Although they are identical so don't mind which gets merged :-)

Whoops, I should have checked for duplicates like I usually do...

I see Mark has merged your change now so we are all good here.

https:///git.kernel.org/broonie/sound/c/71562278a189af2ca202eafa0ab71a9b68469207

Cheers,
Nathan