From: Charles Keepax <ckeepax@opensource.cirrus.com>
To: Nathan Chancellor <nathan@kernel.org>
Cc: Maciej Strozek <mstrozek@opensource.cirrus.com>,
Bard Liao <yung-chuan.liao@linux.intel.com>,
Pierre-Louis Bossart <pierre-louis.bossart@linux.dev>,
Mark Brown <broonie@kernel.org>,
linux-sound@vger.kernel.org, patches@opensource.cirrus.com,
llvm@lists.linux.dev, patches@lists.linux.dev
Subject: Re: [PATCH] ASoC: SDCA: Fix uninitialized use of name in sdca_irq_populate()
Date: Wed, 16 Jul 2025 09:25:20 +0100 [thread overview]
Message-ID: <aHdh8LOJblKP01rd@opensource.cirrus.com> (raw)
In-Reply-To: <20250715-sdca_interrupts-fix-const-uninit-warning-v1-1-cc031c913499@kernel.org>
On Tue, Jul 15, 2025 at 08:34:21PM -0700, Nathan Chancellor wrote:
> After a recent change in clang to strengthen uninitialized warnings [1],
> it points out that name is used uninitialized in sdca_irq_populate():
>
> sound/soc/sdca/sdca_interrupts.c:388:6: error: variable 'name' is uninitialized when used here [-Werror,-Wuninitialized]
> 388 | name, ret);
> | ^~~~
>
> Remove name and use the name member in the interrupt variable, as that
> is the proper string to print.
>
> Fixes: b126394d9ec6 ("ASoC: SDCA: Generic interrupt support")
> Link: https://github.com/llvm/llvm-project/commit/2464313eef01c5b1edf0eccf57a32cdee01472c7 [1]
> Signed-off-by: Nathan Chancellor <nathan@kernel.org>
> ---
A fix is already pending for this one:
https://lore.kernel.org/linux-sound/20250715151723.2964336-3-ckeepax@opensource.cirrus.com/T/#u
Although they are identical so don't mind which gets merged :-)
Thanks,
Charles
next prev parent reply other threads:[~2025-07-16 8:25 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-16 3:34 [PATCH] ASoC: SDCA: Fix uninitialized use of name in sdca_irq_populate() Nathan Chancellor
2025-07-16 8:25 ` Charles Keepax [this message]
2025-07-16 20:02 ` Nathan Chancellor
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aHdh8LOJblKP01rd@opensource.cirrus.com \
--to=ckeepax@opensource.cirrus.com \
--cc=broonie@kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=llvm@lists.linux.dev \
--cc=mstrozek@opensource.cirrus.com \
--cc=nathan@kernel.org \
--cc=patches@lists.linux.dev \
--cc=patches@opensource.cirrus.com \
--cc=pierre-louis.bossart@linux.dev \
--cc=yung-chuan.liao@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.