[PATCH 1/3] staging: rtl8723bs: fix block comment end markers

[PATCH 1/3] staging: rtl8723bs: fix block comment end markers

[Ignacio Peña]

From: Ignacio Pena <ignacio.pena87@gmail.com>

Fix checkpatch warnings about block comment style by moving the
closing comment marker '*/' to a separate line.

Signed-off-by: Ignacio Pena <ignacio.pena87@gmail.com>
---
 drivers/staging/rtl8723bs/core/rtw_efuse.c | 15 +++++++++------
 1 file changed, 9 insertions(+), 6 deletions(-)

diff --git a/drivers/staging/rtl8723bs/core/rtw_efuse.c b/drivers/staging/rtl8723bs/core/rtw_efuse.c
index 7a74b011d..1e2b3c456 100644
--- a/drivers/staging/rtl8723bs/core/rtw_efuse.c
+++ b/drivers/staging/rtl8723bs/core/rtw_efuse.c
@@ -70,7 +70,8 @@ Efuse_Write1ByteToFakeContent(u16 Offset, u8 Value)
  * When                        Who             Remark
  * 11/17/2008  MHC             Create Version 0.
  *
- *---------------------------------------------------------------------------*/
+ *---------------------------------------------------------------------------
+ */
 void
 Efuse_PowerSwitch(
 struct adapter *padapter,
@@ -163,7 +164,8 @@ EFUSE_GetEfuseDefinition(
  * When                        Who             Remark
  * 09/23/2008  MHC             Copy from WMAC.
  *
- *---------------------------------------------------------------------------*/
+ *---------------------------------------------------------------------------
+ */
 u8
 EFUSE_Read1Byte(
 struct adapter *Adapter,
@@ -313,7 +315,8 @@ Efuse_WordEnableDataWrite(struct adapter *padapter,
  * When                        Who             Remark
  * 11/11/2008  MHC             Create Version 0.
  *
- *---------------------------------------------------------------------------*/
+ *---------------------------------------------------------------------------
+ */
 void
 Efuse_ReadAllMap(
        struct adapter *padapter,
@@ -350,7 +353,8 @@ void Efuse_ReadAllMap(struct adapter *padapter, u8 efuseType, u8 *Efuse, bool bP
  * When                        Who             Remark
  * 11/12/2008  MHC             Create Version 0.
  *
- *---------------------------------------------------------------------------*/
+ *---------------------------------------------------------------------------
+ */
 static void efuse_ShadowRead1Byte(struct adapter *padapter, u16 Offset, u8 *Value)
 {
        struct eeprom_priv *pEEPROM = GET_EEPROM_EFUSE_PRIV(padapter);
@@ -396,7 +400,8 @@ static void efuse_ShadowRead4Byte(struct adapter *padapter, u16 Offset, u32 *Val
  * When                        Who             Remark
  * 11/13/2008  MHC             Create Version 0.
  *
- *---------------------------------------------------------------------------*/
+ *---------------------------------------------------------------------------
+ */
 void EFUSE_ShadowMapUpdate(struct adapter *padapter, u8 efuseType, bool bPseudoTest)
 {
        struct eeprom_priv *pEEPROM = GET_EEPROM_EFUSE_PRIV(padapter);
@@ -429,7 +434,8 @@ void EFUSE_ShadowMapUpdate(struct adapter *padapter, u8 efuseType, bool bPseudoT
  * When                        Who             Remark
  * 11/12/2008  MHC             Create Version 0.
  *
- *---------------------------------------------------------------------------*/
+ *---------------------------------------------------------------------------
+ */
 void EFUSE_ShadowRead(struct adapter *padapter, u8 Type, u16 Offset, u32 *Value)
 {
        if (Type == 1)
-- 
2.39.5

[PATCH 2/3] staging: rtl8723bs: add missing blank line after declaration

[Ignacio Peña]

From: Ignacio Pena <ignacio.pena87@gmail.com>

Fix checkpatch warning by adding required blank line after variable
declaration in Efuse_CalculateWordCnts function.

Signed-off-by: Ignacio Pena <ignacio.pena87@gmail.com>
---
 drivers/staging/rtl8723bs/core/rtw_efuse.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/staging/rtl8723bs/core/rtw_efuse.c b/drivers/staging/rtl8723bs/core/rtw_efuse.c
index 1e2b3c456..fc6dee711 100644
--- a/drivers/staging/rtl8723bs/core/rtw_efuse.c
+++ b/drivers/staging/rtl8723bs/core/rtw_efuse.c
@@ -85,6 +85,7 @@ u8
 Efuse_CalculateWordCnts(u8 word_en)
 {
        u8 word_cnts = 0;
+
        if (!(word_en & BIT(0)))
                word_cnts++; /*  0 : write enable */
        if (!(word_en & BIT(1)))
-- 
2.39.5

Re: [PATCH 2/3] staging: rtl8723bs: add missing blank line after declaration

[Greg KH]

On Wed, Jul 16, 2025 at 01:36:03AM -0400, Ignacio Peña wrote:
> From: Ignacio Pena <ignacio.pena87@gmail.com>
> 
> Fix checkpatch warning by adding required blank line after variable
> declaration in Efuse_CalculateWordCnts function.
> 
> Signed-off-by: Ignacio Pena <ignacio.pena87@gmail.com>
> ---
>  drivers/staging/rtl8723bs/core/rtw_efuse.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/staging/rtl8723bs/core/rtw_efuse.c b/drivers/staging/rtl8723bs/core/rtw_efuse.c
> index 1e2b3c456..fc6dee711 100644
> --- a/drivers/staging/rtl8723bs/core/rtw_efuse.c
> +++ b/drivers/staging/rtl8723bs/core/rtw_efuse.c
> @@ -85,6 +85,7 @@ u8
>  Efuse_CalculateWordCnts(u8 word_en)
>  {
>         u8 word_cnts = 0;
> +
>         if (!(word_en & BIT(0)))
>                 word_cnts++; /*  0 : write enable */
>         if (!(word_en & BIT(1)))
> -- 
> 2.39.5
> 

Hi,

This is the friendly patch-bot of Greg Kroah-Hartman.  You have sent him
a patch that has triggered this response.  He used to manually respond
to these common problems, but in order to save his sanity (he kept
writing the same thing over and over, yet to different people), I was
created.  Hopefully you will not take offence and will fix the problem
in your patch and resubmit it so that it can be accepted into the Linux
kernel tree.

You are receiving this message because of the following common error(s)
as indicated below:

- Your patch is malformed (tabs converted to spaces, linewrapped, etc.)
  and can not be applied.  Please read the file,
  Documentation/process/email-clients.rst in order to fix this.

If you wish to discuss this problem further, or you have questions about
how to resolve this issue, please feel free to respond to this email and
Greg will reply once he has dug out from the pending patches received
from other developers.

thanks,

greg k-h's patch email bot

[PATCH 3/3] staging: rtl8723bs: fix indentation in commented code

[Ignacio Peña]

From: Ignacio Pena <ignacio.pena87@gmail.com>

Fix checkpatch warning by correcting tab indentation in commented
return statement.

Signed-off-by: Ignacio Pena <ignacio.pena87@gmail.com>
---
 drivers/staging/rtl8723bs/core/rtw_cmd.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/rtl8723bs/core/rtw_cmd.c b/drivers/staging/rtl8723bs/core/rtw_cmd.c
index 437934dd2..f02b3b485 100644
--- a/drivers/staging/rtl8723bs/core/rtw_cmd.c
+++ b/drivers/staging/rtl8723bs/core/rtw_cmd.c
@@ -1318,7 +1318,7 @@ u8 rtw_lps_ctrl_wk_cmd(struct adapter *padapter, u8 lps_ctrl_type, u8 enqueue)
        u8 res = _SUCCESS;

        /* if (!pwrctrlpriv->bLeisurePs) */
-       /*      return res; */
+       /*      return res; */

        if (enqueue) {
                ph2c = rtw_zmalloc(sizeof(struct cmd_obj));
-- 
2.39.5

Re: [PATCH 3/3] staging: rtl8723bs: fix indentation in commented code

[Greg KH]

On Wed, Jul 16, 2025 at 01:36:04AM -0400, Ignacio Peña wrote:
> From: Ignacio Pena <ignacio.pena87@gmail.com>
> 
> Fix checkpatch warning by correcting tab indentation in commented
> return statement.
> 
> Signed-off-by: Ignacio Pena <ignacio.pena87@gmail.com>
> ---
>  drivers/staging/rtl8723bs/core/rtw_cmd.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/rtl8723bs/core/rtw_cmd.c b/drivers/staging/rtl8723bs/core/rtw_cmd.c
> index 437934dd2..f02b3b485 100644
> --- a/drivers/staging/rtl8723bs/core/rtw_cmd.c
> +++ b/drivers/staging/rtl8723bs/core/rtw_cmd.c
> @@ -1318,7 +1318,7 @@ u8 rtw_lps_ctrl_wk_cmd(struct adapter *padapter, u8 lps_ctrl_type, u8 enqueue)
>         u8 res = _SUCCESS;
> 
>         /* if (!pwrctrlpriv->bLeisurePs) */
> -       /*      return res; */
> +       /*      return res; */

I don't see any whitespace change here as the whole patch's whitespace
is broken :(

Also, why not just delete these two lines entirely?

thanks,

greg k-h

Re: [PATCH 1/3] staging: rtl8723bs: fix block comment end markers

[Greg KH]

On Wed, Jul 16, 2025 at 01:36:02AM -0400, Ignacio Peña wrote:
> From: Ignacio Pena <ignacio.pena87@gmail.com>
> 
> Fix checkpatch warnings about block comment style by moving the
> closing comment marker '*/' to a separate line.
> 
> Signed-off-by: Ignacio Pena <ignacio.pena87@gmail.com>
> ---
>  drivers/staging/rtl8723bs/core/rtw_efuse.c | 15 +++++++++------
>  1 file changed, 9 insertions(+), 6 deletions(-)
> 
> diff --git a/drivers/staging/rtl8723bs/core/rtw_efuse.c b/drivers/staging/rtl8723bs/core/rtw_efuse.c
> index 7a74b011d..1e2b3c456 100644
> --- a/drivers/staging/rtl8723bs/core/rtw_efuse.c
> +++ b/drivers/staging/rtl8723bs/core/rtw_efuse.c
> @@ -70,7 +70,8 @@ Efuse_Write1ByteToFakeContent(u16 Offset, u8 Value)
>   * When                        Who             Remark
>   * 11/17/2008  MHC             Create Version 0.
>   *
> - *---------------------------------------------------------------------------*/
> + *---------------------------------------------------------------------------

This line can now just be removed, right?

Same for all of these long "------" comment lines, they aren't needed as
this isn't the kernel coding style.

thanks,

greg k-h