All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] net: Kconfig: add endif/endmenu comments
@ 2025-07-21  2:04 Randy Dunlap
  2025-07-21  9:39 ` Simon Horman
  2025-07-23  1:30 ` patchwork-bot+netdevbpf
  0 siblings, 2 replies; 3+ messages in thread
From: Randy Dunlap @ 2025-07-21  2:04 UTC (permalink / raw)
  To: netdev
  Cc: Randy Dunlap, David S. Miller, Eric Dumazet, Jakub Kicinski,
	Paolo Abeni, Simon Horman

Add comments on endif & endmenu blocks. This can save time
when searching & trying to understand kconfig menu dependencies.

The other endif & endmenu statements are already commented like this.

This makes it similar to drivers/net/Kconfig, which is already
commented like this.

Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
---
Cc: "David S. Miller" <davem@davemloft.net>
Cc: Eric Dumazet <edumazet@google.com>
Cc: Jakub Kicinski <kuba@kernel.org>
Cc: Paolo Abeni <pabeni@redhat.com>
Cc: Simon Horman <horms@kernel.org>

 net/Kconfig |    6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

--- linux-next.orig/net/Kconfig
+++ linux-next/net/Kconfig
@@ -247,7 +247,7 @@ source "net/ipv4/netfilter/Kconfig"
 source "net/ipv6/netfilter/Kconfig"
 source "net/bridge/netfilter/Kconfig"
 
-endif
+endif # if NETFILTER
 
 source "net/sctp/Kconfig"
 source "net/rds/Kconfig"
@@ -408,9 +408,9 @@ config NET_DROP_MONITOR
 	  just checking the various proc files and other utilities for
 	  drop statistics, say N here.
 
-endmenu
+endmenu # Network testing
 
-endmenu
+endmenu # Networking options
 
 source "net/ax25/Kconfig"
 source "net/can/Kconfig"

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] net: Kconfig: add endif/endmenu comments
  2025-07-21  2:04 [PATCH] net: Kconfig: add endif/endmenu comments Randy Dunlap
@ 2025-07-21  9:39 ` Simon Horman
  2025-07-23  1:30 ` patchwork-bot+netdevbpf
  1 sibling, 0 replies; 3+ messages in thread
From: Simon Horman @ 2025-07-21  9:39 UTC (permalink / raw)
  To: Randy Dunlap
  Cc: netdev, David S. Miller, Eric Dumazet, Jakub Kicinski,
	Paolo Abeni

On Sun, Jul 20, 2025 at 07:04:20PM -0700, Randy Dunlap wrote:
> Add comments on endif & endmenu blocks. This can save time
> when searching & trying to understand kconfig menu dependencies.
> 
> The other endif & endmenu statements are already commented like this.
> 
> This makes it similar to drivers/net/Kconfig, which is already
> commented like this.
> 
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>

Reviewed-by: Simon Horman <horms@kernel.org>


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] net: Kconfig: add endif/endmenu comments
  2025-07-21  2:04 [PATCH] net: Kconfig: add endif/endmenu comments Randy Dunlap
  2025-07-21  9:39 ` Simon Horman
@ 2025-07-23  1:30 ` patchwork-bot+netdevbpf
  1 sibling, 0 replies; 3+ messages in thread
From: patchwork-bot+netdevbpf @ 2025-07-23  1:30 UTC (permalink / raw)
  To: Randy Dunlap; +Cc: netdev, davem, edumazet, kuba, pabeni, horms

Hello:

This patch was applied to netdev/net-next.git (main)
by Jakub Kicinski <kuba@kernel.org>:

On Sun, 20 Jul 2025 19:04:20 -0700 you wrote:
> Add comments on endif & endmenu blocks. This can save time
> when searching & trying to understand kconfig menu dependencies.
> 
> The other endif & endmenu statements are already commented like this.
> 
> This makes it similar to drivers/net/Kconfig, which is already
> commented like this.
> 
> [...]

Here is the summary with links:
  - net: Kconfig: add endif/endmenu comments
    https://git.kernel.org/netdev/net-next/c/b2dd6eb0acd7

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html



^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2025-07-23  1:30 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-07-21  2:04 [PATCH] net: Kconfig: add endif/endmenu comments Randy Dunlap
2025-07-21  9:39 ` Simon Horman
2025-07-23  1:30 ` patchwork-bot+netdevbpf

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.