All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andre Przywara <andre.przywara@arm.com>
To: u-boot@lists.denx.de
Cc: Jernej Skrabec <jernej.skrabec@gmail.com>,
	Mikhail Kalashnikov <iuncuim@gmail.com>,
	Yixun Lan <dlan@gentoo.org>,
	Paul Kocialkowski <paulk@sys-base.io>,
	linux-sunxi@lists.linux.dev, Tom Rini <trini@konsulko.com>
Subject: Re: [PATCH v2 20/20] sunxi: A523: add defconfigs for three boards
Date: Tue, 22 Jul 2025 01:35:26 +0100	[thread overview]
Message-ID: <20250722013526.6297858c@minigeek.lan> (raw)
In-Reply-To: <20250717235455.32528-21-andre.przywara@arm.com>

On Fri, 18 Jul 2025 00:54:55 +0100
Andre Przywara <andre.przywara@arm.com> wrote:

Hi Yixun,

see below for a comment on the missing eMMC support for the Radxa
defconfig. My board doesn't have eMMC, so can you please check this on
your end?

> So far developers seem to use three popular boards:
> - Avaota A1: dev board with USB 3.0, dual Ethernet, small display
> - X96QPro+: TV box with Gigabit Ethernet, USB 3.0, eMMC
> - Radxa A5E: small dev board with USB3/M.2 2230 (muxed), dual Ethernet
> 
> Add the defconfig files for those boards, containing the DRAM parameters
> and the usual Kconfig options.
> 
> Signed-off-by: Andre Przywara <andre.przywara@arm.com>
> ---
>  board/sunxi/MAINTAINERS         | 15 +++++++++++++++
>  configs/avaota-a1_defconfig     | 31 +++++++++++++++++++++++++++++++
>  configs/radxa-a5e_defconfig     | 30 ++++++++++++++++++++++++++++++
>  configs/x96q_pro_plus_defconfig | 32 ++++++++++++++++++++++++++++++++
>  4 files changed, 108 insertions(+)
>  create mode 100644 configs/avaota-a1_defconfig
>  create mode 100644 configs/radxa-a5e_defconfig
>  create mode 100644 configs/x96q_pro_plus_defconfig
> 
> diff --git a/board/sunxi/MAINTAINERS b/board/sunxi/MAINTAINERS
> index 1b4b7d87163..66e6a8ff962 100644
> --- a/board/sunxi/MAINTAINERS
> +++ b/board/sunxi/MAINTAINERS
> @@ -137,6 +137,11 @@ M:	Chris Morgan <macromorgan@hotmail.com>
>  S:	Maintained
>  F:	configs/anbernic_rg35xx_h700_defconfig
>  
> +AVAOTA A1 BOARD
> +M:	Andre Przywara <andre.przywara@arm.com>
> +S:	Maintained
> +F:	configs/avaota-a1_defconfig
> +
>  BANANAPI M1 PLUS
>  M:	Jagan Teki <jagan@amarulasolutions.com>
>  S:	Maintained
> @@ -531,6 +536,11 @@ M:	Quentin Schulz <quentin.schulz@free-electrons.com>
>  S:	Maintained
>  F:	configs/parrot_r16_defconfig
>  
> +RADXA CUBIE A5E BOARD
> +M:	Andre Przywara <andre.przywara@arm.com>
> +S:	Maintained
> +F:	configs/radxa-a5e_defconfig
> +
>  SINLINX SINA31s BOARD
>  M:	Chen-Yu Tsai <wens@csie.org>
>  S:	Maintained
> @@ -591,6 +601,11 @@ M:	Andre Przywara <andre.przywara@arm.com>
>  S:	Maintained
>  F:	configs/x96_mate_defconfig
>  
> +X96Q PRO+ TV BOX
> +M:	Andre Przywara <andre.przywara@arm.com>
> +S:	Maintained
> +F:	configs/x96q_pro_plus_defconfig
> +
>  YONES TOPTECH BD1078 BOARD
>  M:	Paul Kocialkowski <contact@paulk.fr>
>  S:	Maintained
> diff --git a/configs/avaota-a1_defconfig b/configs/avaota-a1_defconfig
> new file mode 100644
> index 00000000000..55457edd3b3
> --- /dev/null
> +++ b/configs/avaota-a1_defconfig
> @@ -0,0 +1,31 @@
> +CONFIG_ARM=y
> +CONFIG_ARCH_SUNXI=y
> +CONFIG_DEFAULT_DEVICE_TREE="allwinner/sun55i-t527-avaota-a1"
> +CONFIG_SPL=y
> +CONFIG_DRAM_SUNXI_DX_ODT=0x07070707
> +CONFIG_DRAM_SUNXI_DX_DRI=0x0d0d0d0d
> +CONFIG_DRAM_SUNXI_CA_DRI=0x0e0e
> +CONFIG_DRAM_SUNXI_ODT_EN=0x84848484
> +CONFIG_DRAM_SUNXI_TPR0=0x80808080
> +CONFIG_DRAM_SUNXI_TPR1=0x06060606
> +CONFIG_DRAM_SUNXI_TPR6=0x38000000
> +CONFIG_DRAM_SUNXI_TPR10=0x802f3333
> +CONFIG_DRAM_SUNXI_TPR11=0xc7c5c4c2
> +CONFIG_DRAM_SUNXI_TPR12=0x3533302f
> +CONFIG_MACH_SUN55I_A523=y
> +CONFIG_MMC_SUNXI_SLOT_EXTRA=2
> +CONFIG_R_I2C_ENABLE=y
> +# CONFIG_SYS_MALLOC_CLEAR_ON_INIT is not set
> +CONFIG_SPL_I2C=y
> +CONFIG_SPL_SYS_I2C_LEGACY=y
> +CONFIG_SYS_I2C_MVTWSI=y
> +CONFIG_SYS_I2C_SLAVE=0x7f
> +CONFIG_SYS_I2C_SPEED=400000
> +CONFIG_SUPPORT_EMMC_BOOT=y
> +CONFIG_REGULATOR_AXP=y
> +CONFIG_AXP717_POWER=y
> +CONFIG_AXP_I2C_ADDRESS=0x35
> +CONFIG_AXP_DCDC2_VOLT=920
> +CONFIG_AXP_DCDC3_VOLT=1160
> +CONFIG_USB_EHCI_HCD=y
> +CONFIG_USB_OHCI_HCD=y
> diff --git a/configs/radxa-a5e_defconfig b/configs/radxa-a5e_defconfig
> new file mode 100644
> index 00000000000..012e7b4eeaf
> --- /dev/null
> +++ b/configs/radxa-a5e_defconfig
> @@ -0,0 +1,30 @@
> +CONFIG_ARM=y
> +CONFIG_ARCH_SUNXI=y
> +CONFIG_DEFAULT_DEVICE_TREE="allwinner/sun55i-a527-cubie-a5e"
> +CONFIG_SPL=y
> +CONFIG_DRAM_SUNXI_DX_ODT=0x07070707
> +CONFIG_DRAM_SUNXI_DX_DRI=0x0d0d0d0d
> +CONFIG_DRAM_SUNXI_CA_DRI=0x0e0e
> +CONFIG_DRAM_SUNXI_ODT_EN=0x84848484
> +CONFIG_DRAM_SUNXI_TPR0=0x80808080
> +CONFIG_DRAM_SUNXI_TPR1=0x06060606
> +CONFIG_DRAM_SUNXI_TPR6=0x38000000
> +CONFIG_DRAM_SUNXI_TPR10=0x802f3333
> +CONFIG_DRAM_SUNXI_TPR11=0xc7c5c4c2
> +CONFIG_DRAM_SUNXI_TPR12=0x3533302f
> +# BSP value: CONFIG_DRAM_SUNXI_TPR11=0xc6c4c2c0
> +# BSP value: CONFIG_DRAM_SUNXI_TPR12=0x3a373233
> +CONFIG_MACH_SUN55I_A523=y
> +CONFIG_R_I2C_ENABLE=y
> +# CONFIG_SYS_MALLOC_CLEAR_ON_INIT is not set
> +CONFIG_SPL_I2C=y
> +CONFIG_SPL_SYS_I2C_LEGACY=y
> +CONFIG_SYS_I2C_MVTWSI=y
> +CONFIG_SYS_I2C_SLAVE=0x7f
> +CONFIG_SYS_I2C_SPEED=400000
> +CONFIG_REGULATOR_AXP=y
> +CONFIG_AXP717_POWER=y
> +CONFIG_AXP_DCDC2_VOLT=920
> +CONFIG_AXP_DCDC3_VOLT=1100
> +CONFIG_USB_EHCI_HCD=y
> +CONFIG_USB_OHCI_HCD=y

This is missing CONFIG_MMC_SUNXI_SLOT_EXTRA=2 and
CONFIG_SUPPORT_EMMC_BOOT=y, as there are Radxa boards with eMMC.
The DT describes this, so we should follow suit here, to allow eMMC
booting. Should not harm boards without the eMMC chip.

Thanks,
Andre

> diff --git a/configs/x96q_pro_plus_defconfig b/configs/x96q_pro_plus_defconfig
> new file mode 100644
> index 00000000000..07d3b078bef
> --- /dev/null
> +++ b/configs/x96q_pro_plus_defconfig
> @@ -0,0 +1,32 @@
> +CONFIG_ARM=y
> +CONFIG_ARCH_SUNXI=y
> +CONFIG_DEFAULT_DEVICE_TREE="allwinner/sun55i-h728-x96qpro+"
> +CONFIG_SPL=y
> +CONFIG_DRAM_SUNXI_DX_ODT=0x07070707
> +CONFIG_DRAM_SUNXI_DX_DRI=0x0c0c0c0c
> +CONFIG_DRAM_SUNXI_CA_DRI=0x0e0e
> +CONFIG_DRAM_SUNXI_ODT_EN=0x90909090
> +CONFIG_DRAM_SUNXI_TPR0=0x80808080
> +CONFIG_DRAM_SUNXI_TPR1=0x06060606
> +CONFIG_DRAM_SUNXI_TPR6=0x3380807e
> +CONFIG_DRAM_SUNXI_TPR10=0x802f7788
> +CONFIG_DRAM_SUNXI_TPR11=0x8f919190
> +CONFIG_DRAM_SUNXI_TPR12=0x22222723
> +CONFIG_MACH_SUN55I_A523=y
> +CONFIG_SUNXI_DRAM_A523_DDR3=y
> +CONFIG_DRAM_CLK=792
> +CONFIG_MMC_SUNXI_SLOT_EXTRA=2
> +CONFIG_R_I2C_ENABLE=y
> +# CONFIG_SYS_MALLOC_CLEAR_ON_INIT is not set
> +CONFIG_SPL_I2C=y
> +CONFIG_SPL_SYS_I2C_LEGACY=y
> +CONFIG_SYS_I2C_MVTWSI=y
> +CONFIG_SYS_I2C_SLAVE=0x7f
> +CONFIG_SYS_I2C_SPEED=400000
> +CONFIG_SUPPORT_EMMC_BOOT=y
> +CONFIG_REGULATOR_AXP=y
> +CONFIG_AXP717_POWER=y
> +CONFIG_AXP_DCDC2_VOLT=920
> +CONFIG_AXP_DCDC3_VOLT=1360
> +CONFIG_USB_EHCI_HCD=y
> +CONFIG_USB_OHCI_HCD=y


  parent reply	other threads:[~2025-07-22  0:37 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-07-17 23:54 [PATCH v2 00/20] sunxi: Add Allwinner A523 support Andre Przywara
2025-07-17 23:54 ` [PATCH v2 01/20] sunxi: clock: H6: unify PLL control bit definitions Andre Przywara
2025-07-17 23:54 ` [PATCH v2 02/20] sunxi: clock: H6: factor out clock_set_pll() Andre Przywara
2025-07-17 23:54 ` [PATCH v2 03/20] sunxi: clock: H6: factor out H6/H616 CPU clock setup Andre Przywara
2025-07-17 23:54 ` [PATCH v2 04/20] sunxi: clock: H6: add A523 CPU PLL support Andre Przywara
2025-07-17 23:54 ` [PATCH v2 05/20] sunxi: spl: add support for Allwinner A523 watchdog Andre Przywara
2025-07-17 23:54 ` [PATCH v2 06/20] clk: sunxi: Add support for the A523 CCU Andre Przywara
2025-07-17 23:54 ` [PATCH v2 07/20] clk: sunxi: Add support for the A523 -R CCU Andre Przywara
2025-07-17 23:54 ` [PATCH v2 08/20] pinctrl: sunxi: add Allwinner A523 pinctrl description Andre Przywara
2025-07-17 23:54 ` [PATCH v2 09/20] sunxi: mmc: add support for Allwinner A523 MMC mod clock Andre Przywara
2025-07-22  0:32   ` Andre Przywara
2025-07-17 23:54 ` [PATCH v2 10/20] power: regulator: add AXP323 support Andre Przywara
2025-07-17 23:54 ` [PATCH v2 11/20] sunxi: update cpu_sunxi_ncat2.h Andre Przywara
2025-07-17 23:54 ` [PATCH v2 12/20] sunxi: sun50i_h6: add A523 SPL clock setup code Andre Przywara
2025-07-22  0:14   ` Andre Przywara
2025-07-27 20:15   ` Jernej Škrabec
2025-07-17 23:54 ` [PATCH v2 13/20] sunxi: A523: add DRAM initialisation routine Andre Przywara
2025-07-27 20:16   ` Jernej Škrabec
2025-07-17 23:54 ` [PATCH v2 14/20] sunxi: A523: add DDR3 DRAM support Andre Przywara
2025-07-25  4:44   ` Mikhail Kalashnikov
2025-07-25 23:48   ` Andre Przywara
2025-07-26  0:04   ` [PATCH] FIXUP! a523: DDR3: rework Andre Przywara
2025-07-17 23:54 ` [PATCH v2 15/20] sunxi: add basic A523 support Andre Przywara
2025-07-17 23:54 ` [PATCH v2 16/20] arm64: dts: allwinner: Add Allwinner A523 .dtsi file Andre Przywara
2025-07-17 23:54 ` [PATCH v2 17/20] arm64: dts: allwinner: a523: add X96Q-Pro+ support Andre Przywara
2025-07-17 23:54 ` [PATCH v2 18/20] arm64: dts: allwinner: a523: add Radxa A5E support Andre Przywara
2025-07-17 23:54 ` [PATCH v2 19/20] arm64: dts: allwinner: a523: add Avaota-A1 router support Andre Przywara
2025-07-17 23:54 ` [PATCH v2 20/20] sunxi: A523: add defconfigs for three boards Andre Przywara
2025-07-21  9:18   ` ZHANG Yuntian
2025-07-23 11:09     ` Yixun Lan
2025-07-23 14:19       ` Andre Przywara
2025-07-22  0:35   ` Andre Przywara [this message]
2025-07-22  2:49     ` Yixun Lan
2025-07-22 10:30       ` Andre Przywara
2025-07-19  2:05 ` [PATCH v2 00/20] sunxi: Add Allwinner A523 support Yixun Lan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250722013526.6297858c@minigeek.lan \
    --to=andre.przywara@arm.com \
    --cc=dlan@gentoo.org \
    --cc=iuncuim@gmail.com \
    --cc=jernej.skrabec@gmail.com \
    --cc=linux-sunxi@lists.linux.dev \
    --cc=paulk@sys-base.io \
    --cc=trini@konsulko.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.