From: Al Viro <viro@zeniv.linux.org.uk>
To: Yangtao Li <frank.li@vivo.com>
Cc: slava@dubeyko.com, glaubitz@physik.fu-berlin.de,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 1/3] hfsplus: fix to update ctime after rename
Date: Wed, 23 Jul 2025 03:32:33 +0100 [thread overview]
Message-ID: <20250723023233.GL2580412@ZenIV> (raw)
In-Reply-To: <20250722071347.1076367-1-frank.li@vivo.com>
On Tue, Jul 22, 2025 at 01:13:45AM -0600, Yangtao Li wrote:
> @@ -552,9 +553,13 @@ static int hfsplus_rename(struct mnt_idmap *idmap,
> res = hfsplus_rename_cat((u32)(unsigned long)old_dentry->d_fsdata,
> old_dir, &old_dentry->d_name,
> new_dir, &new_dentry->d_name);
> - if (!res)
> - new_dentry->d_fsdata = old_dentry->d_fsdata;
> - return res;
> + if (res)
> + return res;
> +
> + new_dentry->d_fsdata = old_dentry->d_fsdata;
Umm... Is that assignment (either before or after that patch)
actually correct?
Note that new_dentry essentially got unlinked here; old_dentry
is about to have its parent/name changed by the caller of ->rename(),
so... that looks very odd.
What is that line about?
next prev parent reply other threads:[~2025-07-23 2:32 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-22 7:13 [PATCH v4 1/3] hfsplus: fix to update ctime after rename Yangtao Li
2025-07-22 7:13 ` [PATCH v4 2/3] hfs: correct superblock flags Yangtao Li
2025-07-22 19:06 ` Viacheslav Dubeyko
2025-07-22 7:13 ` [PATCH v4 3/3] hfs: fix to update ctime after rename Yangtao Li
2025-07-22 19:26 ` Viacheslav Dubeyko
2025-07-22 18:51 ` [PATCH v4 1/3] hfsplus: " Viacheslav Dubeyko
2025-07-23 2:32 ` Al Viro [this message]
2025-07-23 17:58 ` Viacheslav Dubeyko
2025-07-23 21:25 ` Al Viro
2025-07-24 18:30 ` Viacheslav Dubeyko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250723023233.GL2580412@ZenIV \
--to=viro@zeniv.linux.org.uk \
--cc=frank.li@vivo.com \
--cc=glaubitz@physik.fu-berlin.de \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=slava@dubeyko.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.