All of lore.kernel.org
 help / color / mirror / Atom feed
From: Al Viro <viro@zeniv.linux.org.uk>
To: Viacheslav Dubeyko <Slava.Dubeyko@ibm.com>
Cc: "frank.li@vivo.com" <frank.li@vivo.com>,
	"glaubitz@physik.fu-berlin.de" <glaubitz@physik.fu-berlin.de>,
	"slava@dubeyko.com" <slava@dubeyko.com>,
	"linux-fsdevel@vger.kernel.org" <linux-fsdevel@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v4 1/3] hfsplus: fix to update ctime after rename
Date: Wed, 23 Jul 2025 22:25:11 +0100	[thread overview]
Message-ID: <20250723212511.GQ2580412@ZenIV> (raw)
In-Reply-To: <cce1a29f2f55baf679c3fe83269d9bceb3c4fd6c.camel@ibm.com>

On Wed, Jul 23, 2025 at 05:58:01PM +0000, Viacheslav Dubeyko wrote:

> So, this line simply copies CNID from old_dentry->d_fsdata to
> new_dentry->d_fsdata during the rename operation. I assume that
> ->fs_data should be untouched by generic logic of dentries processing.

Yes, I understand that; what I do not understand is why.  Why would
the CNID of renamed object be slapped on dentry of removed target?
I'm trying to understand the logics with link(2) and unlink-of-opened
in that code...

Incidentally, what happens if you
	fd = creat("foo", 0666);
	write(fd, "foo", 3);
	link("foo", "bar");
	unlink("bar");
	close(fd);
The games with S_DEAD in there look odd...

  reply	other threads:[~2025-07-23 21:25 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-07-22  7:13 [PATCH v4 1/3] hfsplus: fix to update ctime after rename Yangtao Li
2025-07-22  7:13 ` [PATCH v4 2/3] hfs: correct superblock flags Yangtao Li
2025-07-22 19:06   ` Viacheslav Dubeyko
2025-07-22  7:13 ` [PATCH v4 3/3] hfs: fix to update ctime after rename Yangtao Li
2025-07-22 19:26   ` Viacheslav Dubeyko
2025-07-22 18:51 ` [PATCH v4 1/3] hfsplus: " Viacheslav Dubeyko
2025-07-23  2:32 ` Al Viro
2025-07-23 17:58   ` Viacheslav Dubeyko
2025-07-23 21:25     ` Al Viro [this message]
2025-07-24 18:30       ` Viacheslav Dubeyko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250723212511.GQ2580412@ZenIV \
    --to=viro@zeniv.linux.org.uk \
    --cc=Slava.Dubeyko@ibm.com \
    --cc=frank.li@vivo.com \
    --cc=glaubitz@physik.fu-berlin.de \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=slava@dubeyko.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.