* [PATCH] f2fs: add error checking in do_write_page()
@ 2025-07-24 15:59 ` mason.zhang
0 siblings, 0 replies; 4+ messages in thread
From: mason.zhang @ 2025-07-24 15:59 UTC (permalink / raw)
To: chao; +Cc: linux-f2fs-devel, linux-kernel, masonzhang.linuxer
Otherwise, the filesystem may unaware of potential file corruption.
Signed-off-by: mason.zhang <masonzhang.linuxer@gmail.com>
---
fs/f2fs/segment.c | 7 +++++--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/fs/f2fs/segment.c b/fs/f2fs/segment.c
index ae1223ef648f..ce80ba226aed 100644
--- a/fs/f2fs/segment.c
+++ b/fs/f2fs/segment.c
@@ -3936,12 +3936,15 @@ static void do_write_page(struct f2fs_summary *sum, struct f2fs_io_info *fio)
int seg_type = log_type_to_seg_type(type);
bool keep_order = (f2fs_lfs_mode(fio->sbi) &&
seg_type == CURSEG_COLD_DATA);
+ int err;
if (keep_order)
f2fs_down_read(&fio->sbi->io_order_lock);
- if (f2fs_allocate_data_block(fio->sbi, fio->page, fio->old_blkaddr,
- &fio->new_blkaddr, sum, type, fio)) {
+ err = f2fs_allocate_data_block(fio->sbi, fio->page, fio->old_blkaddr,
+ &fio->new_blkaddr, sum, type, fio);
+ if (unlikely(err)) {
+ f2fs_err(fio->sbi, "Failed to allocate data block(%d)", err);
if (fscrypt_inode_uses_fs_layer_crypto(folio->mapping->host))
fscrypt_finalize_bounce_page(&fio->encrypted_page);
folio_end_writeback(folio);
--
2.50.0
^ permalink raw reply related [flat|nested] 4+ messages in thread* [f2fs-dev] [PATCH] f2fs: add error checking in do_write_page()
@ 2025-07-24 15:59 ` mason.zhang
0 siblings, 0 replies; 4+ messages in thread
From: mason.zhang @ 2025-07-24 15:59 UTC (permalink / raw)
To: chao; +Cc: linux-kernel, linux-f2fs-devel
Otherwise, the filesystem may unaware of potential file corruption.
Signed-off-by: mason.zhang <masonzhang.linuxer@gmail.com>
---
fs/f2fs/segment.c | 7 +++++--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/fs/f2fs/segment.c b/fs/f2fs/segment.c
index ae1223ef648f..ce80ba226aed 100644
--- a/fs/f2fs/segment.c
+++ b/fs/f2fs/segment.c
@@ -3936,12 +3936,15 @@ static void do_write_page(struct f2fs_summary *sum, struct f2fs_io_info *fio)
int seg_type = log_type_to_seg_type(type);
bool keep_order = (f2fs_lfs_mode(fio->sbi) &&
seg_type == CURSEG_COLD_DATA);
+ int err;
if (keep_order)
f2fs_down_read(&fio->sbi->io_order_lock);
- if (f2fs_allocate_data_block(fio->sbi, fio->page, fio->old_blkaddr,
- &fio->new_blkaddr, sum, type, fio)) {
+ err = f2fs_allocate_data_block(fio->sbi, fio->page, fio->old_blkaddr,
+ &fio->new_blkaddr, sum, type, fio);
+ if (unlikely(err)) {
+ f2fs_err(fio->sbi, "Failed to allocate data block(%d)", err);
if (fscrypt_inode_uses_fs_layer_crypto(folio->mapping->host))
fscrypt_finalize_bounce_page(&fio->encrypted_page);
folio_end_writeback(folio);
--
2.50.0
_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] f2fs: add error checking in do_write_page()
2025-07-24 15:59 ` [f2fs-dev] " mason.zhang
@ 2025-07-25 2:35 ` Chao Yu via Linux-f2fs-devel
-1 siblings, 0 replies; 4+ messages in thread
From: Chao Yu @ 2025-07-25 2:35 UTC (permalink / raw)
To: mason.zhang; +Cc: chao, linux-f2fs-devel, linux-kernel
On 7/24/2025 11:59 PM, mason.zhang wrote:
> Otherwise, the filesystem may unaware of potential file corruption.
>
> Signed-off-by: mason.zhang <masonzhang.linuxer@gmail.com>
> ---
> fs/f2fs/segment.c | 7 +++++--
> 1 file changed, 5 insertions(+), 2 deletions(-)
>
> diff --git a/fs/f2fs/segment.c b/fs/f2fs/segment.c
> index ae1223ef648f..ce80ba226aed 100644
> --- a/fs/f2fs/segment.c
> +++ b/fs/f2fs/segment.c
> @@ -3936,12 +3936,15 @@ static void do_write_page(struct f2fs_summary *sum, struct f2fs_io_info *fio)
> int seg_type = log_type_to_seg_type(type);
> bool keep_order = (f2fs_lfs_mode(fio->sbi) &&
> seg_type == CURSEG_COLD_DATA);
> + int err;
>
> if (keep_order)
> f2fs_down_read(&fio->sbi->io_order_lock);
>
> - if (f2fs_allocate_data_block(fio->sbi, fio->page, fio->old_blkaddr,
> - &fio->new_blkaddr, sum, type, fio)) {
> + err = f2fs_allocate_data_block(fio->sbi, fio->page, fio->old_blkaddr,
> + &fio->new_blkaddr, sum, type, fio);
> + if (unlikely(err)) {
> + f2fs_err(fio->sbi, "Failed to allocate data block(%d)", err);
How about using f2fs_err_ratelimited() to avoid too many logs?
Can you please dump more informations about inode, page, blkaddr...?
Thanks,
> if (fscrypt_inode_uses_fs_layer_crypto(folio->mapping->host))
> fscrypt_finalize_bounce_page(&fio->encrypted_page);
> folio_end_writeback(folio);
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [f2fs-dev] [PATCH] f2fs: add error checking in do_write_page()
@ 2025-07-25 2:35 ` Chao Yu via Linux-f2fs-devel
0 siblings, 0 replies; 4+ messages in thread
From: Chao Yu via Linux-f2fs-devel @ 2025-07-25 2:35 UTC (permalink / raw)
To: mason.zhang; +Cc: linux-kernel, linux-f2fs-devel
On 7/24/2025 11:59 PM, mason.zhang wrote:
> Otherwise, the filesystem may unaware of potential file corruption.
>
> Signed-off-by: mason.zhang <masonzhang.linuxer@gmail.com>
> ---
> fs/f2fs/segment.c | 7 +++++--
> 1 file changed, 5 insertions(+), 2 deletions(-)
>
> diff --git a/fs/f2fs/segment.c b/fs/f2fs/segment.c
> index ae1223ef648f..ce80ba226aed 100644
> --- a/fs/f2fs/segment.c
> +++ b/fs/f2fs/segment.c
> @@ -3936,12 +3936,15 @@ static void do_write_page(struct f2fs_summary *sum, struct f2fs_io_info *fio)
> int seg_type = log_type_to_seg_type(type);
> bool keep_order = (f2fs_lfs_mode(fio->sbi) &&
> seg_type == CURSEG_COLD_DATA);
> + int err;
>
> if (keep_order)
> f2fs_down_read(&fio->sbi->io_order_lock);
>
> - if (f2fs_allocate_data_block(fio->sbi, fio->page, fio->old_blkaddr,
> - &fio->new_blkaddr, sum, type, fio)) {
> + err = f2fs_allocate_data_block(fio->sbi, fio->page, fio->old_blkaddr,
> + &fio->new_blkaddr, sum, type, fio);
> + if (unlikely(err)) {
> + f2fs_err(fio->sbi, "Failed to allocate data block(%d)", err);
How about using f2fs_err_ratelimited() to avoid too many logs?
Can you please dump more informations about inode, page, blkaddr...?
Thanks,
> if (fscrypt_inode_uses_fs_layer_crypto(folio->mapping->host))
> fscrypt_finalize_bounce_page(&fio->encrypted_page);
> folio_end_writeback(folio);
_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2025-07-25 2:35 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-07-24 15:59 [PATCH] f2fs: add error checking in do_write_page() mason.zhang
2025-07-24 15:59 ` [f2fs-dev] " mason.zhang
2025-07-25 2:35 ` Chao Yu
2025-07-25 2:35 ` [f2fs-dev] " Chao Yu via Linux-f2fs-devel
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.