All of lore.kernel.org
 help / color / mirror / Atom feed
* [meta-ti][scarthgap][PATCH 1/3] conf: machine: am64xx: Cleanup assignment whitespace
@ 2025-07-23 21:16 Ryan Eatmon
  2025-07-23 21:16 ` [meta-ti][scarthgap][PATCH 2/3] gadget-init: Add missing SUMMARY Ryan Eatmon
                   ` (2 more replies)
  0 siblings, 3 replies; 5+ messages in thread
From: Ryan Eatmon @ 2025-07-23 21:16 UTC (permalink / raw)
  To: Praneeth Bajjuri, Denys Dmytriyenko, meta-ti

A recent change in bitbake requires that all variable assignments have
whitespace between the variable, the operator and the value.

FOO = "1"

Signed-off-by: Ryan Eatmon <reatmon@ti.com>
---
 meta-ti-bsp/conf/machine/include/am64xx.inc | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/meta-ti-bsp/conf/machine/include/am64xx.inc b/meta-ti-bsp/conf/machine/include/am64xx.inc
index 56b56afe..27165547 100644
--- a/meta-ti-bsp/conf/machine/include/am64xx.inc
+++ b/meta-ti-bsp/conf/machine/include/am64xx.inc
@@ -35,4 +35,4 @@ OPTEEMACHINE = "k3-am64x"
 
 MACHINE_ESSENTIAL_EXTRA_RRECOMMENDS += "prueth-fw pruhsr-fw prusw-fw"
 
-TI_WKS_BOOTLOADER_APPEND="console=ttyS2,115200n8"
+TI_WKS_BOOTLOADER_APPEND = "console=ttyS2,115200n8"
-- 
2.17.1



^ permalink raw reply related	[flat|nested] 5+ messages in thread

* [meta-ti][scarthgap][PATCH 2/3] gadget-init: Add missing SUMMARY
  2025-07-23 21:16 [meta-ti][scarthgap][PATCH 1/3] conf: machine: am64xx: Cleanup assignment whitespace Ryan Eatmon
@ 2025-07-23 21:16 ` Ryan Eatmon
  2025-07-23 21:16 ` [meta-ti][scarthgap][PATCH 3/3] check_yocto_rules: Add new rule for recent change Ryan Eatmon
  2025-07-24 21:52 ` [meta-ti][scarthgap][PATCH 1/3] conf: machine: am64xx: Cleanup assignment whitespace Denys Dmytriyenko
  2 siblings, 0 replies; 5+ messages in thread
From: Ryan Eatmon @ 2025-07-23 21:16 UTC (permalink / raw)
  To: Praneeth Bajjuri, Denys Dmytriyenko, meta-ti

Every recipe should have a SUMMARY and that can only be 72 characters at
most.  This recipes had a DESCRIPTION and not SUMMARY.

Signed-off-by: Ryan Eatmon <reatmon@ti.com>
---
 meta-ti-extras/recipes-ti/beagleboard/gadget-init.bb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/meta-ti-extras/recipes-ti/beagleboard/gadget-init.bb b/meta-ti-extras/recipes-ti/beagleboard/gadget-init.bb
index 3ab00ec3..27b2520e 100644
--- a/meta-ti-extras/recipes-ti/beagleboard/gadget-init.bb
+++ b/meta-ti-extras/recipes-ti/beagleboard/gadget-init.bb
@@ -1,4 +1,4 @@
-DESCRIPTION = "Units to initialize usb gadgets"
+SUMMARY = "Units to initialize usb gadgets"
 
 PR = "r19"
 
-- 
2.17.1



^ permalink raw reply related	[flat|nested] 5+ messages in thread

* [meta-ti][scarthgap][PATCH 3/3] check_yocto_rules: Add new rule for recent change
  2025-07-23 21:16 [meta-ti][scarthgap][PATCH 1/3] conf: machine: am64xx: Cleanup assignment whitespace Ryan Eatmon
  2025-07-23 21:16 ` [meta-ti][scarthgap][PATCH 2/3] gadget-init: Add missing SUMMARY Ryan Eatmon
@ 2025-07-23 21:16 ` Ryan Eatmon
  2025-07-24 21:52 ` [meta-ti][scarthgap][PATCH 1/3] conf: machine: am64xx: Cleanup assignment whitespace Denys Dmytriyenko
  2 siblings, 0 replies; 5+ messages in thread
From: Ryan Eatmon @ 2025-07-23 21:16 UTC (permalink / raw)
  To: Praneeth Bajjuri, Denys Dmytriyenko, meta-ti

- The UBOOT_VERSION bbappend does not need a guard since we are
modifying our own layer.

Signed-off-by: Ryan Eatmon <reatmon@ti.com>
---
 check_yocto_rules.json | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/check_yocto_rules.json b/check_yocto_rules.json
index 7e8eb211..6d33c0aa 100644
--- a/check_yocto_rules.json
+++ b/check_yocto_rules.json
@@ -17,7 +17,8 @@
         "skip_files" : [
             "meta-ti-bsp/recipes-core/udev/eudev_%.bbappend",
             "meta-ti-bsp/recipes-devtools/binutils/binutils-cross-canadian_%.bbappend",
-            "meta-ti-bsp/recipes-security/optee/optee-%.bbappend"
+            "meta-ti-bsp/recipes-security/optee/optee-%.bbappend",
+            "meta-ti-bsp/dynamic-layers/openembedded-layer/recipes-bsp/u-boot/u-boot-ti-%.bbappend"
         ]
     },
     "GUARD-2" : {
-- 
2.17.1



^ permalink raw reply related	[flat|nested] 5+ messages in thread

* Re: [meta-ti][scarthgap][PATCH 1/3] conf: machine: am64xx: Cleanup assignment whitespace
  2025-07-23 21:16 [meta-ti][scarthgap][PATCH 1/3] conf: machine: am64xx: Cleanup assignment whitespace Ryan Eatmon
  2025-07-23 21:16 ` [meta-ti][scarthgap][PATCH 2/3] gadget-init: Add missing SUMMARY Ryan Eatmon
  2025-07-23 21:16 ` [meta-ti][scarthgap][PATCH 3/3] check_yocto_rules: Add new rule for recent change Ryan Eatmon
@ 2025-07-24 21:52 ` Denys Dmytriyenko
  2025-07-24 22:07   ` Ryan Eatmon
  2 siblings, 1 reply; 5+ messages in thread
From: Denys Dmytriyenko @ 2025-07-24 21:52 UTC (permalink / raw)
  To: reatmon; +Cc: Praneeth Bajjuri, Denys Dmytriyenko, meta-ti

Is this change scarthgap specific? I see the change that originally added 
TI_WKS_BOOTLOADER_APPEND to scarthgap is now being forward-ported to master, 
thus this fix appears to also be applicable to master?


On Wed, Jul 23, 2025 at 04:16:11PM -0500, Ryan Eatmon via lists.yoctoproject.org wrote:
> A recent change in bitbake requires that all variable assignments have
> whitespace between the variable, the operator and the value.
> 
> FOO = "1"
> 
> Signed-off-by: Ryan Eatmon <reatmon@ti.com>
> ---
>  meta-ti-bsp/conf/machine/include/am64xx.inc | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/meta-ti-bsp/conf/machine/include/am64xx.inc b/meta-ti-bsp/conf/machine/include/am64xx.inc
> index 56b56afe..27165547 100644
> --- a/meta-ti-bsp/conf/machine/include/am64xx.inc
> +++ b/meta-ti-bsp/conf/machine/include/am64xx.inc
> @@ -35,4 +35,4 @@ OPTEEMACHINE = "k3-am64x"
>  
>  MACHINE_ESSENTIAL_EXTRA_RRECOMMENDS += "prueth-fw pruhsr-fw prusw-fw"
>  
> -TI_WKS_BOOTLOADER_APPEND="console=ttyS2,115200n8"
> +TI_WKS_BOOTLOADER_APPEND = "console=ttyS2,115200n8"
> -- 
> 2.17.1


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [meta-ti][scarthgap][PATCH 1/3] conf: machine: am64xx: Cleanup assignment whitespace
  2025-07-24 21:52 ` [meta-ti][scarthgap][PATCH 1/3] conf: machine: am64xx: Cleanup assignment whitespace Denys Dmytriyenko
@ 2025-07-24 22:07   ` Ryan Eatmon
  0 siblings, 0 replies; 5+ messages in thread
From: Ryan Eatmon @ 2025-07-24 22:07 UTC (permalink / raw)
  To: Denys Dmytriyenko; +Cc: Praneeth Bajjuri, Denys Dmytriyenko, meta-ti


Nope.  I meant to send this patch as a combo patch.  For both master and 
scarthgap.  Oops.  Good catch.


On 7/24/2025 4:52 PM, Denys Dmytriyenko wrote:
> Is this change scarthgap specific? I see the change that originally added
> TI_WKS_BOOTLOADER_APPEND to scarthgap is now being forward-ported to master,
> thus this fix appears to also be applicable to master?
> 
> 
> On Wed, Jul 23, 2025 at 04:16:11PM -0500, Ryan Eatmon via lists.yoctoproject.org wrote:
>> A recent change in bitbake requires that all variable assignments have
>> whitespace between the variable, the operator and the value.
>>
>> FOO = "1"
>>
>> Signed-off-by: Ryan Eatmon <reatmon@ti.com>
>> ---
>>   meta-ti-bsp/conf/machine/include/am64xx.inc | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/meta-ti-bsp/conf/machine/include/am64xx.inc b/meta-ti-bsp/conf/machine/include/am64xx.inc
>> index 56b56afe..27165547 100644
>> --- a/meta-ti-bsp/conf/machine/include/am64xx.inc
>> +++ b/meta-ti-bsp/conf/machine/include/am64xx.inc
>> @@ -35,4 +35,4 @@ OPTEEMACHINE = "k3-am64x"
>>   
>>   MACHINE_ESSENTIAL_EXTRA_RRECOMMENDS += "prueth-fw pruhsr-fw prusw-fw"
>>   
>> -TI_WKS_BOOTLOADER_APPEND="console=ttyS2,115200n8"
>> +TI_WKS_BOOTLOADER_APPEND = "console=ttyS2,115200n8"
>> -- 
>> 2.17.1

-- 
Ryan Eatmon                reatmon@ti.com
-----------------------------------------
Texas Instruments, Inc.  -  LCPD  -  MGTS


^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2025-07-24 22:07 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-07-23 21:16 [meta-ti][scarthgap][PATCH 1/3] conf: machine: am64xx: Cleanup assignment whitespace Ryan Eatmon
2025-07-23 21:16 ` [meta-ti][scarthgap][PATCH 2/3] gadget-init: Add missing SUMMARY Ryan Eatmon
2025-07-23 21:16 ` [meta-ti][scarthgap][PATCH 3/3] check_yocto_rules: Add new rule for recent change Ryan Eatmon
2025-07-24 21:52 ` [meta-ti][scarthgap][PATCH 1/3] conf: machine: am64xx: Cleanup assignment whitespace Denys Dmytriyenko
2025-07-24 22:07   ` Ryan Eatmon

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.