From: "Rob Herring (Arm)" <robh@kernel.org>
To: Jonas Karlman <jonas@kwiboo.se>
Cc: linux-rockchip@lists.infradead.org,
linux-arm-kernel@lists.infradead.org,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
linux-kernel@vger.kernel.org,
Kishon Vijay Abraham I <kishon@kernel.org>,
Yao Zi <ziyao@disroot.org>,
devicetree@vger.kernel.org, Conor Dooley <conor+dt@kernel.org>,
Heiko Stuebner <heiko@sntech.de>,
linux-phy@lists.infradead.org, Vinod Koul <vkoul@kernel.org>,
Chukun Pan <amadeus@jmu.edu.cn>
Subject: Re: [PATCH 01/11] dt-bindings: phy: rockchip,inno-usb2phy: Require GRF for RK3568/RV1108
Date: Fri, 25 Jul 2025 18:03:55 -0500 [thread overview]
Message-ID: <20250725230355.GB1993803-robh@kernel.org> (raw)
In-Reply-To: <20250723122323.2344916-2-jonas@kwiboo.se>
On Wed, 23 Jul 2025 12:22:59 +0000, Jonas Karlman wrote:
> Typically these Rockchip USB2 PHYs are fully contained within a single
> GRF. However, for RK3568 and RV1108 regs to control the USB2 PHY is
> located in a different GRF compared to the base address.
>
> Update this binding to require rockchip,usbgrf for RK3568 and RV1108 to
> properly reflect that the USB GRF is required to control the USB2 PHYs
> on these variants. Also disable use of rockchip,usbgrf for variants
> where it is not required.
>
> This should not introduce any breakage as the affected usb2phy nodes for
> RK3568 and RV1108 were added together with a rockchip,usbgrf phandle in
> their initial commit.
>
> Signed-off-by: Jonas Karlman <jonas@kwiboo.se>
> ---
> .../bindings/phy/rockchip,inno-usb2phy.yaml | 14 ++++++++++++++
> 1 file changed, 14 insertions(+)
>
Acked-by: Rob Herring (Arm) <robh@kernel.org>
WARNING: multiple messages have this Message-ID (diff)
From: "Rob Herring (Arm)" <robh@kernel.org>
To: Jonas Karlman <jonas@kwiboo.se>
Cc: linux-rockchip@lists.infradead.org,
linux-arm-kernel@lists.infradead.org,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
linux-kernel@vger.kernel.org,
Kishon Vijay Abraham I <kishon@kernel.org>,
Yao Zi <ziyao@disroot.org>,
devicetree@vger.kernel.org, Conor Dooley <conor+dt@kernel.org>,
Heiko Stuebner <heiko@sntech.de>,
linux-phy@lists.infradead.org, Vinod Koul <vkoul@kernel.org>,
Chukun Pan <amadeus@jmu.edu.cn>
Subject: Re: [PATCH 01/11] dt-bindings: phy: rockchip,inno-usb2phy: Require GRF for RK3568/RV1108
Date: Fri, 25 Jul 2025 18:03:55 -0500 [thread overview]
Message-ID: <20250725230355.GB1993803-robh@kernel.org> (raw)
In-Reply-To: <20250723122323.2344916-2-jonas@kwiboo.se>
On Wed, 23 Jul 2025 12:22:59 +0000, Jonas Karlman wrote:
> Typically these Rockchip USB2 PHYs are fully contained within a single
> GRF. However, for RK3568 and RV1108 regs to control the USB2 PHY is
> located in a different GRF compared to the base address.
>
> Update this binding to require rockchip,usbgrf for RK3568 and RV1108 to
> properly reflect that the USB GRF is required to control the USB2 PHYs
> on these variants. Also disable use of rockchip,usbgrf for variants
> where it is not required.
>
> This should not introduce any breakage as the affected usb2phy nodes for
> RK3568 and RV1108 were added together with a rockchip,usbgrf phandle in
> their initial commit.
>
> Signed-off-by: Jonas Karlman <jonas@kwiboo.se>
> ---
> .../bindings/phy/rockchip,inno-usb2phy.yaml | 14 ++++++++++++++
> 1 file changed, 14 insertions(+)
>
Acked-by: Rob Herring (Arm) <robh@kernel.org>
--
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy
WARNING: multiple messages have this Message-ID (diff)
From: "Rob Herring (Arm)" <robh@kernel.org>
To: Jonas Karlman <jonas@kwiboo.se>
Cc: linux-rockchip@lists.infradead.org,
linux-arm-kernel@lists.infradead.org,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
linux-kernel@vger.kernel.org,
Kishon Vijay Abraham I <kishon@kernel.org>,
Yao Zi <ziyao@disroot.org>,
devicetree@vger.kernel.org, Conor Dooley <conor+dt@kernel.org>,
Heiko Stuebner <heiko@sntech.de>,
linux-phy@lists.infradead.org, Vinod Koul <vkoul@kernel.org>,
Chukun Pan <amadeus@jmu.edu.cn>
Subject: Re: [PATCH 01/11] dt-bindings: phy: rockchip,inno-usb2phy: Require GRF for RK3568/RV1108
Date: Fri, 25 Jul 2025 18:03:55 -0500 [thread overview]
Message-ID: <20250725230355.GB1993803-robh@kernel.org> (raw)
In-Reply-To: <20250723122323.2344916-2-jonas@kwiboo.se>
On Wed, 23 Jul 2025 12:22:59 +0000, Jonas Karlman wrote:
> Typically these Rockchip USB2 PHYs are fully contained within a single
> GRF. However, for RK3568 and RV1108 regs to control the USB2 PHY is
> located in a different GRF compared to the base address.
>
> Update this binding to require rockchip,usbgrf for RK3568 and RV1108 to
> properly reflect that the USB GRF is required to control the USB2 PHYs
> on these variants. Also disable use of rockchip,usbgrf for variants
> where it is not required.
>
> This should not introduce any breakage as the affected usb2phy nodes for
> RK3568 and RV1108 were added together with a rockchip,usbgrf phandle in
> their initial commit.
>
> Signed-off-by: Jonas Karlman <jonas@kwiboo.se>
> ---
> .../bindings/phy/rockchip,inno-usb2phy.yaml | 14 ++++++++++++++
> 1 file changed, 14 insertions(+)
>
Acked-by: Rob Herring (Arm) <robh@kernel.org>
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
next prev parent reply other threads:[~2025-07-25 23:08 UTC|newest]
Thread overview: 60+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-23 12:22 [PATCH 00/11] rockchip: Add USB 2.0 support for RK3528 Jonas Karlman
2025-07-23 12:22 ` Jonas Karlman
2025-07-23 12:22 ` Jonas Karlman
2025-07-23 12:22 ` [PATCH 01/11] dt-bindings: phy: rockchip,inno-usb2phy: Require GRF for RK3568/RV1108 Jonas Karlman
2025-07-23 12:22 ` Jonas Karlman
2025-07-23 12:22 ` Jonas Karlman
2025-07-25 23:03 ` Rob Herring (Arm) [this message]
2025-07-25 23:03 ` Rob Herring (Arm)
2025-07-25 23:03 ` Rob Herring (Arm)
2025-07-23 12:23 ` [PATCH 02/11] phy: rockchip: inno-usb2: Simplify rockchip,usbgrf handling Jonas Karlman
2025-07-23 12:23 ` Jonas Karlman
2025-07-23 12:23 ` Jonas Karlman
2025-07-23 12:23 ` [PATCH 03/11] dt-bindings: phy: rockchip,inno-usb2phy: Add compatible for RK3528 Jonas Karlman
2025-07-23 12:23 ` Jonas Karlman
2025-07-23 12:23 ` Jonas Karlman
2025-07-25 23:04 ` Rob Herring (Arm)
2025-07-25 23:04 ` Rob Herring (Arm)
2025-07-25 23:04 ` Rob Herring (Arm)
2025-07-23 12:23 ` [PATCH 04/11] phy: rockchip: inno-usb2: Add clkout_ctl_phy support Jonas Karlman
2025-07-23 12:23 ` Jonas Karlman
2025-07-23 12:23 ` Jonas Karlman
2025-07-23 12:23 ` [PATCH 05/11] phy: rockchip: inno-usb2: Add support for RK3528 Jonas Karlman
2025-07-23 12:23 ` Jonas Karlman
2025-07-23 12:23 ` Jonas Karlman
2025-08-12 15:49 ` Vinod Koul
2025-08-12 15:49 ` Vinod Koul
2025-08-12 15:49 ` Vinod Koul
2025-10-19 14:44 ` Jonas Karlman
2025-10-19 14:44 ` Jonas Karlman
2025-10-19 14:44 ` Jonas Karlman
2025-07-23 12:23 ` [PATCH 06/11] dt-bindings: usb: dwc3: Add compatible " Jonas Karlman
2025-07-23 12:23 ` Jonas Karlman
2025-07-23 12:23 ` Jonas Karlman
2025-07-25 23:06 ` Rob Herring (Arm)
2025-07-25 23:06 ` Rob Herring (Arm)
2025-07-25 23:06 ` Rob Herring (Arm)
2025-07-23 12:23 ` [PATCH 07/11] arm64: dts: rockchip: Add USB nodes " Jonas Karlman
2025-07-23 12:23 ` Jonas Karlman
2025-07-23 12:23 ` Jonas Karlman
2025-07-23 14:30 ` Chukun Pan
2025-07-23 14:30 ` Chukun Pan
2025-07-23 14:30 ` Chukun Pan
2025-07-23 15:30 ` Jonas Karlman
2025-07-23 15:30 ` Jonas Karlman
2025-07-23 15:30 ` Jonas Karlman
2025-08-07 7:00 ` Chukun Pan
2025-08-07 7:00 ` Chukun Pan
2025-08-07 7:00 ` Chukun Pan
2025-07-23 12:23 ` [PATCH 08/11] arm64: dts: rockchip: Enable USB 2.0 ports on Radxa E20C Jonas Karlman
2025-07-23 12:23 ` Jonas Karlman
2025-07-23 12:23 ` Jonas Karlman
2025-07-23 12:23 ` [PATCH 09/11] arm64: dts: rockchip: Enable USB 2.0 ports on Radxa ROCK 2A/2F Jonas Karlman
2025-07-23 12:23 ` Jonas Karlman
2025-07-23 12:23 ` Jonas Karlman
2025-07-23 12:23 ` [PATCH 10/11] arm64: dts: rockchip: Enable USB 2.0 ports on ArmSoM Sige1 Jonas Karlman
2025-07-23 12:23 ` Jonas Karlman
2025-07-23 12:23 ` Jonas Karlman
2025-07-23 12:23 ` [PATCH 11/11] arm64: dts: rockchip: Enable USB 2.0 ports on NanoPi Zero2 Jonas Karlman
2025-07-23 12:23 ` Jonas Karlman
2025-07-23 12:23 ` Jonas Karlman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250725230355.GB1993803-robh@kernel.org \
--to=robh@kernel.org \
--cc=amadeus@jmu.edu.cn \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=heiko@sntech.de \
--cc=jonas@kwiboo.se \
--cc=kishon@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-phy@lists.infradead.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=vkoul@kernel.org \
--cc=ziyao@disroot.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.