[sj:damon/next 34/101] mm/mprotect.c:726:13: error: 'PAGE_NONE' undeclared; did you mean 'PAGE_U_NONE'?

[sj:damon/next 34/101] mm/mprotect.c:726:13: error: 'PAGE_NONE' undeclared; did you mean 'PAGE_U_NONE'?

[kernel test robot]

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/sj/linux.git damon/next
head:   de1df744d5c68470ace629863436a2b0b7360254
commit: af1d8aa70d3ae773ee9c7b9782ccfef1876bb027 [34/101] mm/mprotect: use PAGE_NONE for change_protection(..., MM_CP_PROT_DAMON)
config: arc-randconfig-001-20250727 (https://download.01.org/0day-ci/archive/20250727/202507270855.YvsYlfrv-lkp@intel.com/config)
compiler: arc-linux-gcc (GCC) 8.5.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250727/202507270855.YvsYlfrv-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202507270855.YvsYlfrv-lkp@intel.com/

All errors (new ones prefixed by >>):

   In file included from include/linux/pagewalk.h:5,
                    from mm/mprotect.c:12:
   include/linux/mm.h:78: warning: "PAGES_TO_MB" redefined
    #define PAGES_TO_MB(pages) ((pages) >> (20 - PAGE_SHIFT))
    
   In file included from arch/arc/include/asm/irqflags-compact.h:16,
                    from arch/arc/include/asm/irqflags.h:11,
                    from include/linux/irqflags.h:18,
                    from include/linux/spinlock.h:59,
                    from include/linux/mmzone.h:8,
                    from include/linux/gfp.h:7,
                    from include/linux/mm.h:7,
                    from include/linux/pagewalk.h:5,
                    from mm/mprotect.c:12:
   arch/arc/include/asm/arcregs.h:155: note: this is the location of the previous definition
    #define PAGES_TO_MB(n_pages) (PAGES_TO_KB(n_pages) >> 10)
    
   mm/mprotect.c: In function 'change_protection':
>> mm/mprotect.c:726:13: error: 'PAGE_NONE' undeclared (first use in this function); did you mean 'PAGE_U_NONE'?
      newprot = PAGE_NONE;
                ^~~~~~~~~
                PAGE_U_NONE
   mm/mprotect.c:726:13: note: each undeclared identifier is reported only once for each function it appears in


vim +726 mm/mprotect.c

   723	
   724	#ifdef CONFIG_DAMON
   725		if (cp_flags & MM_CP_PROT_DAMON)
 > 726			newprot = PAGE_NONE;
   727	#endif
   728	
   729		if (is_vm_hugetlb_page(vma))
   730			pages = hugetlb_change_protection(vma, start, end, newprot,
   731							  cp_flags);
   732		else
   733			pages = change_protection_range(tlb, vma, start, end, newprot,
   734							cp_flags);
   735	
   736		return pages;
   737	}
   738	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

Re: [sj:damon/next 34/101] mm/mprotect.c:726:13: error: 'PAGE_NONE' undeclared; did you mean 'PAGE_U_NONE'?

[SeongJae Park]

On Sun, 27 Jul 2025 08:16:01 +0800 kernel test robot <lkp@intel.com> wrote:

> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/sj/linux.git damon/next
> head:   de1df744d5c68470ace629863436a2b0b7360254
> commit: af1d8aa70d3ae773ee9c7b9782ccfef1876bb027 [34/101] mm/mprotect: use PAGE_NONE for change_protection(..., MM_CP_PROT_DAMON)
> config: arc-randconfig-001-20250727 (https://download.01.org/0day-ci/archive/20250727/202507270855.YvsYlfrv-lkp@intel.com/config)
> compiler: arc-linux-gcc (GCC) 8.5.0
> reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250727/202507270855.YvsYlfrv-lkp@intel.com/reproduce)
> 
> If you fix the issue in a separate patch/commit (i.e. not just a new version of
> the same patch/commit), kindly add following tags
> | Reported-by: kernel test robot <lkp@intel.com>
> | Closes: https://lore.kernel.org/oe-kbuild-all/202507270855.YvsYlfrv-lkp@intel.com/
> 
> All errors (new ones prefixed by >>):
> 
>    In file included from include/linux/pagewalk.h:5,
>                     from mm/mprotect.c:12:
>    include/linux/mm.h:78: warning: "PAGES_TO_MB" redefined
>     #define PAGES_TO_MB(pages) ((pages) >> (20 - PAGE_SHIFT))
>     
>    In file included from arch/arc/include/asm/irqflags-compact.h:16,
>                     from arch/arc/include/asm/irqflags.h:11,
>                     from include/linux/irqflags.h:18,
>                     from include/linux/spinlock.h:59,
>                     from include/linux/mmzone.h:8,
>                     from include/linux/gfp.h:7,
>                     from include/linux/mm.h:7,
>                     from include/linux/pagewalk.h:5,
>                     from mm/mprotect.c:12:
>    arch/arc/include/asm/arcregs.h:155: note: this is the location of the previous definition
>     #define PAGES_TO_MB(n_pages) (PAGES_TO_KB(n_pages) >> 10)
>     
>    mm/mprotect.c: In function 'change_protection':
> >> mm/mprotect.c:726:13: error: 'PAGE_NONE' undeclared (first use in this function); did you mean 'PAGE_U_NONE'?
>       newprot = PAGE_NONE;
>                 ^~~~~~~~~
>                 PAGE_U_NONE
>    mm/mprotect.c:726:13: note: each undeclared identifier is reported only once for each function it appears in

Thank you for this report!  I just pushed a fix:
https://git.kernel.org/pub/scm/linux/kernel/git/sj/linux.git/commit/?h=damon/next&id=bbc588c9166d6ff4ac9b270929732760215a94c3

Reproducing the error on my own failed as below, though, so I was unable to
verify the fix on my own.  Please let me know if anything wrong.

    $ COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-8.5.0 ~/lkp-tests/kbuild/make.cross W=1 O=../linux.out/ ARCH=arc SHELL=/bin/bash mm/
    Compiler will be installed in ~/0day
    lftpget -c https://cdn.kernel.org/pub/tools/crosstool/files/bin/x86_64/./8.5.0/x86_64-gcc-8.5.0-nolibc-sparc-linux.tar.xz
    ~
    tar Jxf ~/0day/8.5.0/x86_64-gcc-8.5.0-nolibc-sparc-linux.tar.xz -C ~/0day
    No gcc cross compiler for arc
    setup_crosstool failed


Thanks,
SJ

[...]

Re: [sj:damon/next 34/101] mm/mprotect.c:726:13: error: 'PAGE_NONE' undeclared; did you mean 'PAGE_U_NONE'?

[SeongJae Park]

On Sun, 27 Jul 2025 10:45:44 -0700 SeongJae Park <sj@kernel.org> wrote:

> On Sun, 27 Jul 2025 08:16:01 +0800 kernel test robot <lkp@intel.com> wrote:
> 
> > tree:   https://git.kernel.org/pub/scm/linux/kernel/git/sj/linux.git damon/next
> > head:   de1df744d5c68470ace629863436a2b0b7360254
> > commit: af1d8aa70d3ae773ee9c7b9782ccfef1876bb027 [34/101] mm/mprotect: use PAGE_NONE for change_protection(..., MM_CP_PROT_DAMON)
> > config: arc-randconfig-001-20250727 (https://download.01.org/0day-ci/archive/20250727/202507270855.YvsYlfrv-lkp@intel.com/config)
> > compiler: arc-linux-gcc (GCC) 8.5.0
> > reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250727/202507270855.YvsYlfrv-lkp@intel.com/reproduce)
> > 
> > If you fix the issue in a separate patch/commit (i.e. not just a new version of
> > the same patch/commit), kindly add following tags
> > | Reported-by: kernel test robot <lkp@intel.com>
> > | Closes: https://lore.kernel.org/oe-kbuild-all/202507270855.YvsYlfrv-lkp@intel.com/
> > 
> > All errors (new ones prefixed by >>):
> > 
> >    In file included from include/linux/pagewalk.h:5,
> >                     from mm/mprotect.c:12:
> >    include/linux/mm.h:78: warning: "PAGES_TO_MB" redefined
> >     #define PAGES_TO_MB(pages) ((pages) >> (20 - PAGE_SHIFT))
> >     
> >    In file included from arch/arc/include/asm/irqflags-compact.h:16,
> >                     from arch/arc/include/asm/irqflags.h:11,
> >                     from include/linux/irqflags.h:18,
> >                     from include/linux/spinlock.h:59,
> >                     from include/linux/mmzone.h:8,
> >                     from include/linux/gfp.h:7,
> >                     from include/linux/mm.h:7,
> >                     from include/linux/pagewalk.h:5,
> >                     from mm/mprotect.c:12:
> >    arch/arc/include/asm/arcregs.h:155: note: this is the location of the previous definition
> >     #define PAGES_TO_MB(n_pages) (PAGES_TO_KB(n_pages) >> 10)
> >     
> >    mm/mprotect.c: In function 'change_protection':
> > >> mm/mprotect.c:726:13: error: 'PAGE_NONE' undeclared (first use in this function); did you mean 'PAGE_U_NONE'?
> >       newprot = PAGE_NONE;
> >                 ^~~~~~~~~
> >                 PAGE_U_NONE
> >    mm/mprotect.c:726:13: note: each undeclared identifier is reported only once for each function it appears in
> 
> Thank you for this report!  I just pushed a fix:
> https://git.kernel.org/pub/scm/linux/kernel/git/sj/linux.git/commit/?h=damon/next&id=bbc588c9166d6ff4ac9b270929732760215a94c3

There was a silly typo, sorry.  Pushed another fix for that:
https://git.kernel.org/pub/scm/linux/kernel/git/sj/linux.git/commit/?h=damon/next&id=7e65eab68ae7ff67bcaaa0466278aab7ec966604


Thanks,
SJ

[...]