All of lore.kernel.org
 help / color / mirror / Atom feed
From: kernel test robot <lkp@intel.com>
To: oe-kbuild@lists.linux.dev
Cc: lkp@intel.com, Dan Carpenter <error27@gmail.com>
Subject: Re: [PATCH net-next 4/5] dpll: zl3073x: Refactor DPLL initialization
Date: Tue, 29 Jul 2025 00:11:02 +0800	[thread overview]
Message-ID: <202507282309.ToVNHlep-lkp@intel.com> (raw)

BCC: lkp@intel.com
CC: oe-kbuild-all@lists.linux.dev
In-Reply-To: <20250725154136.1008132-5-ivecera@redhat.com>
References: <20250725154136.1008132-5-ivecera@redhat.com>
TO: Ivan Vecera <ivecera@redhat.com>
TO: netdev@vger.kernel.org
CC: Jiri Pirko <jiri@resnulli.us>
CC: Eric Dumazet <edumazet@google.com>
CC: Jakub Kicinski <kuba@kernel.org>
CC: Paolo Abeni <pabeni@redhat.com>
CC: Simon Horman <horms@kernel.org>
CC: Jonathan Corbet <corbet@lwn.net>
CC: Prathosh Satish <Prathosh.Satish@microchip.com>
CC: linux-doc@vger.kernel.org
CC: linux-kernel@vger.kernel.org
CC: Michal Schmidt <mschmidt@redhat.com>
CC: Petr Oros <poros@redhat.com>

Hi Ivan,

kernel test robot noticed the following build warnings:

[auto build test WARNING on net-next/main]

url:    https://github.com/intel-lab-lkp/linux/commits/Ivan-Vecera/dpll-zl3073x-Add-functions-to-access-hardware-registers/20250725-234600
base:   net-next/main
patch link:    https://lore.kernel.org/r/20250725154136.1008132-5-ivecera%40redhat.com
patch subject: [PATCH net-next 4/5] dpll: zl3073x: Refactor DPLL initialization
:::::: branch date: 3 days ago
:::::: commit date: 3 days ago
config: nios2-randconfig-r072-20250728 (https://download.01.org/0day-ci/archive/20250728/202507282309.ToVNHlep-lkp@intel.com/config)
compiler: nios2-linux-gcc (GCC) 8.5.0

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Reported-by: Dan Carpenter <error27@gmail.com>
| Closes: https://lore.kernel.org/r/202507282309.ToVNHlep-lkp@intel.com/

smatch warnings:
drivers/dpll/zl3073x/core.c:996 zl3073x_dev_phase_meas_setup() error: uninitialized symbol 'mask'.

vim +/mask +996 drivers/dpll/zl3073x/core.c

75a71ecc24125f Ivan Vecera 2025-07-04  958  
cafbc8d62bf9bd Ivan Vecera 2025-07-25  959  /**
cafbc8d62bf9bd Ivan Vecera 2025-07-25  960   * zl3073x_dev_phase_meas_setup - setup phase offset measurement
cafbc8d62bf9bd Ivan Vecera 2025-07-25  961   * @zldev: pointer to zl3073x_dev structure
cafbc8d62bf9bd Ivan Vecera 2025-07-25  962   *
cafbc8d62bf9bd Ivan Vecera 2025-07-25  963   * Enable phase offset measurement block, set measurement averaging factor
cafbc8d62bf9bd Ivan Vecera 2025-07-25  964   * and enable DPLL-to-its-ref phase measurement for all DPLLs.
cafbc8d62bf9bd Ivan Vecera 2025-07-25  965   *
cafbc8d62bf9bd Ivan Vecera 2025-07-25  966   * Returns: 0 on success, <0 on error
cafbc8d62bf9bd Ivan Vecera 2025-07-25  967   */
cafbc8d62bf9bd Ivan Vecera 2025-07-25  968  static int
cafbc8d62bf9bd Ivan Vecera 2025-07-25  969  zl3073x_dev_phase_meas_setup(struct zl3073x_dev *zldev)
cafbc8d62bf9bd Ivan Vecera 2025-07-25  970  {
cafbc8d62bf9bd Ivan Vecera 2025-07-25  971  	struct zl3073x_dpll *zldpll;
cafbc8d62bf9bd Ivan Vecera 2025-07-25  972  	u8 dpll_meas_ctrl, mask;
cafbc8d62bf9bd Ivan Vecera 2025-07-25  973  	int rc;
cafbc8d62bf9bd Ivan Vecera 2025-07-25  974  
cafbc8d62bf9bd Ivan Vecera 2025-07-25  975  	/* Read DPLL phase measurement control register */
cafbc8d62bf9bd Ivan Vecera 2025-07-25  976  	rc = zl3073x_read_u8(zldev, ZL_REG_DPLL_MEAS_CTRL, &dpll_meas_ctrl);
cafbc8d62bf9bd Ivan Vecera 2025-07-25  977  	if (rc)
cafbc8d62bf9bd Ivan Vecera 2025-07-25  978  		return rc;
cafbc8d62bf9bd Ivan Vecera 2025-07-25  979  
cafbc8d62bf9bd Ivan Vecera 2025-07-25  980  	/* Setup phase measurement averaging factor */
cafbc8d62bf9bd Ivan Vecera 2025-07-25  981  	dpll_meas_ctrl &= ~ZL_DPLL_MEAS_CTRL_AVG_FACTOR;
cafbc8d62bf9bd Ivan Vecera 2025-07-25  982  	dpll_meas_ctrl |= FIELD_PREP(ZL_DPLL_MEAS_CTRL_AVG_FACTOR, 3);
cafbc8d62bf9bd Ivan Vecera 2025-07-25  983  
cafbc8d62bf9bd Ivan Vecera 2025-07-25  984  	/* Enable DPLL measurement block */
cafbc8d62bf9bd Ivan Vecera 2025-07-25  985  	dpll_meas_ctrl |= ZL_DPLL_MEAS_CTRL_EN;
cafbc8d62bf9bd Ivan Vecera 2025-07-25  986  
cafbc8d62bf9bd Ivan Vecera 2025-07-25  987  	/* Update phase measurement control register */
cafbc8d62bf9bd Ivan Vecera 2025-07-25  988  	rc = zl3073x_write_u8(zldev, ZL_REG_DPLL_MEAS_CTRL, dpll_meas_ctrl);
cafbc8d62bf9bd Ivan Vecera 2025-07-25  989  	if (rc)
cafbc8d62bf9bd Ivan Vecera 2025-07-25  990  		return rc;
cafbc8d62bf9bd Ivan Vecera 2025-07-25  991  
cafbc8d62bf9bd Ivan Vecera 2025-07-25  992  	/* Enable DPLL-to-connected-ref measurement for each channel */
cafbc8d62bf9bd Ivan Vecera 2025-07-25  993  	list_for_each_entry(zldpll, &zldev->dplls, list)
cafbc8d62bf9bd Ivan Vecera 2025-07-25  994  		mask |= BIT(zldpll->id);
cafbc8d62bf9bd Ivan Vecera 2025-07-25  995  
cafbc8d62bf9bd Ivan Vecera 2025-07-25 @996  	return zl3073x_write_u8(zldev, ZL_REG_DPLL_PHASE_ERR_READ_MASK, mask);
cafbc8d62bf9bd Ivan Vecera 2025-07-25  997  }
cafbc8d62bf9bd Ivan Vecera 2025-07-25  998  

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

             reply	other threads:[~2025-07-28 16:11 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-07-28 16:11 kernel test robot [this message]
  -- strict thread matches above, loose matches on Subject: below --
2025-07-25 15:41 [PATCH net-next 0/5] dpll: zl3073x: Add support for devlink flash Ivan Vecera
2025-07-25 15:41 ` [PATCH net-next 4/5] dpll: zl3073x: Refactor DPLL initialization Ivan Vecera
2025-07-26 10:57   ` kernel test robot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202507282309.ToVNHlep-lkp@intel.com \
    --to=lkp@intel.com \
    --cc=error27@gmail.com \
    --cc=oe-kbuild@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.