All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jakub Kicinski <kuba@kernel.org>
To: Vadim Fedorenko <vadfed@meta.com>
Cc: Andrew Lunn <andrew@lunn.ch>,
	Michael Chan <michael.chan@broadcom.com>,
	Pavan Chebbi <pavan.chebbi@broadcom.com>,
	Tariq Toukan <tariqt@nvidia.com>, Gal Pressman <gal@nvidia.com>,
	<intel-wired-lan@lists.osuosl.org>,
	Donald Hunter <donald.hunter@gmail.com>,
	Paolo Abeni <pabeni@redhat.com>, Simon Horman <horms@kernel.org>,
	<netdev@vger.kernel.org>,
	Vadim Fedorenko <vadim.fedorenko@linux.dev>
Subject: Re: [Intel-wired-lan] [RFC PATCH] ethtool: add FEC bins histogramm report
Date: Tue, 29 Jul 2025 18:48:27 -0700	[thread overview]
Message-ID: <20250729184827.039406f3@kernel.org> (raw)
In-Reply-To: <20250729102354.771859-1-vadfed@meta.com>

On Tue, 29 Jul 2025 03:23:54 -0700 Vadim Fedorenko wrote:
>  /**
>   * struct ethtool_fec_stats - statistics for IEEE 802.3 FEC
> @@ -524,6 +535,7 @@ struct ethtool_fec_stats {
>  		u64 total;
>  		u64 lanes[ETHTOOL_MAX_LANES];
>  	} corrected_blocks, uncorrectable_blocks, corrected_bits;
> +	u64 hist[ETHTOOL_FEC_HIST_MAX];
>  };

Some devices may want these per lane, let's make sure uAPI supports it.

WARNING: multiple messages have this Message-ID (diff)
From: Jakub Kicinski <kuba@kernel.org>
To: Vadim Fedorenko <vadfed@meta.com>
Cc: Andrew Lunn <andrew@lunn.ch>,
	Michael Chan <michael.chan@broadcom.com>,
	Pavan Chebbi <pavan.chebbi@broadcom.com>,
	Tariq Toukan <tariqt@nvidia.com>, Gal Pressman <gal@nvidia.com>,
	<intel-wired-lan@lists.osuosl.org>,
	Donald Hunter <donald.hunter@gmail.com>,
	Paolo Abeni <pabeni@redhat.com>, Simon Horman <horms@kernel.org>,
	<netdev@vger.kernel.org>,
	Vadim Fedorenko <vadim.fedorenko@linux.dev>
Subject: Re: [RFC PATCH] ethtool: add FEC bins histogramm report
Date: Tue, 29 Jul 2025 18:48:27 -0700	[thread overview]
Message-ID: <20250729184827.039406f3@kernel.org> (raw)
In-Reply-To: <20250729102354.771859-1-vadfed@meta.com>

On Tue, 29 Jul 2025 03:23:54 -0700 Vadim Fedorenko wrote:
>  /**
>   * struct ethtool_fec_stats - statistics for IEEE 802.3 FEC
> @@ -524,6 +535,7 @@ struct ethtool_fec_stats {
>  		u64 total;
>  		u64 lanes[ETHTOOL_MAX_LANES];
>  	} corrected_blocks, uncorrectable_blocks, corrected_bits;
> +	u64 hist[ETHTOOL_FEC_HIST_MAX];
>  };

Some devices may want these per lane, let's make sure uAPI supports it.

  parent reply	other threads:[~2025-07-30  1:48 UTC|newest]

Thread overview: 51+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-07-29 10:23 [Intel-wired-lan] [RFC PATCH] ethtool: add FEC bins histogramm report Vadim Fedorenko
2025-07-29 10:23 ` Vadim Fedorenko
2025-07-29 13:48 ` [Intel-wired-lan] " Andrew Lunn
2025-07-29 13:48   ` Andrew Lunn
2025-07-29 16:01   ` [Intel-wired-lan] " Vadim Fedorenko
2025-07-29 16:01     ` Vadim Fedorenko
2025-07-29 16:17     ` [Intel-wired-lan] " Andrew Lunn
2025-07-29 16:17       ` Andrew Lunn
2025-07-29 16:36       ` [Intel-wired-lan] " Vadim Fedorenko
2025-07-29 16:36         ` Vadim Fedorenko
2025-07-29 17:31         ` [Intel-wired-lan] " Andrew Lunn
2025-07-29 17:31           ` Andrew Lunn
2025-07-29 18:07           ` [Intel-wired-lan] " Vadim Fedorenko
2025-07-29 18:07             ` Vadim Fedorenko
2025-07-30  1:51             ` [Intel-wired-lan] " Jakub Kicinski
2025-07-30  1:51               ` Jakub Kicinski
2025-07-30  5:39               ` [Intel-wired-lan] " Gal Pressman
2025-07-30  5:39                 ` Gal Pressman
2025-07-30 12:59                 ` [Intel-wired-lan] " Andrew Lunn
2025-07-30 12:59                   ` Andrew Lunn
2025-07-30 13:54                   ` [Intel-wired-lan] " Gal Pressman
2025-07-30 13:54                     ` Gal Pressman
2025-07-30  9:18               ` [Intel-wired-lan] " Vadim Fedorenko
2025-07-30  9:18                 ` Vadim Fedorenko
2025-07-30 13:44                 ` [Intel-wired-lan] " Jakub Kicinski
2025-07-30 13:44                   ` Jakub Kicinski
2025-07-30 14:39                   ` [Intel-wired-lan] " Vadim Fedorenko
2025-07-30 14:39                     ` Vadim Fedorenko
2025-07-30  1:45 ` [Intel-wired-lan] " Jakub Kicinski
2025-07-30  1:45   ` Jakub Kicinski
2025-07-30  9:22   ` [Intel-wired-lan] " Vadim Fedorenko
2025-07-30  9:22     ` Vadim Fedorenko
2025-07-30 13:45     ` [Intel-wired-lan] " Jakub Kicinski
2025-07-30 13:45       ` Jakub Kicinski
2025-07-30  1:48 ` Jakub Kicinski [this message]
2025-07-30  1:48   ` Jakub Kicinski
2025-07-30  2:53 ` kernel test robot
2025-07-30  5:54 ` [Intel-wired-lan] " Gal Pressman
2025-07-30  5:54   ` Gal Pressman
2025-07-30  9:29   ` [Intel-wired-lan] " Vadim Fedorenko
2025-07-30  9:29     ` Vadim Fedorenko
2025-07-30 10:42     ` [Intel-wired-lan] " Gal Pressman
2025-07-30 10:42       ` Gal Pressman
2025-07-30 11:32       ` [Intel-wired-lan] " Vadim Fedorenko
2025-07-30 11:32         ` Vadim Fedorenko
2025-07-30 13:47         ` [Intel-wired-lan] " Gal Pressman
2025-07-30 13:47           ` Gal Pressman
2025-07-30 14:15           ` [Intel-wired-lan] " Andrew Lunn
2025-07-30 14:15             ` Andrew Lunn
2025-07-30 12:08 ` [Intel-wired-lan] " Carolina Jubran
2025-07-30 12:08   ` Carolina Jubran

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250729184827.039406f3@kernel.org \
    --to=kuba@kernel.org \
    --cc=andrew@lunn.ch \
    --cc=donald.hunter@gmail.com \
    --cc=gal@nvidia.com \
    --cc=horms@kernel.org \
    --cc=intel-wired-lan@lists.osuosl.org \
    --cc=michael.chan@broadcom.com \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=pavan.chebbi@broadcom.com \
    --cc=tariqt@nvidia.com \
    --cc=vadfed@meta.com \
    --cc=vadim.fedorenko@linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.