All of lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH v2] package/modem-manager: Add option to enable AT commands via D-Bus
@ 2025-07-29 17:26 stefan.nickl
  2025-07-29 19:48 ` Thomas Petazzoni via buildroot
                   ` (2 more replies)
  0 siblings, 3 replies; 4+ messages in thread
From: stefan.nickl @ 2025-07-29 17:26 UTC (permalink / raw)
  To: buildroot; +Cc: Aleksander Morgado, Thomas Petazzoni

From: Stefan Nickl <Stefan.Nickl@gmail.com>

Signed-off-by: Stefan Nickl <Stefan.Nickl@gmail.com>
---
Changes v1 -> v2:
  - Don't split LIBQRTR section

 package/modem-manager/Config.in        | 6 ++++++
 package/modem-manager/modem-manager.mk | 6 ++++++
 2 files changed, 12 insertions(+)

diff --git a/package/modem-manager/Config.in b/package/modem-manager/Config.in
index 6990996a86..e03447b96c 100644
--- a/package/modem-manager/Config.in
+++ b/package/modem-manager/Config.in
@@ -38,6 +38,12 @@ config BR2_PACKAGE_MODEM_MANAGER_LIBQRTR
 comment "QRTR support needs a toolchain w/ headers >= 4.15"
 	depends on !BR2_TOOLCHAIN_HEADERS_AT_LEAST_4_15
 
+config BR2_PACKAGE_MODEM_MANAGER_ATVIADBUS
+	bool "at-via-dbus support"
+	help
+	  This option enables support for issuing AT commands
+	  over the D-Bus interface.
+
 endif
 
 comment "modemmanager needs a toolchain w/ wchar, threads, dynamic library"
diff --git a/package/modem-manager/modem-manager.mk b/package/modem-manager/modem-manager.mk
index 932c163175..899e3071a5 100644
--- a/package/modem-manager/modem-manager.mk
+++ b/package/modem-manager/modem-manager.mk
@@ -48,6 +48,12 @@ else
 MODEM_MANAGER_CONF_OPTS += -Dqrtr=false
 endif
 
+ifeq ($(BR2_PACKAGE_MODEM_MANAGER_ATVIADBUS),y)
+MODEM_MANAGER_CONF_OPTS += -Dat_command_via_dbus=true
+else
+MODEM_MANAGER_CONF_OPTS += -Dat_command_via_dbus=false
+endif
+
 ifeq ($(BR2_PACKAGE_SYSTEMD),y)
 MODEM_MANAGER_DEPENDENCIES += systemd
 MODEM_MANAGER_CONF_OPTS += \
-- 
2.50.1

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [Buildroot] [PATCH v2] package/modem-manager: Add option to enable AT commands via D-Bus
  2025-07-29 17:26 [Buildroot] [PATCH v2] package/modem-manager: Add option to enable AT commands via D-Bus stefan.nickl
@ 2025-07-29 19:48 ` Thomas Petazzoni via buildroot
  2025-07-29 23:39 ` Julien Olivain via buildroot
  2025-08-07 18:24 ` Thomas Perale via buildroot
  2 siblings, 0 replies; 4+ messages in thread
From: Thomas Petazzoni via buildroot @ 2025-07-29 19:48 UTC (permalink / raw)
  To: stefan.nickl; +Cc: Aleksander Morgado, buildroot

On Tue, 29 Jul 2025 19:26:39 +0200
stefan.nickl@gmail.com wrote:

> From: Stefan Nickl <Stefan.Nickl@gmail.com>
> 
> Signed-off-by: Stefan Nickl <Stefan.Nickl@gmail.com>

Thanks for the v2!

Reviewed-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>

-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [Buildroot] [PATCH v2] package/modem-manager: Add option to enable AT commands via D-Bus
  2025-07-29 17:26 [Buildroot] [PATCH v2] package/modem-manager: Add option to enable AT commands via D-Bus stefan.nickl
  2025-07-29 19:48 ` Thomas Petazzoni via buildroot
@ 2025-07-29 23:39 ` Julien Olivain via buildroot
  2025-08-07 18:24 ` Thomas Perale via buildroot
  2 siblings, 0 replies; 4+ messages in thread
From: Julien Olivain via buildroot @ 2025-07-29 23:39 UTC (permalink / raw)
  To: stefan.nickl; +Cc: buildroot, Aleksander Morgado, Thomas Petazzoni

On 29/07/2025 19:26, stefan.nickl@gmail.com wrote:
> From: Stefan Nickl <Stefan.Nickl@gmail.com>
> 
> Signed-off-by: Stefan Nickl <Stefan.Nickl@gmail.com>

Applied to master, thanks.
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [Buildroot] [PATCH v2] package/modem-manager: Add option to enable AT commands via D-Bus
  2025-07-29 17:26 [Buildroot] [PATCH v2] package/modem-manager: Add option to enable AT commands via D-Bus stefan.nickl
  2025-07-29 19:48 ` Thomas Petazzoni via buildroot
  2025-07-29 23:39 ` Julien Olivain via buildroot
@ 2025-08-07 18:24 ` Thomas Perale via buildroot
  2 siblings, 0 replies; 4+ messages in thread
From: Thomas Perale via buildroot @ 2025-08-07 18:24 UTC (permalink / raw)
  To: stefan.nickl; +Cc: Thomas Perale, buildroot

In reply of:
> Signed-off-by: Stefan Nickl <Stefan.Nickl@gmail.com>

Applied to 2025.02.x & 2025.05.x. Thanks

> ---
> Changes v1 -> v2:
>   - Don't split LIBQRTR section
> 
>  package/modem-manager/Config.in        | 6 ++++++
>  package/modem-manager/modem-manager.mk | 6 ++++++
>  2 files changed, 12 insertions(+)
> 
> diff --git a/package/modem-manager/Config.in b/package/modem-manager/Config.in
> index 6990996a86..e03447b96c 100644
> --- a/package/modem-manager/Config.in
> +++ b/package/modem-manager/Config.in
> @@ -38,6 +38,12 @@ config BR2_PACKAGE_MODEM_MANAGER_LIBQRTR
>  comment "QRTR support needs a toolchain w/ headers >= 4.15"
>  	depends on !BR2_TOOLCHAIN_HEADERS_AT_LEAST_4_15
>  
> +config BR2_PACKAGE_MODEM_MANAGER_ATVIADBUS
> +	bool "at-via-dbus support"
> +	help
> +	  This option enables support for issuing AT commands
> +	  over the D-Bus interface.
> +
>  endif
>  
>  comment "modemmanager needs a toolchain w/ wchar, threads, dynamic library"
> diff --git a/package/modem-manager/modem-manager.mk b/package/modem-manager/modem-manager.mk
> index 932c163175..899e3071a5 100644
> --- a/package/modem-manager/modem-manager.mk
> +++ b/package/modem-manager/modem-manager.mk
> @@ -48,6 +48,12 @@ else
>  MODEM_MANAGER_CONF_OPTS += -Dqrtr=false
>  endif
>  
> +ifeq ($(BR2_PACKAGE_MODEM_MANAGER_ATVIADBUS),y)
> +MODEM_MANAGER_CONF_OPTS += -Dat_command_via_dbus=true
> +else
> +MODEM_MANAGER_CONF_OPTS += -Dat_command_via_dbus=false
> +endif
> +
>  ifeq ($(BR2_PACKAGE_SYSTEMD),y)
>  MODEM_MANAGER_DEPENDENCIES += systemd
>  MODEM_MANAGER_CONF_OPTS += \
> -- 
> 2.50.1
> 
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2025-08-07 18:25 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-07-29 17:26 [Buildroot] [PATCH v2] package/modem-manager: Add option to enable AT commands via D-Bus stefan.nickl
2025-07-29 19:48 ` Thomas Petazzoni via buildroot
2025-07-29 23:39 ` Julien Olivain via buildroot
2025-08-07 18:24 ` Thomas Perale via buildroot

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.