* [PATCH -next] nvme-auth: remove unneeded semicolon
@ 2025-07-25 7:57 Jiapeng Chong
2025-07-25 8:01 ` Hannes Reinecke
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Jiapeng Chong @ 2025-07-25 7:57 UTC (permalink / raw)
To: hare
Cc: kbusch, axboe, hch, sagi, linux-nvme, inux-kernel, Jiapeng Chong,
Abaci Robot
No functional modification involved.
./drivers/nvme/host/auth.c:745:2-3: Unneeded semicolon.
./drivers/nvme/host/auth.c:755:2-3: Unneeded semicolon.
Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=22937
Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
---
drivers/nvme/host/auth.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/nvme/host/auth.c b/drivers/nvme/host/auth.c
index f6ddbe553289..201fc8809a62 100644
--- a/drivers/nvme/host/auth.c
+++ b/drivers/nvme/host/auth.c
@@ -742,7 +742,7 @@ static int nvme_auth_secure_concat(struct nvme_ctrl *ctrl,
"%s: qid %d failed to generate digest, error %d\n",
__func__, chap->qid, ret);
goto out_free_psk;
- };
+ }
dev_dbg(ctrl->device, "%s: generated digest %s\n",
__func__, digest);
ret = nvme_auth_derive_tls_psk(chap->hash_id, psk, psk_len,
@@ -752,7 +752,7 @@ static int nvme_auth_secure_concat(struct nvme_ctrl *ctrl,
"%s: qid %d failed to derive TLS psk, error %d\n",
__func__, chap->qid, ret);
goto out_free_digest;
- };
+ }
tls_key = nvme_tls_psk_refresh(ctrl->opts->keyring,
ctrl->opts->host->nqn,
--
2.43.5
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH -next] nvme-auth: remove unneeded semicolon
2025-07-25 7:57 [PATCH -next] nvme-auth: remove unneeded semicolon Jiapeng Chong
@ 2025-07-25 8:01 ` Hannes Reinecke
2025-07-28 17:52 ` Chaitanya Kulkarni
2025-07-30 15:54 ` Christoph Hellwig
2 siblings, 0 replies; 4+ messages in thread
From: Hannes Reinecke @ 2025-07-25 8:01 UTC (permalink / raw)
To: Jiapeng Chong
Cc: kbusch, axboe, hch, sagi, linux-nvme, inux-kernel, Abaci Robot
On 7/25/25 09:57, Jiapeng Chong wrote:
> No functional modification involved.
>
> ./drivers/nvme/host/auth.c:745:2-3: Unneeded semicolon.
> ./drivers/nvme/host/auth.c:755:2-3: Unneeded semicolon.
>
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=22937
> Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
> ---
> drivers/nvme/host/auth.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/nvme/host/auth.c b/drivers/nvme/host/auth.c
> index f6ddbe553289..201fc8809a62 100644
> --- a/drivers/nvme/host/auth.c
> +++ b/drivers/nvme/host/auth.c
> @@ -742,7 +742,7 @@ static int nvme_auth_secure_concat(struct nvme_ctrl *ctrl,
> "%s: qid %d failed to generate digest, error %d\n",
> __func__, chap->qid, ret);
> goto out_free_psk;
> - };
> + }
> dev_dbg(ctrl->device, "%s: generated digest %s\n",
> __func__, digest);
> ret = nvme_auth_derive_tls_psk(chap->hash_id, psk, psk_len,
> @@ -752,7 +752,7 @@ static int nvme_auth_secure_concat(struct nvme_ctrl *ctrl,
> "%s: qid %d failed to derive TLS psk, error %d\n",
> __func__, chap->qid, ret);
> goto out_free_digest;
> - };
> + }
>
> tls_key = nvme_tls_psk_refresh(ctrl->opts->keyring,
> ctrl->opts->host->nqn,
Reviewed-by: Hannes Reinecke <hare@suse.de>
Cheers,
Hannes
--
Dr. Hannes Reinecke Kernel Storage Architect
hare@suse.de +49 911 74053 688
SUSE Software Solutions GmbH, Frankenstr. 146, 90461 Nürnberg
HRB 36809 (AG Nürnberg), GF: I. Totev, A. McDonald, W. Knoblich
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH -next] nvme-auth: remove unneeded semicolon
2025-07-25 7:57 [PATCH -next] nvme-auth: remove unneeded semicolon Jiapeng Chong
2025-07-25 8:01 ` Hannes Reinecke
@ 2025-07-28 17:52 ` Chaitanya Kulkarni
2025-07-30 15:54 ` Christoph Hellwig
2 siblings, 0 replies; 4+ messages in thread
From: Chaitanya Kulkarni @ 2025-07-28 17:52 UTC (permalink / raw)
To: Jiapeng Chong, hare@suse.de
Cc: kbusch@kernel.org, axboe@kernel.dk, hch@lst.de, sagi@grimberg.me,
linux-nvme@lists.infradead.org, inux-kernel@vger.kernel.org,
Abaci Robot
On 7/25/25 00:57, Jiapeng Chong wrote:
> No functional modification involved.
>
> ./drivers/nvme/host/auth.c:745:2-3: Unneeded semicolon.
> ./drivers/nvme/host/auth.c:755:2-3: Unneeded semicolon.
>
> Reported-by: Abaci Robot<abaci@linux.alibaba.com>
> Closes:https://bugzilla.openanolis.cn/show_bug.cgi?id=22937
> Signed-off-by: Jiapeng Chong<jiapeng.chong@linux.alibaba.com>
Looks good.
Reviewed-by: Chaitanya Kulkarni <kch@nvidia.com>
-ck
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH -next] nvme-auth: remove unneeded semicolon
2025-07-25 7:57 [PATCH -next] nvme-auth: remove unneeded semicolon Jiapeng Chong
2025-07-25 8:01 ` Hannes Reinecke
2025-07-28 17:52 ` Chaitanya Kulkarni
@ 2025-07-30 15:54 ` Christoph Hellwig
2 siblings, 0 replies; 4+ messages in thread
From: Christoph Hellwig @ 2025-07-30 15:54 UTC (permalink / raw)
To: Jiapeng Chong
Cc: hare, kbusch, axboe, hch, sagi, linux-nvme, inux-kernel,
Abaci Robot
Thanks, applied to nvme-6.17.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2025-07-30 15:55 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-07-25 7:57 [PATCH -next] nvme-auth: remove unneeded semicolon Jiapeng Chong
2025-07-25 8:01 ` Hannes Reinecke
2025-07-28 17:52 ` Chaitanya Kulkarni
2025-07-30 15:54 ` Christoph Hellwig
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.